From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Timotej Lazar <timotej.lazar@araneo.si>
Cc: 41365-done@debbugs.gnu.org
Subject: bug#41365: [PATCH 0/5] Add superstarfighter
Date: Mon, 18 May 2020 20:53:51 +0200 [thread overview]
Message-ID: <871rnhula8.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878shqr23j.fsf@araneo.si>
Hello,
Timotej Lazar <timotej.lazar@araneo.si> writes:
> this series adds SuperStarfighter¹, a small game built with the Godot
> engine. I’m submitting it together with patches for godot needed to
> build the game, and some other improvements. I built the game for x86,
> x86_64 and aarch64 (can’t run it there due to missing 3D
> acceleration).
Great. Thank you.
> The main change to godot is building the headless binary, which is used
> to compile game assets without requiring X. I put this into a separate
> output because it doubles the install size. Compile time is also nearly
> doubled, since most files get compiled twice.
>
> If the longer compile time (in total ~20 minutes on an old i7, and
> ~80 minutes on an even older core duo) is problematic, this can be split
> in two packages. The game depends on both versions to build and run
> though. Thoughts?
I think 80 minutes is not that bad. We can reconsider later.
> I also enabled release build for Godot, removed an old workaround for
> aarch64 (disabling threads caused an infinite loop when building the
> game), and installed the icons to the correct location to be used with
> the .desktop file.
Perfect.
I applied your patches with minor tweaks.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2020-05-18 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 15:52 [bug#41365] [PATCH 0/5] Add superstarfighter Timotej Lazar
2020-05-17 15:55 ` [bug#41365] [PATCH 1/5] gnu: godot: Enable release build Timotej Lazar
2020-05-17 15:55 ` [bug#41365] [PATCH 2/5] gnu: godot: Remove obsolete workaround for aarch64 Timotej Lazar
2020-05-17 15:55 ` [bug#41365] [PATCH 3/5] gnu: godot: Build and install the headless version Timotej Lazar
2020-05-17 15:55 ` [bug#41365] [PATCH 4/5] gnu: godot: Install provided .desktop file and icons Timotej Lazar
2020-05-17 15:55 ` [bug#41365] [PATCH 5/5] gnu: Add superstarfighter Timotej Lazar
2020-05-17 15:55 ` [bug#41365] [PATCH 0/5] " Nicolò Balzarotti
2020-05-17 16:03 ` Timotej Lazar
2020-05-18 18:53 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rnhula8.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=41365-done@debbugs.gnu.org \
--cc=timotej.lazar@araneo.si \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).