* [bug#42205] [PATCH] discovery: Fix typo.
@ 2020-07-04 22:16 Arun Isaac
2020-07-05 8:00 ` Mathieu Othacehe
0 siblings, 1 reply; 3+ messages in thread
From: Arun Isaac @ 2020-07-04 22:16 UTC (permalink / raw)
To: 42205; +Cc: Arun Isaac
* guix/discovery.scm (fold-module-public-variables*): In the docstring,
replace (PROC MODULE SYMBOL VARIABLE) with (PROC MODULE SYMBOL VARIABLE
RESULT).
---
guix/discovery.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/guix/discovery.scm b/guix/discovery.scm
index 7c5fed7f0e..b84b9ff370 100644
--- a/guix/discovery.scm
+++ b/guix/discovery.scm
@@ -153,9 +153,9 @@ SUB-DIRECTORY. Modules are listed in the order they appear on the path."
(reverse (fold-modules cons '() path #:warn warn)))
(define (fold-module-public-variables* proc init modules)
- "Call (PROC MODULE SYMBOL VARIABLE) for each variable exported by one of MODULES,
-using INIT as the initial value of RESULT. It is guaranteed to never traverse
-the same object twice."
+ "Call (PROC MODULE SYMBOL VARIABLE RESULT) for each variable exported by one
+of MODULES, using INIT as the initial value of RESULT. It is guaranteed to
+never traverse the same object twice."
;; Here SEEN is populated by variables; if two different variables refer to
;; the same object, we still let them through.
(identity ;discard second return value
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#42205] [PATCH] discovery: Fix typo.
2020-07-04 22:16 [bug#42205] [PATCH] discovery: Fix typo Arun Isaac
@ 2020-07-05 8:00 ` Mathieu Othacehe
2020-07-05 10:40 ` bug#42205: " Arun Isaac
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Othacehe @ 2020-07-05 8:00 UTC (permalink / raw)
To: Arun Isaac; +Cc: 42205
Hey,
> (define (fold-module-public-variables* proc init modules)
> - "Call (PROC MODULE SYMBOL VARIABLE) for each variable exported by one of MODULES,
> -using INIT as the initial value of RESULT. It is guaranteed to never traverse
> -the same object twice."
> + "Call (PROC MODULE SYMBOL VARIABLE RESULT) for each variable exported by one
> +of MODULES, using INIT as the initial value of RESULT. It is guaranteed to
> +never traverse the same object twice."
> ;; Here SEEN is populated by variables; if two different variables refer to
> ;; the same object, we still let them through.
> (identity ;discard second return value
This looks fine. Do not hesitate to proceed without reviewing for those
typo fixing patches :).
Thanks for your patch,
Mathieu
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#42205: [PATCH] discovery: Fix typo.
2020-07-05 8:00 ` Mathieu Othacehe
@ 2020-07-05 10:40 ` Arun Isaac
0 siblings, 0 replies; 3+ messages in thread
From: Arun Isaac @ 2020-07-05 10:40 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 42205-done
[-- Attachment #1: Type: text/plain, Size: 136 bytes --]
> This looks fine. Do not hesitate to proceed without reviewing for those
> typo fixing patches :).
Ok, thanks! :-) Pushed to master.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-05 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-04 22:16 [bug#42205] [PATCH] discovery: Fix typo Arun Isaac
2020-07-05 8:00 ` Mathieu Othacehe
2020-07-05 10:40 ` bug#42205: " Arun Isaac
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).