unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: 44718@debbugs.gnu.org
Subject: [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio
Date: Wed, 18 Nov 2020 09:00:34 +0300	[thread overview]
Message-ID: <871rgrkxvh.fsf@gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 339 bytes --]

Hello,

According to Git bisect, the 977eb5d0 commit breaks docker-service-type
with the following error during “guix system build” or “guix system
reconfigure”:

    guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service


The following patch fixes this.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Fix docker-service-type file-system-/sys/fs/cgroup/blkio --]
[-- Type: text/x-patch, Size: 1174 bytes --]

From dcc259c3a33a470eee761f4deadf9149f0a65c55 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Wed, 18 Nov 2020 08:57:05 +0300
Subject: [PATCH] Fix file-system->shepherd-service-name.

This commit follow 977eb5d023cfdf8e336f1896480eea9cef5c04e9, which breaks
docker-service-type with error:

guix system: error: service 'dockerd' requires
'file-system-/sys/fs/cgroup/blkio', which is not provided by any service

* gnu/services/base.scm (file-system->shepherd-service-name): Add '/' to
valid characters.
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 712b3a018f..6fc966e268 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -288,7 +288,7 @@ FILE-SYSTEM."
   (define valid-characters
     ;; Valid store characters; see 'checkStoreName' in the daemon.
     (string->char-set
-     "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?="))
+     "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?=/"))
 
   (define mount-point
     (string-map (lambda (chr)
-- 
2.29.2


[-- Attachment #1.3: Type: text/plain, Size: 8 bytes --]



Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

             reply	other threads:[~2020-11-18  6:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18  6:00 Oleg Pykhalov [this message]
2020-11-18 16:26 ` [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio Danny Milosavljevic
2020-11-18 21:26   ` Marius Bakke
2020-11-19  0:26     ` Danny Milosavljevic
2020-11-20  5:11     ` Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rgrkxvh.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=44718@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).