[-- Attachment #1.1: Type: text/plain, Size: 339 bytes --] Hello, According to Git bisect, the 977eb5d0 commit breaks docker-service-type with the following error during “guix system build” or “guix system reconfigure”: guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service The following patch fixes this. [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1.2: Fix docker-service-type file-system-/sys/fs/cgroup/blkio --] [-- Type: text/x-patch, Size: 1174 bytes --] From dcc259c3a33a470eee761f4deadf9149f0a65c55 Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov <go.wigust@gmail.com> Date: Wed, 18 Nov 2020 08:57:05 +0300 Subject: [PATCH] Fix file-system->shepherd-service-name. This commit follow 977eb5d023cfdf8e336f1896480eea9cef5c04e9, which breaks docker-service-type with error: guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service * gnu/services/base.scm (file-system->shepherd-service-name): Add '/' to valid characters. --- gnu/services/base.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 712b3a018f..6fc966e268 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -288,7 +288,7 @@ FILE-SYSTEM." (define valid-characters ;; Valid store characters; see 'checkStoreName' in the daemon. (string->char-set - "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?=")) + "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?=/")) (define mount-point (string-map (lambda (chr) -- 2.29.2 [-- Attachment #1.3: Type: text/plain, Size: 8 bytes --] Oleg. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 861 bytes --]
[-- Attachment #1: Type: text/plain, Size: 496 bytes --] Hi, On Wed, 18 Nov 2020 09:00:34 +0300 Oleg Pykhalov <go.wigust@gmail.com> wrote: > According to Git bisect, the 977eb5d0 commit breaks docker-service-type > with the following error during “guix system build” or “guix system > reconfigure”: > > guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service I can confirm this bug. However, I cannot say one way or another where the patch is the right fix. [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 663 bytes --] Danny Milosavljevic <dannym@scratchpost.org> skriver: > Hi, > > On Wed, 18 Nov 2020 09:00:34 +0300 > Oleg Pykhalov <go.wigust@gmail.com> wrote: > >> According to Git bisect, the 977eb5d0 commit breaks docker-service-type >> with the following error during “guix system build” or “guix system >> reconfigure”: >> >> guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service > > I can confirm this bug. > > However, I cannot say one way or another where the patch is the right fix. I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459, can you confirm? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 507 bytes --]
[-- Attachment #1: Type: text/plain, Size: 211 bytes --] Hi, On Wed, 18 Nov 2020 22:26:38 +0100 Marius Bakke <marius@gnu.org> wrote: > I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459, > can you confirm? Yes, it is indeed fixed for me. [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 170 bytes --] Marius Bakke <marius@gnu.org> writes: […] > I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459, > can you confirm? Yes, closing the issue. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 861 bytes --]