unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "VÖRÖSKŐI András" <voroskoi@gmail.com>
Cc: 67231@debbugs.gnu.org
Subject: [bug#67231] [PATCH] gnu: aerc: Fix notmuch support.
Date: Mon, 11 Dec 2023 23:38:22 +0100	[thread overview]
Message-ID: <871qbs2wm9.fsf@gnu.org> (raw)
In-Reply-To: <a10d0bdf6cc5e390ead227e0efdb7bcb4ffcb3e5.1700156042.git.voroskoi@gmail.com> ("VÖRÖSKŐI András"'s message of "Thu, 16 Nov 2023 18:34:02 +0100")

Hi,

VÖRÖSKŐI András <voroskoi@gmail.com> skribis:

> * gnu/packages/mail.scm (aerc)[inputs]: Add notmuch, remove go modules and zoxide.
> * gnu/packages/mail.scm (aerc)[native-inputs] Add go modules and zoxide.
>
> Change-Id: I697cee112bcc37f87681ee16de6ffc3f7b13ec3d
> ---
>
> For notmuch support notmuch.h has to be included build time, so added to inputs.
> Zoxide moved to native-inputs as it is an optional depencency, aerc works fine
> without it.
>
> I am not sure about the go modules, but I think they also sould be just native-inputs
> as we only need those at build time.

Zoxide is definitely present at run-time, as can be seen when running
‘guix size aerc’.  So I think it should remain in ‘inputs’.

As for the Go modules, my inclination is that they should be in ‘inputs’
as well because surely the resulting binaries must be linked against
them, even if statically?

IOW, I guess I’d just add ‘notmuch’ to ‘inputs’ and not make the other
changes.  If that’s fine with you, could you send an updated patch?

Thanks,
Ludo’.




      reply	other threads:[~2023-12-11 22:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 17:34 [bug#67231] [PATCH] gnu: aerc: Fix notmuch support VÖRÖSKŐI András
2023-12-11 22:38 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qbs2wm9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=67231@debbugs.gnu.org \
    --cc=voroskoi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).