From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aO5IC4qPd2WIvwAAkFu2QA (envelope-from ) for ; Mon, 11 Dec 2023 23:39:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id EGjgBoqPd2XnPgEA62LTzQ (envelope-from ) for ; Mon, 11 Dec 2023 23:39:06 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fdV1NGf3; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702334345; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GICoB2fdl999Lu4RN9iG3bIXw4KXplVg5jxdvubeiKE=; b=WWLQRFcE7fzLF4ABkunN/rHw2PjwTqCRnt4wXQJqMl6wK2TXuazp3aGbuHF8YfaV4sYiuP aS+188nWJjE9B6ujlbtBBX1owHgm/e4T/2PWF5gkwJxcyWertGpdfWumAQrdlVN5Wwt9EP rXWEaAWbctU3ym0e+yMwytzkaSLoyXaIxEBwJ3zkzAqtLE/Jazq0oXNB/DST3l41OSXctO MjuIqR04Slokwl80c/6I3JFVdQi9lXbY6itxfCoMa1uc3vM7FMiZTUhDW4tvwcpNjv4NQc 4U8NlmvafJgXwFcdH5V54xJQMAwhKOR+dRHSqNvmBLLmSk8JikhtJSfNALZpIQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702334345; a=rsa-sha256; cv=none; b=cizKoLwcS5iUDRmTngstxE7nFFpkqyg6bpNZKbfCsljPme6DKKjmGiTiA3LjsApYPEpg5n 4/rxBbZZQhwh2N9Mx4wCeiDe5NNJUouK4F4Yh4FcFTjawqAtvfCjSH0BeK2Q8ZVG7Z0+QZ +TS55sO9SL0IgZLkVEedaA/QtpUXiHn2AmRr86+JoBLgA+SPBwpkWGX9BrVYhFzX1o7Tkf 28nHDq6PJxbU9z0uk5HkWNz26MnuZHT+V9oZUQ3eUUjxeOXLCtuio4kuhnvVmcCTAR1Tv7 Y/AmqxvmWsHL0tY6AEOpT3n8hv7m1vVUd3cjl3AF6gpWMc0kpFpQulElFNhuoQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fdV1NGf3; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D00ED3BF74 for ; Mon, 11 Dec 2023 23:39:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCovR-00067D-CZ; Mon, 11 Dec 2023 17:38:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCovH-00066V-S6 for guix-patches@gnu.org; Mon, 11 Dec 2023 17:38:48 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCovH-0005XR-Ht for guix-patches@gnu.org; Mon, 11 Dec 2023 17:38:47 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCovW-0007ie-F8 for guix-patches@gnu.org; Mon, 11 Dec 2023 17:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67231] [PATCH] gnu: aerc: Fix notmuch support. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Dec 2023 22:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67231 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?V=C3=96R=C3=96SK=C5=90I_?= =?UTF-8?Q?Andr=C3=A1s?= Cc: 67231@debbugs.gnu.org Received: via spool by 67231-submit@debbugs.gnu.org id=B67231.170233432929651 (code B ref 67231); Mon, 11 Dec 2023 22:39:02 +0000 Received: (at 67231) by debbugs.gnu.org; 11 Dec 2023 22:38:49 +0000 Received: from localhost ([127.0.0.1]:54896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCovJ-0007iA-8C for submit@debbugs.gnu.org; Mon, 11 Dec 2023 17:38:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCovG-0007hx-4t for 67231@debbugs.gnu.org; Mon, 11 Dec 2023 17:38:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCouv-0005UH-1w; Mon, 11 Dec 2023 17:38:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=GICoB2fdl999Lu4RN9iG3bIXw4KXplVg5jxdvubeiKE=; b=fdV1NGf3Ti20bl95mHPu im1+xIfqf5vpa8iNMnEK/JUXhdIm46dY5uKJTbfVyWYOq4Gy824wcyflrVhfNcKZ4B+hKORV2pnI0 SnipU0X3rBWbwVrBEXP2dRuS1zzuvojeiBQQqQWzj54zSE1BIDbBO9T75iE6y7zh7EDAZTSG2B7ey 19olsonrHefa/dgE1mknysxqbgmEVBCVvoE1HaGC7o5fLS/AyY1e6pAeB8napnjKSeUG9w52gpR83 ce5PlSjloApQh96I2gwjl9EsJwj9lccNe7kYx83v2P4UqI23AIwIv0aQkgEyBRJ/Gmu3e6sYXRIL1 rB9wH69KysXekg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: ("=?UTF-8?Q?V=C3=96R=C3=96SK=C5=90I_?= =?UTF-8?Q?Andr=C3=A1s?="'s message of "Thu, 16 Nov 2023 18:34:02 +0100") References: Date: Mon, 11 Dec 2023 23:38:22 +0100 Message-ID: <871qbs2wm9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.11 X-Spam-Score: -2.11 X-Migadu-Queue-Id: D00ED3BF74 X-Migadu-Scanner: mx11.migadu.com X-TUID: xaHyaG2Vy2lM Hi, V=C3=96R=C3=96SK=C5=90I Andr=C3=A1s skribis: > * gnu/packages/mail.scm (aerc)[inputs]: Add notmuch, remove go modules an= d zoxide. > * gnu/packages/mail.scm (aerc)[native-inputs] Add go modules and zoxide. > > Change-Id: I697cee112bcc37f87681ee16de6ffc3f7b13ec3d > --- > > For notmuch support notmuch.h has to be included build time, so added to = inputs. > Zoxide moved to native-inputs as it is an optional depencency, aerc works= fine > without it. > > I am not sure about the go modules, but I think they also sould be just n= ative-inputs > as we only need those at build time. Zoxide is definitely present at run-time, as can be seen when running =E2=80=98guix size aerc=E2=80=99. So I think it should remain in =E2=80=98= inputs=E2=80=99. As for the Go modules, my inclination is that they should be in =E2=80=98in= puts=E2=80=99 as well because surely the resulting binaries must be linked against them, even if statically? IOW, I guess I=E2=80=99d just add =E2=80=98notmuch=E2=80=99 to =E2=80=98inp= uts=E2=80=99 and not make the other changes. If that=E2=80=99s fine with you, could you send an updated patch? Thanks, Ludo=E2=80=99.