* [bug#54360] [PATCH] services: thermald: Add 'adaptive?' field.
@ 2022-03-12 22:12 Jelle Licht
2022-03-18 9:43 ` Mathieu Othacehe
0 siblings, 1 reply; 4+ messages in thread
From: Jelle Licht @ 2022-03-12 22:12 UTC (permalink / raw)
To: 54360
* gnu/services/pm.scm (<thermald-configuration>): Add 'adaptive?' field.
(thermald-shepherd-service): Use it to pass --adaptive to thermald.
* doc/guix.texi (Power Management Services): Document the 'adaptive?' field of
'thermald-configuration'.
---
doc/guix.texi | 4 ++++
gnu/services/pm.scm | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/doc/guix.texi b/doc/guix.texi
index 4b71fb7010..82dce87eed 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -30687,6 +30687,10 @@ Power Management Services
Data type representing the configuration of @code{thermald-service-type}.
@table @asis
+@item @code{adaptive?} (default: @code{#f})
+Use @acronym{DPTF, Dynamic Power and Thermal Framework} adaptive tables
+when present.
+
@item @code{ignore-cpuid-check?} (default: @code{#f})
Ignore cpuid check for supported CPU models.
diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm
index 3da3c0b961..e48236dbca 100644
--- a/gnu/services/pm.scm
+++ b/gnu/services/pm.scm
@@ -435,6 +435,8 @@ (define (generate-tlp-documentation)
(define-record-type* <thermald-configuration>
thermald-configuration make-thermald-configuration
thermald-configuration?
+ (adaptive? thermald-adaptive? ;boolean
+ (default #f))
(ignore-cpuid-check? thermald-ignore-cpuid-check? ;boolean
(default #f))
(thermald thermald-thermald ;file-like
@@ -448,6 +450,9 @@ (define (thermald-shepherd-service config)
(start #~(make-forkexec-constructor
'(#$(file-append (thermald-thermald config) "/sbin/thermald")
"--no-daemon"
+ #$@(if (thermald-adaptive? config)
+ '("--adaptive")
+ '())
#$@(if (thermald-ignore-cpuid-check? config)
'("--ignore-cpuid-check")
'()))))
base-commit: 504d15a593faf06ed502057406a20b3601e12759
--
2.34.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#54360] [PATCH] services: thermald: Add 'adaptive?' field.
2022-03-12 22:12 [bug#54360] [PATCH] services: thermald: Add 'adaptive?' field Jelle Licht
@ 2022-03-18 9:43 ` Mathieu Othacehe
2022-03-20 15:45 ` bug#54360: " Jelle Licht
2022-03-20 15:52 ` [bug#54360] " Jelle Licht
0 siblings, 2 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2022-03-18 9:43 UTC (permalink / raw)
To: Jelle Licht; +Cc: 54360
Hello Jelle,
> * gnu/services/pm.scm (<thermald-configuration>): Add 'adaptive?' field.
> (thermald-shepherd-service): Use it to pass --adaptive to thermald.
> * doc/guix.texi (Power Management Services): Document the 'adaptive?' field of
> 'thermald-configuration'.
Looks fine, please go ahead.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#54360: [PATCH] services: thermald: Add 'adaptive?' field.
2022-03-18 9:43 ` Mathieu Othacehe
@ 2022-03-20 15:45 ` Jelle Licht
2022-03-20 15:52 ` [bug#54360] " Jelle Licht
1 sibling, 0 replies; 4+ messages in thread
From: Jelle Licht @ 2022-03-20 15:45 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 54360-done
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hello Jelle,
>
>> * gnu/services/pm.scm (<thermald-configuration>): Add 'adaptive?' field.
>> (thermald-shepherd-service): Use it to pass --adaptive to thermald.
>> * doc/guix.texi (Power Management Services): Document the 'adaptive?' field of
>> 'thermald-configuration'.
>
> Looks fine, please go ahead.
>
> Thanks,
>
> Mathieu
pushed as 10d865aa92 to master,
- Jelle
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#54360] [PATCH] services: thermald: Add 'adaptive?' field.
2022-03-18 9:43 ` Mathieu Othacehe
2022-03-20 15:45 ` bug#54360: " Jelle Licht
@ 2022-03-20 15:52 ` Jelle Licht
1 sibling, 0 replies; 4+ messages in thread
From: Jelle Licht @ 2022-03-20 15:52 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 54360-done
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hello Jelle,
>
>> * gnu/services/pm.scm (<thermald-configuration>): Add 'adaptive?' field.
>> (thermald-shepherd-service): Use it to pass --adaptive to thermald.
>> * doc/guix.texi (Power Management Services): Document the 'adaptive?' field of
>> 'thermald-configuration'.
>
> Looks fine, please go ahead.
>
> Thanks,
>
> Mathieu
pushed as 10d865aa92 to master,
- Jelle
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-20 15:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-12 22:12 [bug#54360] [PATCH] services: thermald: Add 'adaptive?' field Jelle Licht
2022-03-18 9:43 ` Mathieu Othacehe
2022-03-20 15:45 ` bug#54360: " Jelle Licht
2022-03-20 15:52 ` [bug#54360] " Jelle Licht
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).