unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sarah Morgensen <iskarian@mgsn.dev>
To: Maxime Devos <maximedevos@telenet.be>
Cc: Julien Lepiller <julien@lepiller.eu>, jgart <jgart@dismail.de>,
	50274@debbugs.gnu.org
Subject: [bug#50274] [PATCH] guix: git: Adds feature to download git repository to the store.
Date: Thu, 02 Sep 2021 18:37:10 -0700	[thread overview]
Message-ID: <86tuj2xwvt.fsf@mgsn.dev> (raw)
In-Reply-To: Maxime Devos's message of "Wed, 01 Sep 2021 00:28:37 +0200 (2 days, 3 hours, 4 minutes ago)"

Hi Maxime,

Maxime Devos <maximedevos@telenet.be> writes:

> Sarah Morgensen schreef op di 31-08-2021 om 11:50 [-0700]:
>> 
>> Your patch has a number of tabs in it; they should be converted to spaces.
>
> Is this documented somewhere?  I'm not aware of such a rule.

I cannot find it explicitly stated anywhere, but etc/indent-code.el does
replace tabs with spaces:

--8<---------------cut here---------------start------------->8---
     ;; Indent all of FILE-NAME.
     (find-file file-name)
     (let ((indent-tabs-mode nil))
       (untabify (point-min) (point-max))
       (indent-region (point-min) (point-max))
       (save-buffer)
       (message "Done!")))
--8<---------------cut here---------------end--------------->8---

So I assumed it's policy.  Perhaps the documentation should explicitly
note that spaces are Official Policy?

--
Sarah




  parent reply	other threads:[~2021-09-03  1:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 16:39 [bug#50274] [PATCH] guix: git: Adds feature to download git repository to the store jgart via Guix-patches via
2021-08-31 18:50 ` Sarah Morgensen
2021-08-31 22:28   ` Maxime Devos
2021-08-31 19:08 ` Sarah Morgensen
2021-08-31 19:30   ` jgart via Guix-patches via
2021-08-31 20:06     ` jgart via Guix-patches via
2021-09-03  1:37 ` Sarah Morgensen [this message]
2021-09-24 12:25 ` Ludovic Courtès
2021-09-26  6:24   ` Sarah Morgensen
2021-09-30 20:03     ` Ludovic Courtès
2023-08-01  1:21 ` TakeV via Guix-patches via
2023-08-18 17:55   ` Simon Tournier
2023-08-18 21:02     ` TakeV via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tuj2xwvt.fsf@mgsn.dev \
    --to=iskarian@mgsn.dev \
    --cc=50274@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=julien@lepiller.eu \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).