From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kIFaCoh8MWHOaQEAgWs5BA (envelope-from ) for ; Fri, 03 Sep 2021 03:38:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8I9/BYh8MWFOQwAAbx9fmQ (envelope-from ) for ; Fri, 03 Sep 2021 01:38:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F71412666 for ; Fri, 3 Sep 2021 03:38:15 +0200 (CEST) Received: from localhost ([::1]:51366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLy9m-0003XZ-FD for larch@yhetil.org; Thu, 02 Sep 2021 21:38:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLy9a-0003XR-48 for guix-patches@gnu.org; Thu, 02 Sep 2021 21:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59103) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLy9Z-0000Be-T2 for guix-patches@gnu.org; Thu, 02 Sep 2021 21:38:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLy9Z-000838-Qa for guix-patches@gnu.org; Thu, 02 Sep 2021 21:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50274] [PATCH] guix: git: Adds feature to download git repository to the store. References: <20210830163918.19419-1-jgart@dismail.de> Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Sep 2021 01:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50274 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Julien Lepiller , jgart , 50274@debbugs.gnu.org Received: via spool by 50274-submit@debbugs.gnu.org id=B50274.163063303830896 (code B ref 50274); Fri, 03 Sep 2021 01:38:01 +0000 Received: (at 50274) by debbugs.gnu.org; 3 Sep 2021 01:37:18 +0000 Received: from localhost ([127.0.0.1]:42416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLy8r-00082F-Q8 for submit@debbugs.gnu.org; Thu, 02 Sep 2021 21:37:17 -0400 Received: from out2.migadu.com ([188.165.223.204]:33506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLy8n-000821-TW for 50274@debbugs.gnu.org; Thu, 02 Sep 2021 21:37:15 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630633032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=PuxQdsfS1y2/tTAtuollVVxUYbSacLuLCQ9fdpuX6Q0=; b=JgYqNceqlP0D69psS4oO8IiS9/UzaFwp4CxQqWghUHPoi3R84qnhCjZ92QyGXRcCdQrVDV RBiP5267kqzfdjPMI4kAF/f44AYazcOJQf3Pf2xfrhXakx4AfRGe2FWcwZ743cdPkpKmez Tk3wdhb4EQSLJNGw+GAFbelCjklxZWw= From: Sarah Morgensen Date: Thu, 02 Sep 2021 18:37:10 -0700 In-Reply-To: Maxime Devos's message of "Wed, 01 Sep 2021 00:28:37 +0200 (2 days, 3 hours, 4 minutes ago)" Message-ID: <86tuj2xwvt.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630633096; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=PuxQdsfS1y2/tTAtuollVVxUYbSacLuLCQ9fdpuX6Q0=; b=o6yKm5VCA62+VKlBzsh/ZLP+/+pr2LJNZv+yY9TmLjPRPPna3LYGv5qL1bU3xhnyfxYKqA Wc0R8Y9t+5JwdkFGZu/IaTf2HjTxdWAehC70M3PUQlF2LbyYeNB7yVj4tcNg7vadCSEfGE wqFwo6hfIEDljS5fwSHoSkc1JmZeXBrYo+GhHmhrsupcWHe/7Ej34DghTyxSlaFDtYdzV6 bX96Hii+dwZsX3c5z4nIVeOdBkFn2WXS8YdBciHv+8y8ztqMxydB3iJcliXv4JgBXttXge r/aeDc0EkzcmAG10BGBh7+E3G18NMqP83KiYe0MYWj70jJx5OsPrVa3Lc3KtSg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630633096; a=rsa-sha256; cv=none; b=JQTXxnNDT1J3N6W7ww8qnazcK626IYOuEj6z6QJBVAVLCU1M1U5Z5I4lA5rFD5dJ15mTPF uP/nZyqw503CuqoU+IBSDwr79jlKuO0QwKaw4bdve2AB+8DaXKvB0oMQT5HcET5wosRiFO eaAODp47ZR7wf5xykTJkzcTIzw9iXZKnDJt1kKQkNuZPN0JaOyCGv7rJ8B/ngO8NMR6q7e skgiKBUJYxU2oMTFSdBeFaEt9FC5MXM8g7rVlKlDHQYSdDq/FgTLNmhT63iQj8XJkxMwuo Sih2goaTWazTidmuY80bjg9AUUzOEbDS4mwYP+XykF8Cj59KC6+rURbMN5TYRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=JgYqNceq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=JgYqNceq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5F71412666 X-Spam-Score: 0.18 X-Migadu-Scanner: scn1.migadu.com X-TUID: GdLwPuSJh3T0 Hi Maxime, Maxime Devos writes: > Sarah Morgensen schreef op di 31-08-2021 om 11:50 [-0700]: >> >> Your patch has a number of tabs in it; they should be converted to spaces. > > Is this documented somewhere? I'm not aware of such a rule. I cannot find it explicitly stated anywhere, but etc/indent-code.el does replace tabs with spaces: --8<---------------cut here---------------start------------->8--- ;; Indent all of FILE-NAME. (find-file file-name) (let ((indent-tabs-mode nil)) (untabify (point-min) (point-max)) (indent-region (point-min) (point-max)) (save-buffer) (message "Done!"))) --8<---------------cut here---------------end--------------->8--- So I assumed it's policy. Perhaps the documentation should explicitly note that spaces are Official Policy? -- Sarah