From: zimoun <zimon.toutoune@gmail.com>
To: Magali Lemes <magalilemes00@gmail.com>
Cc: 43994@debbugs.gnu.org
Subject: [bug#43994] [PATCH] gnu: Add r-calculus.
Date: Thu, 15 Oct 2020 13:09:06 +0200 [thread overview]
Message-ID: <86sgaf21bh.fsf@gmail.com> (raw)
In-Reply-To: <20201014190609.80701-1-magalilemes00@gmail.com> (Magali Lemes's message of "Wed, 14 Oct 2020 16:06:09 -0300")
Hi,
Thank you for your contribution. It is fine. For the sake of the
learning process, I suggest some minor tweaks and then you can send a v2
patch. Does it make sense?
In the commit message, it is missing:
* gnu/packages/cran.scm (r-calculus): New variable.
> ---
> gnu/packages/cran.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index 59a409f8e9..8a4f0085f6 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -24596,3 +24596,30 @@ enrichment analysis (GSEA) calculation with or without the absolute filtering.
> Without filtering, users can perform (original) two-tailed or one-tailed
> absolute GSEA.")
> (license license:gpl2)))
> +
> +(define-public r-calculus
> + (package
> + (name "r-calculus")
> + (version "0.2.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (cran-uri "calculus" version))
> + (sha256
> + (base32
Here, and issue of indentation.
(uri (cran-uri "calculus" version))
(sha256
(base32
Usually, with Emacs (with the correct setup “.dir-locals.el“), the
simplest is to go to the first opening parenthesis and press ‘C-M-q’.
> + "0hs7hzjl6xjza20v9zx9a1piywxa6w3h2rskr52d1dcbc0vwhinp"))))
> + (properties `((upstream-name . "calculus")))
> + (build-system r-build-system)
> + (propagated-inputs `(("r-rcpp" ,r-rcpp)))
Usually, it is preferred to list below:
(propagated-inputs
`(("r-rcpp" ,r-rcpp)))
> + (home-page "https://github.com/emanuele-guidotti/calculus")
> + (synopsis "High Dimensional Numerical and Symbolic Calculus")
> + (description
> + "Efficient C++ optimized functions for numerical and symbolic calculus.
> +It includes basic symbolic arithmetic, tensor calculus, Einstein summing
> +convention, fast computation of the Levi-Civita symbol and generalized
End of line: extra whitespace
> +Kronecker delta, Taylor series expansion, multivariate Hermite polynomials,
> +accurate high-order derivatives, differential operators (Gradient, Jacobian,
> +Hessian, Divergence, Curl, Laplacian) and numerical integration in arbitrary
> +orthogonal coordinate systems: cartesian, polar, spherical, cylindrical,
Idem
Again with Emacs, I personally have ’(whitespace-mode)’ with this
config and then it is really easy to spot out.
--8<---------------cut here---------------start------------->8---
(with-eval-after-load 'whitespace
(setq whitespace-line-column nil
whitespace-style '(face trailing lines-tail
space-before-tab newline
indentation empty space-after-tab)))
--8<---------------cut here---------------end--------------->8---
> +parabolic or user defined by custom scale factors.")
> + (license license:gpl3)))
> \ No newline at end of file
Add RET. I guess.
Well, now you should do an “interactive rebase” and resend. Using Emacs
(again!) and Magit , it looks like:
r i
edit C-c C-c
# do your tweaks
r r
W c C-m b master C-m v 2 c
! git send-email --to=43994@debbugs.gnu.org v2-0001-blabla.patch
Does it make sense?
All the best,
simon
PS:
You can use any tools you want. :-) Sorry for the Emacs’s
evangelism. ;-)
next prev parent reply other threads:[~2020-10-15 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 19:06 [bug#43994] [PATCH] gnu: Add r-calculus Magali Lemes
2020-10-15 11:09 ` zimoun [this message]
2020-10-16 18:51 ` [bug#43994] [PATCH v2] " Magali Lemes
2020-10-17 20:39 ` bug#43994: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sgaf21bh.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=43994@debbugs.gnu.org \
--cc=magalilemes00@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).