From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kCyDCxIuiF/YDAAA0tVLHw (envelope-from ) for ; Thu, 15 Oct 2020 11:10:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6B94BxIuiF9SEQAAbx9fmQ (envelope-from ) for ; Thu, 15 Oct 2020 11:10:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C57CD940224 for ; Thu, 15 Oct 2020 11:10:09 +0000 (UTC) Received: from localhost ([::1]:42714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT196-0001Gj-On for larch@yhetil.org; Thu, 15 Oct 2020 07:10:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT190-0001GH-0v for guix-patches@gnu.org; Thu, 15 Oct 2020 07:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kT18z-0005do-MH for guix-patches@gnu.org; Thu, 15 Oct 2020 07:10:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kT18z-0000D9-IL for guix-patches@gnu.org; Thu, 15 Oct 2020 07:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43994] [PATCH] gnu: Add r-calculus. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Oct 2020 11:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43994 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Magali Lemes Cc: 43994@debbugs.gnu.org Received: via spool by 43994-submit@debbugs.gnu.org id=B43994.1602760157713 (code B ref 43994); Thu, 15 Oct 2020 11:10:01 +0000 Received: (at 43994) by debbugs.gnu.org; 15 Oct 2020 11:09:17 +0000 Received: from localhost ([127.0.0.1]:54549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT18H-0000BR-0m for submit@debbugs.gnu.org; Thu, 15 Oct 2020 07:09:17 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT18F-0000BF-24 for 43994@debbugs.gnu.org; Thu, 15 Oct 2020 07:09:15 -0400 Received: by mail-wr1-f66.google.com with SMTP id x7so2956378wrl.3 for <43994@debbugs.gnu.org>; Thu, 15 Oct 2020 04:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+HWhA3nKmYW34ybEYw6Vzg6rz5YsuXTUP2XxvNJjL/k=; b=d0VbzGUDkApOAJ/WDb6sVMWslnbqK6OSeOcvXAD+tHuAbUKyq9QIcsevExRcgGbdON /zhovITgSX8CYXyiOmMU/YRXghLcYLLetsW9q2GGB5hWoMz6BySCeHCsLasBm5+ge9nb Mtl8GC8sSR/eXM6bw5ZSLzcVtK1aTXMba1AJzFhetbYIqEX2YcgrSHwXBoMfhTfWUzjR 8dbtI5DOlapfP4tEIN9js+sDcBT8JXidm4rD2K9B/OO7kfU2q248g7WRkJUiQGQxPI8l F1mXrnSN6dbFC51k3r7Ht8wIH0oW8PaUIjj7dWFf2ciR5GQK3zANNFRkT7lKJS0cW56t 3AZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+HWhA3nKmYW34ybEYw6Vzg6rz5YsuXTUP2XxvNJjL/k=; b=WZgfZtrZ6LJ8uqz4+ln5hLQdSfEzZDmpUsxAP1et24N1DgBHp+uE6UlxR1Dsiyxaix FmTThjmcvnmonHlLLVinmyXya7NFvc/STK2Gstga6vEM75YhnWbT6bQ5uopP3LRhuh2w e3eylwLRyufWyWjfqZPUzdxB+e0+9wLeLwVOIwBT//havb1v+ZPV1lVMCQawhv9xG6yN MD1fosCHw9EIWwjld6S/vJ4jPVbWITLG85wzr8gzdegLtekRVQhIyjiESVOlfD9uNmXc juJ438hClvs1NYRNgqlkY4Jh3ljpURhfGbK7F/sLJYTYUDKRIuQRekDzXpdDOyhNAoNx aQdQ== X-Gm-Message-State: AOAM531e+roVZsAnPbB5c3cRDXh0jV+tw8rjoxLPPCyQ5S49hbAyTRnJ kiyDcQuvAuc+MNCxgG7B7tKDPp5bBQo= X-Google-Smtp-Source: ABdhPJx+ci6gUa4e03B+7WgT2mC+bFKUMLZslBiUg64aQGHDSYqhhmFN0J3dBzRVeAMIWsD0pI+elw== X-Received: by 2002:adf:cd82:: with SMTP id q2mr3989163wrj.118.1602760148746; Thu, 15 Oct 2020 04:09:08 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id o63sm3916758wmo.2.2020.10.15.04.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 04:09:08 -0700 (PDT) From: zimoun References: <20201014190609.80701-1-magalilemes00@gmail.com> Date: Thu, 15 Oct 2020 13:09:06 +0200 In-Reply-To: <20201014190609.80701-1-magalilemes00@gmail.com> (Magali Lemes's message of "Wed, 14 Oct 2020 16:06:09 -0300") Message-ID: <86sgaf21bh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=d0VbzGUD; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: m55Me8Jccixa Hi, Thank you for your contribution. It is fine. For the sake of the learning process, I suggest some minor tweaks and then you can send a v2 patch. Does it make sense? In the commit message, it is missing: * gnu/packages/cran.scm (r-calculus): New variable. > --- > gnu/packages/cran.scm | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm > index 59a409f8e9..8a4f0085f6 100644 > --- a/gnu/packages/cran.scm > +++ b/gnu/packages/cran.scm > @@ -24596,3 +24596,30 @@ enrichment analysis (GSEA) calculation with or w= ithout the absolute filtering. > Without filtering, users can perform (original) two-tailed or one-tail= ed > absolute GSEA.") > (license license:gpl2))) > + > +(define-public r-calculus > + (package > + (name "r-calculus") > + (version "0.2.1") > + (source > + (origin > + (method url-fetch) > + (uri (cran-uri "calculus" version)) > + (sha256 > + (base32 Here, and issue of indentation. (uri (cran-uri "calculus" version)) (sha256 (base32 Usually, with Emacs (with the correct setup =E2=80=9C.dir-locals.el=E2=80= =9C), the simplest is to go to the first opening parenthesis and press =E2=80=98C-M-q= =E2=80=99. > + "0hs7hzjl6xjza20v9zx9a1piywxa6w3h2rskr52d1dcbc0vwhinp")))) > + (properties `((upstream-name . "calculus"))) > + (build-system r-build-system) > + (propagated-inputs `(("r-rcpp" ,r-rcpp))) Usually, it is preferred to list below: (propagated-inputs `(("r-rcpp" ,r-rcpp))) > + (home-page "https://github.com/emanuele-guidotti/calculus") > + (synopsis "High Dimensional Numerical and Symbolic Calculus") > + (description > + "Efficient C++ optimized functions for numerical and symbolic calcu= lus. > +It includes basic symbolic arithmetic, tensor calculus, Einstein summing > +convention, fast computation of the Levi-Civita symbol and generalized=20 End of line: extra whitespace=20 > +Kronecker delta, Taylor series expansion, multivariate Hermite polynomia= ls, > +accurate high-order derivatives, differential operators (Gradient, Jacob= ian, > +Hessian, Divergence, Curl, Laplacian) and numerical integration in arbit= rary > +orthogonal coordinate systems: cartesian, polar, spherical, cylindrical,= =20 Idem Again with Emacs, I personally have =E2=80=99(whitespace-mode)=E2=80=99 wit= h this config and then it is really easy to spot out. --8<---------------cut here---------------start------------->8--- (with-eval-after-load 'whitespace (setq whitespace-line-column nil whitespace-style '(face trailing lines-tail space-before-tab newline indentation empty space-after-tab))) --8<---------------cut here---------------end--------------->8--- > +parabolic or user defined by custom scale factors.") > + (license license:gpl3))) > \ No newline at end of file Add RET. I guess. Well, now you should do an =E2=80=9Cinteractive rebase=E2=80=9D and resend.= Using Emacs (again!) and Magit , it looks like: r i edit C-c C-c # do your tweaks r r W c C-m b master C-m v 2 c ! git send-email --to=3D43994@debbugs.gnu.org v2-0001-blabla.patch Does it make sense? All the best, simon PS: You can use any tools you want. :-) Sorry for the Emacs=E2=80=99s evangelism. ;-)