From: pukkamustard <pukkamustard@posteo.net>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 57298@debbugs.gnu.org
Subject: [bug#57298] [PATCH 3/5] gnu: Add ocaml-crowbar.
Date: Mon, 22 Aug 2022 09:45:37 +0000 [thread overview]
Message-ID: <86r1184neo.fsf@posteo.net> (raw)
In-Reply-To: <20220820140506.61879f57@sybil.lepiller.eu>
Julien Lepiller <julien@lepiller.eu> writes:
> Le Fri, 19 Aug 2022 15:24:30 +0000,
> pukkamustard <pukkamustard@posteo.net> a écrit :
>
>> + (build-system dune-build-system)
>> + (arguments
>> + ;; Tests require ocaml-xmldiff which requires OCaml 4.12.0
>> + `(#:tests? #f))
>
> That doesn't seem to be the case, at least from opam, the constraint is
> ocaml >= 4.12. We have 4.14. Could you try adding xmldiff and enabling
> tests?
Again, this seems to have been an artifact of porting the package
definitions from an old patch series. Sorry for the sloppyness.
ocaml-crowbar no longer has tests that rely on xmldiff. I've enabled the
tests and it just works.
A general note on another OCaml dependency: ocaml-calendar seems to be
unmaintained
(https://discuss.ocaml.org/t/calendarlib-looking-for-a-new-maintainer/3965)
and some fixes are included in an unreleased Git branch
(https://github.com/ocaml-community/calendar/tree/3.x). No action
required from Guix side at the moment, just worth keeping in mind.
Thanks for your review! Will send in V2 shortly.
-pukkamustard
>
>> + (propagated-inputs
>> + (list ocaml-ocplib-endian
>> + ocaml-cmdliner
>> + ocaml-afl-persistent))
>> + (native-inputs
>> + (list ocaml-calendar
>> + ocaml-fpath
>> + ocaml-uucp
>> + ocaml-uunf
>> + ocaml-uutf
>> + ocaml-pprint))
>> + (synopsis "Ocaml library for tests, let a fuzzer find failing
>> cases")
>> + (description "Crowbar is a library for testing code, combining
>> +QuickCheck-style property-based testing and the magical bug-finding
>> powers of +@uref{http://lcamtuf.coredump.cx/afl/, afl-fuzz}.")
>> + (license license:expat)))
>> +
>> (define-public ocaml-bibtex2html
>> (package
>> (name "ocaml-bibtex2html")
next prev parent reply other threads:[~2022-08-22 9:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 15:21 [bug#57298] [PATCH 0/5] gnu: Add ocaml-digestif. (and dependencies) pukkamustard
2022-08-19 15:24 ` [bug#57298] [PATCH 1/5] gnu: Add ocaml-afl-persistent pukkamustard
2022-08-19 15:24 ` [bug#57298] [PATCH 2/5] gnu: Add ocaml-pprint pukkamustard
2022-08-20 12:03 ` Julien Lepiller
2022-08-22 9:43 ` pukkamustard
2022-08-19 15:24 ` [bug#57298] [PATCH 3/5] gnu: Add ocaml-crowbar pukkamustard
2022-08-20 12:05 ` Julien Lepiller
2022-08-22 9:45 ` pukkamustard [this message]
2022-08-19 15:24 ` [bug#57298] [PATCH 4/5] gnu: Add ocaml-eqaf pukkamustard
2022-08-19 15:24 ` [bug#57298] [PATCH 5/5] gnu: Add ocaml-digestif pukkamustard
2022-08-22 9:54 ` [bug#57298] [PATCH v2 1/5] gnu: Add ocaml-afl-persistent pukkamustard
2022-08-22 9:54 ` [bug#57298] [PATCH v2 2/5] gnu: Add ocaml-pprint pukkamustard
2022-08-22 9:54 ` [bug#57298] [PATCH v2 3/5] gnu: Add ocaml-crowbar pukkamustard
2022-08-22 9:54 ` [bug#57298] [PATCH v2 4/5] gnu: Add ocaml-eqaf pukkamustard
2022-08-22 9:54 ` [bug#57298] [PATCH v2 5/5] gnu: Add ocaml-digestif pukkamustard
2022-08-24 16:25 ` bug#57298: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r1184neo.fsf@posteo.net \
--to=pukkamustard@posteo.net \
--cc=57298@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).