From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SKALKs9RA2P8JQAAbAwnHQ (envelope-from ) for ; Mon, 22 Aug 2022 11:52:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GJAPKs9RA2Og0QAA9RJhRA (envelope-from ) for ; Mon, 22 Aug 2022 11:52:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D5C193FB for ; Mon, 22 Aug 2022 11:52:15 +0200 (CEST) Received: from localhost ([::1]:42714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQ46Q-0007B1-99 for larch@yhetil.org; Mon, 22 Aug 2022 05:52:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ46E-0007AV-Lx for guix-patches@gnu.org; Mon, 22 Aug 2022 05:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQ46E-00074n-DP for guix-patches@gnu.org; Mon, 22 Aug 2022 05:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQ46E-0005yr-4R for guix-patches@gnu.org; Mon, 22 Aug 2022 05:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57298] [PATCH 3/5] gnu: Add ocaml-crowbar. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Aug 2022 09:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57298 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 57298@debbugs.gnu.org Received: via spool by 57298-submit@debbugs.gnu.org id=B57298.166116186522922 (code B ref 57298); Mon, 22 Aug 2022 09:52:02 +0000 Received: (at 57298) by debbugs.gnu.org; 22 Aug 2022 09:51:05 +0000 Received: from localhost ([127.0.0.1]:37904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ45J-0005xe-1I for submit@debbugs.gnu.org; Mon, 22 Aug 2022 05:51:05 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ45G-0005x9-Td for 57298@debbugs.gnu.org; Mon, 22 Aug 2022 05:51:04 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EE5AD240029 for <57298@debbugs.gnu.org>; Mon, 22 Aug 2022 11:50:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661161857; bh=9fAj6mSer4ukKSCx1SJHbe+K1wlNo/3hRNFm3A+L/yU=; h=From:To:Cc:Subject:Date:From; b=UMC3DXOS5JQ8StiU34X8WMnHAwKErR9OomUtbXaxfge/jTDdXqA1nS2uZMqUfZPuL M5Nm74MeQ6Cg3tPstaTuMqLzsWRQFHf++2OqYwk8vNfcUD4HFvFy8k7ieIWMYFdO4/ cmsNxRksC1YeRvbxLzy9I/x2EKuugeiqVfWNdo4BGScrRczwd/1RlShzxsQSzRmE23 MDvBthti9prjsOJ0yqlxIEYijnZlx5usmh8JW78mfQ53OaR5maQldd5TqzKG2TnBhn DxZGL8ISfoITOSVrripk/hQCZtP3dw8yb8emfgdWb0vk2Lr0SX5+QVVLIfrVcJVQgl owNENPbgpTVOQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MB70J0nwpz9rxH; Mon, 22 Aug 2022 11:50:55 +0200 (CEST) References: <20220819152149.25881-1-pukkamustard@posteo.net> <20220819152432.26135-1-pukkamustard@posteo.net> <20220819152432.26135-3-pukkamustard@posteo.net> <20220820140506.61879f57@sybil.lepiller.eu> From: pukkamustard Date: Mon, 22 Aug 2022 09:45:37 +0000 In-reply-to: <20220820140506.61879f57@sybil.lepiller.eu> Message-ID: <86r1184neo.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661161935; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Tv/liaI4ok2eLX5hc0BGb1UrfH7Rg9HpZfcFARjUCH8=; b=F9HJqionlajC9Dn0rgv2gF7WiRMTkC+OlB1N77JO2j4GvgQuYGt00xyoOKixkWnXKzKgZP 0uoQKjSltmK/V3bgQHNjq4r8aYQ4WdYQpNp0KPUIdeeINFY98V/Gbjd2e+0K8Es87t/9Iv 2cOsMz7ZQtJ5DPYGeU4Frh7kuS9QGSVFGCdqo1gQSd48eVtvPuCEXNTmsmi8i291QrcgLQ bewaim2bpDquKCsXYR4uVjA8X+NwHohZ9sbzarb4P+SSHI1JPEzP6WG9Rq3/At056bqc6O Dywshz7IaYr90FbycFx9PeGBfUHk5zmXYJHsBDs41232pVx2xyfacLassJ4uTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661161935; a=rsa-sha256; cv=none; b=oPJcwkv7ybImhqu1ZGt3uerWAq+0Fjc6t6tdY1yl/Txrqjt5d8CslGbfW8/VdjoOPm4qrf cr8yLpEKsb2JYH9HLmtl6Ri9Q3xUMZKZpbd5k2Gxn6ffmcUKs+wqB1L/2XnlL6kn6JdxbI iCFHo/QBp7V6nyfS8EseyB0enTnOWP/vuwdLT3NYI8X9zilwTbpQ3ACruAnyKHCbbrGcx9 nDIUQAQllbLHkO6WvbXvHvBheBUlSu1JAHjYVACbCmOm7FPzp4X3pVHFz2x+uhNtSf4igN UeHtK/gOfdRk/oOXLB/YPmkxSLN7BzZsDbRoZ7RJAAY5HaNwea0gQxp2vJFOqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=UMC3DXOS; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.98 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=UMC3DXOS; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4D5C193FB X-Spam-Score: 6.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: kb9Glg0YHdxr Julien Lepiller writes: > Le Fri, 19 Aug 2022 15:24:30 +0000, > pukkamustard a =C3=A9crit : > >> + (build-system dune-build-system) >> + (arguments >> + ;; Tests require ocaml-xmldiff which requires OCaml 4.12.0 >> + `(#:tests? #f)) > > That doesn't seem to be the case, at least from opam, the constraint is > ocaml >=3D 4.12. We have 4.14. Could you try adding xmldiff and enabling > tests? Again, this seems to have been an artifact of porting the package definitions from an old patch series. Sorry for the sloppyness. ocaml-crowbar no longer has tests that rely on xmldiff. I've enabled the tests and it just works. A general note on another OCaml dependency: ocaml-calendar seems to be unmaintained (https://discuss.ocaml.org/t/calendarlib-looking-for-a-new-maintainer/3965) and some fixes are included in an unreleased Git branch (https://github.com/ocaml-community/calendar/tree/3.x). No action required from Guix side at the moment, just worth keeping in mind. Thanks for your review! Will send in V2 shortly. -pukkamustard > >> + (propagated-inputs >> + (list ocaml-ocplib-endian >> + ocaml-cmdliner >> + ocaml-afl-persistent)) >> + (native-inputs >> + (list ocaml-calendar >> + ocaml-fpath >> + ocaml-uucp >> + ocaml-uunf >> + ocaml-uutf >> + ocaml-pprint)) >> + (synopsis "Ocaml library for tests, let a fuzzer find failing >> cases") >> + (description "Crowbar is a library for testing code, combining >> +QuickCheck-style property-based testing and the magical bug-finding >> powers of +@uref{http://lcamtuf.coredump.cx/afl/, afl-fuzz}.") >> + (license license:expat))) >> + >> (define-public ocaml-bibtex2html >> (package >> (name "ocaml-bibtex2html")