From: zimoun <zimon.toutoune@gmail.com>
To: Frank Pursel <frank.pursel@gmail.com>, 60976@debbugs.gnu.org
Subject: [bug#60976] [PATCH] gnu: Add ditaa.
Date: Wed, 25 Jan 2023 11:10:01 +0100 [thread overview]
Message-ID: <86pmb353ie.fsf@gmail.com> (raw)
In-Reply-To: <87wn5bxr7e.fsf@Ginko.mail-host-address-is-not-set>
Hi,
On Tue, 24 Jan 2023 at 18:50, Frank Pursel <frank.pursel@gmail.com> wrote:
> Another reason not to want to split this commit is because, per the
> reference manual, It seemed to me that this was also 'one set of
> related changes' enabling ditaa. java-libbatik and java-jericho-html
> are unlikely to be used in support of anything else but cannot be
> commited separately without breaking ditaa. I also suspect their
> purpose would quickly become unclear if mixed with other java
> packages.
No, there are independent. This package java-jericho-html does not
depend on the others so it deserves its proper commit mentioning its
addition.
--8<---------------cut here---------------start------------->8---
+(define-public java-jericho-html
[...]
+ (native-inputs (list java-junit java-slf4j-api java-log4j-api
+ java-commons-logging-minimal))
--8<---------------cut here---------------end--------------->8---
Then, it is similar for this other one:
--8<---------------cut here---------------start------------->8---
+(define-public java-libbatik
[...]
+ (native-inputs (list rhino java-xmlgraphics-commons libxslt
+ java-jaxen java-junit java-jaxp java-xerces
+ java-jdom quickjs))
--8<---------------cut here---------------end--------------->8---
Therefore, I would expect three commits, like this:
gnu: Add java-jericho-html.
gnu: Add java-libbatik.
gnu: Add ditaa.
> If there were another application that also built upon the concrete
> java-libbatik then I think the argument for moving it into batik.scm
> would be stronger but don't think there is one because batik.scm
> remains more abstract. I think that is ok. 'batik.scm' is java
> internally uses an svg api but ditaa leverages svg to produce other
> than svg output and is independent of java. It is a tool that
> is likely to be used in non-java environments.
Well, I am not convinced by this argument about java-libbatik. :-)
Cheers,
simon
next prev parent reply other threads:[~2023-01-25 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 18:46 [bug#60976] [PATCH] gnu: Add ditaa Frank Pursel
2023-01-24 10:44 ` Simon Tournier
2023-01-25 2:50 ` Frank Pursel
2023-01-25 10:10 ` zimoun [this message]
2023-01-25 17:42 ` Frank Pursel
2023-01-26 12:36 ` Simon Tournier
2023-01-26 16:46 ` [bug#60976] [PATCH 1/3] gnu: Add java-jericho-html Frank Pursel
2023-01-26 16:46 ` [bug#60976] [PATCH v3 1/4] " Frank Pursel
2023-02-26 7:47 ` Julien Lepiller
2023-01-26 16:46 ` [bug#60976] [PATCH v4 1/3] " Frank Pursel
2023-01-26 16:53 ` [bug#60976] [PATCH v4 2/3] gnu: Add java-libbatik Frank Pursel
2023-01-26 17:01 ` [bug#60976] [PATCH v4 3/3] gnu: Add ditaa Frank Pursel
2023-08-28 22:50 ` bug#60976: " Vagrant Cascadian
2023-01-27 13:41 ` [bug#60976] [PATCH 3/3] " Frank Pursel
2023-01-28 4:49 ` [bug#60976] [PATCH] gnu: " Frank Pursel
2023-03-09 0:25 ` Frank Pursel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pmb353ie.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=60976@debbugs.gnu.org \
--cc=frank.pursel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).