From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qBi7EFUA0WOxcQEAbAwnHQ (envelope-from ) for ; Wed, 25 Jan 2023 11:11:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kDnRD1UA0WOkSQEAG6o9tA (envelope-from ) for ; Wed, 25 Jan 2023 11:11:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1137F1730B for ; Wed, 25 Jan 2023 11:11:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKckI-00021g-Rf; Wed, 25 Jan 2023 05:11:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKckB-00020k-Ho for guix-patches@gnu.org; Wed, 25 Jan 2023 05:11:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKckA-0004TA-I5 for guix-patches@gnu.org; Wed, 25 Jan 2023 05:11:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKckA-0005ir-8Z for guix-patches@gnu.org; Wed, 25 Jan 2023 05:11:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60976] [PATCH] gnu: Add ditaa. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 Jan 2023 10:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60976 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Frank Pursel , 60976@debbugs.gnu.org Received: via spool by 60976-submit@debbugs.gnu.org id=B60976.167464142621946 (code B ref 60976); Wed, 25 Jan 2023 10:11:02 +0000 Received: (at 60976) by debbugs.gnu.org; 25 Jan 2023 10:10:26 +0000 Received: from localhost ([127.0.0.1]:58363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKcjZ-0005hp-QZ for submit@debbugs.gnu.org; Wed, 25 Jan 2023 05:10:26 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:36594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKcjX-0005hQ-Fi for 60976@debbugs.gnu.org; Wed, 25 Jan 2023 05:10:23 -0500 Received: by mail-wr1-f50.google.com with SMTP id b7so16513474wrt.3 for <60976@debbugs.gnu.org>; Wed, 25 Jan 2023 02:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=+BEiLjsoj3NqXgIsUzu6CWirHCyk8oJmUp5a5b1Jlyk=; b=dPV5Jk3+YmeAHiBg122qYBVO9yBiLrSEuRXtoK0rPk1RnMAmbkgJlfwFAlRoB925un VJ02+hY+TLVRjpJlOd1XnuTbnnrqllE16Tn39O7mjn0eSZUQU8uCgvCYSbr4UMMuyy2b uKljmUIC1DPFQ2pW5qo3HkIxy28cT6amLK5Vi/GTmqwIAp3sw99xlA1OQC2Dm9WrLD1P KtuDdICQBTuEpNTzc3zI0e6TjfFpyhRnEJEmcBLDk+VhSWk6cYcvpUxG0OrYXOTJquQZ 8/4ZZ5JVAiRjoX2XLU9cOPahsXEBL5/K4iLpMCUTKQvHr8oDM6IvVKWE+n7Raza7Egva jOjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+BEiLjsoj3NqXgIsUzu6CWirHCyk8oJmUp5a5b1Jlyk=; b=5LYyujjt5yt1THCN8Li2b2/7BPeNJhphajv44FeOp85OCA7zcNdfrSPnyHjrWA6Jkm YmTepS9z5G/7TafV1XXw57NwfqFk6HGuoH6fHaFBqut/2XYjJOGnm7wBZKEfEaiFuuvN Vlavsj9whkatz7AUd6yKlr50gDmCj8e94F6+n7lEo7EmlXtGk7cEP98PSXawzWDOmkyK tzcbuYOVjL8yhSlGA+CkEvPOasDMKL0eaDwJGUPd/GMimXgNNVW+kA7TJitBfox2TN7a H/3F7jFMHNvQrWhgY/eJ8BdnRSAlOI7wAJnoZTZOejhXEHPsAvg1J7ux8lNsBRXPYYoP jOjg== X-Gm-Message-State: AFqh2kpG42UaiUFdzBScnBxj9uPOqEFxFAEt7vYQpwFQHYjr73qzIMSd 9Fkh74qVyXuiTKG70ho68jnjiSRllTc= X-Google-Smtp-Source: AMrXdXsgRoQ65LBjYP43rAhOZwkullUfxjtMCFni+rVGxcMcFW3HjLYwHPZxyP+euefbg2tLQGIbZA== X-Received: by 2002:adf:ed0c:0:b0:2bd:ec92:d979 with SMTP id a12-20020adfed0c000000b002bdec92d979mr5414616wro.2.1674641417908; Wed, 25 Jan 2023 02:10:17 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id w14-20020a5d608e000000b002bc84c55758sm4844052wrt.63.2023.01.25.02.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 02:10:17 -0800 (PST) From: zimoun In-Reply-To: <87wn5bxr7e.fsf@Ginko.mail-host-address-is-not-set> References: <63cb23b3.650a0220.26d15.f66d@mx.google.com> <87wn5bxr7e.fsf@Ginko.mail-host-address-is-not-set> Date: Wed, 25 Jan 2023 11:10:01 +0100 Message-ID: <86pmb353ie.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674641493; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+BEiLjsoj3NqXgIsUzu6CWirHCyk8oJmUp5a5b1Jlyk=; b=BfaQwqgfj4xS1ETJv0aI8XYDKqFv+/ZGuyRrTOhTkbwul+KAXunEMt2RVbJPJLxM0+E3gz jbabZ+A0jC0MgTpCBkKe0+HP8YIApG2CygU5ZorRVf9Ffn9n7ecIi6ym5v6+t/4SPfPubw vf0FytoE6jPU+Iopp+9pJOagXcgO2EV7jkoWR5PGCpsj6Tk/1J9T8v2HRCJiuwj7DSuQS2 olTC4Ur/bMHjUXpsEWPmupBuspdnYFMITWuX6EAq2Z1HcpwloSQmWIv4+/qhQMNrrbG6dc Ld7nCqGjoTmkLFziSDR7R8DnxE1fYHYzoL2RRNCKwKbuxW2hBuT93JcH3Sx2Zg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dPV5Jk3+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674641493; a=rsa-sha256; cv=none; b=gbbhFdj0w76R8Xvcc5GOj13vXSayCPuJX5lf4J+yu08aPWbayqmkLhdmOEDzQCQColHDt/ HUtca+GMFaLbL8bH5ek1xl8rR8cH1iLLEs6gSQsrKrgDmEv8WOy9GX7QUWwlJ1nJN0JaTk Rn4+02N6c0UGFLogkgj3JiE86drvLup53vRW5ExFUX0bCHvmPs1O2x7NoPZnuGokI9VzG5 lNKPoKu344+6zS4YamkwqLR0wsRn0hjCU27kscg+mRrVgosoK4kNI+zeoS5Hx7BK+Rn+P/ xIArgY+B06ohWAjacdsn2sBvjO7WbsW2+bCgWxyocjdBaP/sJgkMT5Z5lbHZHA== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dPV5Jk3+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: 5.93 X-Spam-Score: 5.93 X-Migadu-Queue-Id: 1137F1730B X-TUID: 1SVzcbrhoQdj Hi, On Tue, 24 Jan 2023 at 18:50, Frank Pursel wrote: > Another reason not to want to split this commit is because, per the > reference manual, It seemed to me that this was also 'one set of > related changes' enabling ditaa. java-libbatik and java-jericho-html > are unlikely to be used in support of anything else but cannot be > commited separately without breaking ditaa. I also suspect their > purpose would quickly become unclear if mixed with other java > packages. No, there are independent. This package java-jericho-html does not depend on the others so it deserves its proper commit mentioning its addition. --8<---------------cut here---------------start------------->8--- +(define-public java-jericho-html [...] + (native-inputs (list java-junit java-slf4j-api java-log4j-api + java-commons-logging-minimal)) --8<---------------cut here---------------end--------------->8--- Then, it is similar for this other one: --8<---------------cut here---------------start------------->8--- +(define-public java-libbatik [...] + (native-inputs (list rhino java-xmlgraphics-commons libxslt + java-jaxen java-junit java-jaxp java-xerces + java-jdom quickjs)) --8<---------------cut here---------------end--------------->8--- Therefore, I would expect three commits, like this: gnu: Add java-jericho-html. gnu: Add java-libbatik. gnu: Add ditaa. > If there were another application that also built upon the concrete > java-libbatik then I think the argument for moving it into batik.scm > would be stronger but don't think there is one because batik.scm > remains more abstract. I think that is ok. 'batik.scm' is java > internally uses an svg api but ditaa leverages svg to produce other > than svg output and is independent of java. It is a tool that > is likely to be used in non-java environments. Well, I am not convinced by this argument about java-libbatik. :-) Cheers, simon