From: Sarah Morgensen <iskarian@mgsn.dev>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 49780@debbugs.gnu.org
Subject: [bug#49780] [PATCH 00/14] import: Use PARSE-COMMAND-LINE for options.
Date: Tue, 03 Aug 2021 11:54:49 -0700 [thread overview]
Message-ID: <86bl6e4ava.fsf_-_@mgsn.dev> (raw)
In-Reply-To: <87czquttrx.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 03 Aug 2021 17:47:14 +0200")
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Sarah,
>
> Sarah Morgensen <iskarian@mgsn.dev> skribis:
>
>> I noticed that we have an ARGS-FOLD* wrapper called PARSE-COMMAND-LINE which has
>> the same invalid argument message as the importers, the same argument handler,
>> and has an option hint feature. So let's use that in the importers.
>>
>> The change is identical across all importers, and the semantics as far as return
>> value are identical, so this should just be a drop-in.
>
> Neat, that’s a welcome change. I hope you won’t hate me for suggesting
> this, but I think such systematic API evolution changes can go in a
> single commit. WDYT?
Ha! No problem. v2 sent.
>
> Nitpick:
>
> guix/scripts/import/go.scm (guix-import-go)[parse-options]: Use
> ^
> You need a ‘*’ at the beginning of the line.
Of course I missed that. Fixed in v2. If only etc/committer didn't choke
on it because git-diff decided that literal strings are function
definitions... Looking at it now, git 2.32+ has a built-in function regex
for Scheme, so if we add
*.scm diff=scheme
to a .gitattributes file, we should get better diff headers. Quick
testing shows that if we have nested functions, it shows the innermost
one, though. A little modification to the regex can make it show the
topmost one. This is what we want for etc/committer, but is it what we
want elsewhere? I'll send a patch shortly.
>
> Thanks!
>
> Ludo’.
--
Sarah
next prev parent reply other threads:[~2021-08-03 18:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 3:51 [bug#49780] [PATCH 00/14] import: Use PARSE-COMMAND-LINE for options Sarah Morgensen
2021-07-30 3:54 ` [bug#49780] [PATCH 01/14] import: go: " Sarah Morgensen
2021-07-30 3:54 ` [bug#49780] [PATCH 02/14] import: egg: " Sarah Morgensen
2021-07-30 3:54 ` [bug#49780] [PATCH 03/14] import: gem: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 04/14] import: gnu: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 05/14] import: cpan: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 06/14] import: cran: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 07/14] import: elpa: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 08/14] import: json: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 09/14] import: opam: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 10/14] import: pypi: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 11/14] import: crate: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 12/14] import: texlive: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 13/14] import: hackage: " Sarah Morgensen
2021-07-30 3:55 ` [bug#49780] [PATCH 14/14] import: stackage: " Sarah Morgensen
2021-08-03 15:47 ` [bug#49780] [PATCH 00/14] import: " Ludovic Courtès
2021-08-03 18:54 ` Sarah Morgensen [this message]
2021-08-31 8:24 ` zimoun
2021-08-03 18:24 ` [bug#49780] [PATCH v2] " Sarah Morgensen
2021-08-04 15:01 ` bug#49780: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bl6e4ava.fsf_-_@mgsn.dev \
--to=iskarian@mgsn.dev \
--cc=49780@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).