From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QI1oOAqRCWEv0AAAgWs5BA (envelope-from ) for ; Tue, 03 Aug 2021 20:55:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MJsPNAqRCWH1XAAAB5/wlQ (envelope-from ) for ; Tue, 03 Aug 2021 18:55:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D5D71C7A for ; Tue, 3 Aug 2021 20:55:06 +0200 (CEST) Received: from localhost ([::1]:49874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAzZB-00015N-MW for larch@yhetil.org; Tue, 03 Aug 2021 14:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAzZ7-000150-Ri for guix-patches@gnu.org; Tue, 03 Aug 2021 14:55:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58196) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAzZ7-0006nJ-LN for guix-patches@gnu.org; Tue, 03 Aug 2021 14:55:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mAzZ7-0002x9-K3 for guix-patches@gnu.org; Tue, 03 Aug 2021 14:55:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49780] [PATCH 00/14] import: Use PARSE-COMMAND-LINE for options. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Aug 2021 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49780 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49780@debbugs.gnu.org Received: via spool by 49780-submit@debbugs.gnu.org id=B49780.162801689611337 (code B ref 49780); Tue, 03 Aug 2021 18:55:01 +0000 Received: (at 49780) by debbugs.gnu.org; 3 Aug 2021 18:54:56 +0000 Received: from localhost ([127.0.0.1]:41509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAzZ1-0002wm-Of for submit@debbugs.gnu.org; Tue, 03 Aug 2021 14:54:56 -0400 Received: from out0.migadu.com ([94.23.1.103]:56752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAzYy-0002we-IJ for 49780@debbugs.gnu.org; Tue, 03 Aug 2021 14:54:53 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1628016891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkP2uQnKDb/TElbq7hp2rno/zjkJudJkcQjt1wtU1ZE=; b=KvQl+LJtXCs9atoylsXz/mPvuH+29fB03XyLbsSVXQV0/CAl1GBI5rf6Z1fZehKrg+AtyU jS9u2ggtaDbqvcAP0YYxgCKvLYBSemYp/3uFURLj+oul4Kq9nujvvlLFp/7jHR4PeuTwQ0 M8yD2CK4GwNiIsNC5cqpe1hyn/aGjAU= From: Sarah Morgensen References: <87czquttrx.fsf@gnu.org> Date: Tue, 03 Aug 2021 11:54:49 -0700 In-Reply-To: <87czquttrx.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 03 Aug 2021 17:47:14 +0200") Message-ID: <86bl6e4ava.fsf_-_@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628016906; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qkP2uQnKDb/TElbq7hp2rno/zjkJudJkcQjt1wtU1ZE=; b=f8sch6hoOu+UTkWgZUCIz9ijAMuFaUZ4Z6ah2iBZI9xuAzygqJjc53EnqeUCFpdA/ngsKR 0Cn80Nh+DhGi4odXpQH6YvZNJXyERqlS98QOLtirTXJkyiL0rmbO/bMxZjikztiIYfO377 DcvDyiStmCU+yuLyIGtBYpr13TP6LZBJvP3NRdifwvEwVFwaN64mP/CZk7ndvPsgj6Joi0 YQOxOQshdeU8b7bNRychYW6m6QrH2xsK/9TGqFF2LQEsYv2Z7cZ6VYqDw4XHNsZs/vJZz2 98TWnFgOen+eLaW4KIXy3iOEu3A+1bNmkLNYt1FFKKpYzECzhtuVqWRTDBm8/Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628016906; a=rsa-sha256; cv=none; b=oqPx07Ei+R38AEMNuYdATXzIvF09srpCB6e9vc3b1InsZfpG2TzBk/OZJHWn1ZUQ4J/IO+ 1BViNeJI7JUsQtDUM9894tUH2ji89NAMdJWZORVcALcJPVFl/eKDuciFHenbL9cuYScTPv 4iGKL9kcbdbVLkQnet+u2DY3VKKJtCIrXog7f5NOqaRSU5Xvz/iAqA4BzlOx08V2J9jjW2 NhfR3hY/ypNWJfFXDniQ2TFKXHtB9vtm34bGw10K76uoaYWvNxTM9kIb8CVnfyyzsCo5WS jXcWSlSWb7Qohm5DVLK+xy5cD87BqoAm+qQuU+pv/IoyY+SakEWuREfgHoNqRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=KvQl+LJt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=KvQl+LJt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9D5D71C7A X-Spam-Score: -1.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: SvwHSDMzqqj7 Hi, Ludovic Court=C3=A8s writes: > Hi Sarah, > > Sarah Morgensen skribis: > >> I noticed that we have an ARGS-FOLD* wrapper called PARSE-COMMAND-LINE w= hich has >> the same invalid argument message as the importers, the same argument ha= ndler, >> and has an option hint feature. So let's use that in the importers. >> >> The change is identical across all importers, and the semantics as far a= s return >> value are identical, so this should just be a drop-in. > > Neat, that=E2=80=99s a welcome change. I hope you won=E2=80=99t hate me = for suggesting > this, but I think such systematic API evolution changes can go in a > single commit. WDYT? Ha! No problem. v2 sent. > > Nitpick: > > guix/scripts/import/go.scm (guix-import-go)[parse-options]: Use > ^ > You need a =E2=80=98*=E2=80=99 at the beginning of the line. Of course I missed that. Fixed in v2. If only etc/committer didn't choke on it because git-diff decided that literal strings are function definitions... Looking at it now, git 2.32+ has a built-in function regex for Scheme, so if we add *.scm diff=3Dscheme to a .gitattributes file, we should get better diff headers. Quick testing shows that if we have nested functions, it shows the innermost one, though. A little modification to the regex can make it show the topmost one. This is what we want for etc/committer, but is it what we want elsewhere? I'll send a patch shortly. > > Thanks! > > Ludo=E2=80=99. -- Sarah