unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: pukkamustard <pukkamustard@posteo.net>
To: Benjamin <benjamin@uvy.fr>
Cc: Julien Lepiller <julien@lepiller.eu>, 64209@debbugs.gnu.org
Subject: [bug#64209] [PATCH v2 00/14] Reorder commits and better descriptions
Date: Sat, 14 Oct 2023 09:37:56 +0000	[thread overview]
Message-ID: <86bkd17coq.fsf@posteo.net> (raw)
In-Reply-To: <cover.1691500834.git.benjamin@uvy.fr>


Hi,

Thanks for the update. I haven't been able to check it thoroughly yet.

Unfortunately the synopsis/descriptions still need a bit of polish. For
example (non-exhaustive):

- ocaml-pp: The synopsis should indicate that it is an OCaml
  library. For markup (in this case hyerplinks) you must use the Texinfo
  markup (see https://guix.gnu.org/manual/en/guix.html#Synopses-and-Descriptions).
- ocamlformat-rpc-lib: Final sentence is missing a punctuation.
- ocaml-ppx-yojson-conv-lib: See ocaml-ppx-fields-conv for an example of
  a better description/synopsis.
- ocaml-dyn: Missing punctiation mark.
- ocaml-stdune: Not sure about the description.
- ocaml-xdg: Description should be more than just a link.

Also maybe we first re-solve #63947 (https://issues.guix.gnu.org/63947;
friendly ping to Julien) instead of re-fixining it in this series.

Cheers,
pukkamustard




  parent reply	other threads:[~2023-10-14  9:54 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 15:45 [bug#64209] [PATCH 00/14] Add ocaml-lsp-server and its dependencies Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 01/14] gnu: Fix ocaml-dune-build-info Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 02/14] gnu: Add ocaml-dune-rpc Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 03/14] gnu: Add ocaml-chrome-trace Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 04/14] gnu: Add ocaml-dyn Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 05/14] gnu: Add ocaml-stdune Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 06/14] gnu: Add ocaml-fiber Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 07/14] gnu: Add ocaml-xdg Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 08/14] gnu: Add ocaml-ordering Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 09/14] gnu: Add ocamlc-loc Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 10/14] gnu: Add ocamlformat-rpc-lib Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 11/14] gnu: Add ocaml-pp Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 12/14] gnu: Add ocaml-ppx-yojson-conv-lib Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 13/14] gnu: Add ocaml-merlin-lib-4.9 Benjamin
2023-06-21 15:48 ` [bug#64209] [PATCH 14/14] gnu: Add ocaml-lsp-server Benjamin
2023-07-18 11:52 ` [bug#64209] [PATCH 00/14] Add ocaml-lsp-server and its dependencies Ludovic Courtès
2023-08-06 20:25 ` pukkamustard
2023-08-08 13:22 ` [bug#64209] [PATCH v2 00/14] Reorder commits and better descriptions Benjamin
2023-08-08 13:22   ` [bug#64209] [PATCH v2 01/14] gnu: Fix ocaml-dune-build-info Benjamin
2023-08-08 13:22   ` [bug#64209] [PATCH v2 02/14] gnu: Add ocaml-pp Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 03/14] gnu: Add ocamlformat-rpc-lib Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 04/14] gnu: Add ocaml-ppx-yojson-conv-lib Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 05/14] gnu: Add ocaml-ordering Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 06/14] gnu: Add ocaml-dyn Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 07/14] gnu: Add ocaml-stdune Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 08/14] gnu: Add ocaml-chrome-trace Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 09/14] gnu: Add ocaml-xdg Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 10/14] gnu: Add ocamlc-loc Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 11/14] gnu: Add ocaml-fiber Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 12/14] gnu: Add ocaml-dune-rpc Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 13/14] gnu: Add ocaml-merlin-lib-4.9 Benjamin
2023-08-08 13:23   ` [bug#64209] [PATCH v2 14/14] gnu: Add ocaml-lsp-server Benjamin
2023-10-14  9:37   ` pukkamustard [this message]
2023-11-10 15:46 ` [bug#64209] [PATCH v3 00/14] improve synopsies and descriptions Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 01/14] gnu: Fix ocaml-dune-build-info Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 02/14] gnu: Add ocaml-pp Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 03/14] gnu: Add ocamlformat-rpc-lib Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 04/14] gnu: Add ocaml-ppx-yojson-conv-lib Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 05/14] gnu: Add ocaml-ordering Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 06/14] gnu: Add ocaml-dyn Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 07/14] gnu: Add ocaml-stdune Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 08/14] gnu: Add ocaml-chrome-trace Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 09/14] gnu: Add ocaml-xdg Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 10/14] gnu: Add ocamlc-loc Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 11/14] gnu: Add ocaml-fiber Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 12/14] gnu: Add ocaml-dune-rpc Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 13/14] gnu: Add ocaml-merlin-lib-4.9 Benjamin
2023-11-10 15:46   ` [bug#64209] [PATCH v3 14/14] gnu: Add ocaml-lsp-server Benjamin
2024-03-23 23:35 ` [bug#64209] [PATCH v4 00/11] Update with rebase on master Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 01/11] gnu: Fix dune-ordering Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 02/11] gnu: Add ocaml-ppx-yojson-conv-lib Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 03/11] gnu: Fix ocaml-dune-build-info Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 04/11] gnu: Add ocaml-xdg Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 05/11] gnu: Add dune-rpc Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 06/11] gnu: Add ocamlc-loc Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 07/11] gnu: Add ocaml-chrome-trace Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 08/11] gnu: Add ocaml-fiber Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 09/11] gnu: Add ocamlformat-rpc-lib Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 10/11] gnu: ocaml-merlin-lib: Update to 4.14 Benjamin via Guix-patches via
2024-03-23 23:35   ` [bug#64209] [PATCH v4 11/11] gnu: Add ocaml-lsp-server Benjamin via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bkd17coq.fsf@posteo.net \
    --to=pukkamustard@posteo.net \
    --cc=64209@debbugs.gnu.org \
    --cc=benjamin@uvy.fr \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).