From: Leo Prikler <leo.prikler@student.tugraz.at>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 47824@debbugs.gnu.org, efraim@flashner.co.il
Subject: [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ
Date: Wed, 05 May 2021 17:00:05 +0200 [thread overview]
Message-ID: <867322166b5492fe1964df02db2b4d148ade29dd.camel@student.tugraz.at> (raw)
In-Reply-To: <874kfhjmfd.fsf_-_@gnu.org>
Hi Ludo,
Am Mittwoch, den 05.05.2021, 16:16 +0200 schrieb Ludovic Courtès:
> Hi Leo,
>
> On a cursory look, all three patches LGTM.
>
> One nit:
>
> > + "exec "
> > + (assoc-ref inputs "guile-runtime")
> > + "/bin/guile " args)))
>
> [...]
>
> > ("guile" ,guile-3.0)
> > ("pkg-config" ,pkg-config)
> > ("texinfo" ,texinfo)))
> > - (propagated-inputs
> > - `(("guile-sdl2" ,guile3.0-sdl2)))
> > + (inputs
> > + `(("guile-sdl2" ,guile3.0-sdl2)
> > + ("guile-runtime" ,guile-3.0)))
>
> I think it’s best to not play trick with labels, and to always use
> the
> package name as the label (to facilitate migration on the day where
> we
> get rid of labels, who knows…).
>
> A common pattern for the case above is to provide “guile” both as
> native
> input and input, and to write:
>
> (assoc-ref (or native-inputs inputs) "guile")
What I'm doing here is the exact opposite. I don't want the
omnipresent native-input guile to shadow the guile I use as input, so I
assign a "unique" label to the input guile to refer to it. As a neat
side effect, this label allows me to construct GUILE_LOAD_PATH more
easily.
We already have a number of issues related to the "native-input as
input" thing, "which" returning the wrong binary, and so on, and I
didn't want to add another one on top. The code I wrote certainly
looks and feels ugly, but I don't see any other way with what Guix
currently provides. Maybe for the next c-u merge we can do proper
separation of inputs and native-inputs, hopefully using that to clean
up some of our recipes.
Regards,
Leo
next prev parent reply other threads:[~2021-05-05 15:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 11:05 [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Leo Prikler
2021-04-16 11:07 ` [bug#47824] [PATCH 1/3] gnu: guile-sdl2: Update to 0.6.0 Leo Prikler
2021-04-16 11:07 ` [bug#47824] [PATCH 2/3] gnu: guile-chickadee: Update to 0.7.0 Leo Prikler
2021-04-16 11:07 ` [bug#47824] [PATCH 3/3] gnu: tsukundere: Update to 0.3.0 Leo Prikler
2021-04-19 7:56 ` Efraim Flashner
2021-04-19 8:24 ` Leo Prikler
2021-04-19 8:17 ` [bug#47824] [PATCH v2 1/3] gnu: guile-sdl2: Update to 0.6.0 Leo Prikler
2021-04-19 8:17 ` [bug#47824] [PATCH v2 2/3] gnu: guile-chickadee: Update to 0.7.0 Leo Prikler
2021-04-19 8:17 ` [bug#47824] [PATCH v2 3/3] gnu: tsukundere: Update to 0.3.0 Leo Prikler
2021-05-05 14:16 ` [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Ludovic Courtès
2021-05-05 15:00 ` Leo Prikler [this message]
2021-05-06 10:52 ` Ludovic Courtès
2021-05-06 11:03 ` Leo Prikler
2021-05-15 8:35 ` Leo Prikler
2021-05-15 13:45 ` Ludovic Courtès
2021-05-15 14:02 ` Leo Prikler
2021-05-15 18:32 ` [bug#47824] [PATCH] gnu: tsukundere: Update to 0.3.0 Leo Prikler
2021-05-16 20:21 ` Ludovic Courtès
2021-05-16 22:27 ` bug#47824: " Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867322166b5492fe1964df02db2b4d148ade29dd.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=47824@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).