From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cOhQGr+zkmBlnwAAgWs5BA (envelope-from ) for ; Wed, 05 May 2021 17:03:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oFjYFb+zkmAJQgAAbx9fmQ (envelope-from ) for ; Wed, 05 May 2021 15:03:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C20E4A0DB for ; Wed, 5 May 2021 17:03:26 +0200 (CEST) Received: from localhost ([::1]:37568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leJ3d-0002LF-Ta for larch@yhetil.org; Wed, 05 May 2021 11:03:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leJ1N-0001QW-CE for guix-patches@gnu.org; Wed, 05 May 2021 11:01:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leJ1J-0001So-Mm for guix-patches@gnu.org; Wed, 05 May 2021 11:01:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leJ1J-0004oy-Lc for guix-patches@gnu.org; Wed, 05 May 2021 11:01:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 May 2021 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47824 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 47824@debbugs.gnu.org, efraim@flashner.co.il Received: via spool by 47824-submit@debbugs.gnu.org id=B47824.162022683818504 (code B ref 47824); Wed, 05 May 2021 15:01:01 +0000 Received: (at 47824) by debbugs.gnu.org; 5 May 2021 15:00:38 +0000 Received: from localhost ([127.0.0.1]:60801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJ0w-0004oO-5K for submit@debbugs.gnu.org; Wed, 05 May 2021 11:00:38 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:41606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJ0u-0004oH-3W for 47824@debbugs.gnu.org; Wed, 05 May 2021 11:00:37 -0400 Received: from [10.0.0.4] (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Fb0JH5dwXz1LLyL; Wed, 5 May 2021 17:00:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4Fb0JH5dwXz1LLyL DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1620226832; bh=HR0Gh/kUrZ8lo7qvhG5LHFkyO660vQoLjVTcA70uJM8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=fS78LFwL+zDXLMcFQQARm/8z7J5R/THLpzCT/pOGKRCOO4ANzhXKFceeCnxmJTWp3 4ToWgIDHYQGmFQdblZzv2ASXTrrqV2T1gnvGWxqLTta8KsuxLNOD9lGlyiKzzxUbJ9 ZhCuM8IrP79muPdQxqTdEYqCboEuoPfVQN6N0Iao= Message-ID: <867322166b5492fe1964df02db2b4d148ade29dd.camel@student.tugraz.at> From: Leo Prikler Date: Wed, 05 May 2021 17:00:05 +0200 In-Reply-To: <874kfhjmfd.fsf_-_@gnu.org> References: <20210419081744.7247-1-leo.prikler@student.tugraz.at> <20210419081744.7247-3-leo.prikler@student.tugraz.at> <874kfhjmfd.fsf_-_@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620227006; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HR0Gh/kUrZ8lo7qvhG5LHFkyO660vQoLjVTcA70uJM8=; b=P42rLYsM0dOEQ3w4ddV0ZAailAjmAP13GQr3VlI0UeIce4RDQt1WAPj1UXDUdveAUTOzkk FX7ocA7r6wzra7P8g6hEZWuGsd5NUzizb10csICkOnq7YxXAfu6Q9nk9lOIlMbtMgPe2kr uvdfnDEPbm5N3Ed0pUeUG2LA0VK/AW3cyvoKuuEJTNOlkW8B/3Vh6OagfUSu8q2PhR94XS 5TVgE1SMRzmUUY2aow3j5vcF0GDpqctZvL+/c4Wgw+RZakdpbn0WEPBrZie7tQFRf0JMMK dv4/FYVsCHLZJDI0jZLnEXY5zE2/jTBEV0mqneCT15L8t9om+hTZkGFUV0CIZw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620227006; a=rsa-sha256; cv=none; b=bWlYBKytadVbrjaWpi9BcZdfQAqFkqIZ6IvsA0XDLmR5OPaf3d+vGzZlXjOc5mQnnzwnaD LZvja+AK0FHrAuKgNPr7836q+FLemZsg8J0HykyfQeDjyp9NwJgTxuFYao+G5TmFStA8tp V141WUMce2gSPBVCn+Y2NmhTRuw1JLJBvH3E8QPw4Jjx6M9DEODcYjVoW29SbQ5xhWz3y0 8o5hr5AqC5wG0o5Ej13eJMQHZMrjKYZRVRsa2xKNimqZVAtjv+oY2uwSPdy6AAn0UJEDK6 TP+ofibBAVcFBJAoICVKe6pdihqG4nGiBJIObZDieSrglzQp7O+u9TgEqq6lag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=fS78LFwL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=fS78LFwL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C20E4A0DB X-Spam-Score: -1.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: pXZO2jnyQjNT Hi Ludo, Am Mittwoch, den 05.05.2021, 16:16 +0200 schrieb Ludovic Courtès: > Hi Leo, > > On a cursory look, all three patches LGTM. > > One nit: > > > + "exec " > > + (assoc-ref inputs "guile-runtime") > > + "/bin/guile " args))) > > [...] > > > ("guile" ,guile-3.0) > > ("pkg-config" ,pkg-config) > > ("texinfo" ,texinfo))) > > - (propagated-inputs > > - `(("guile-sdl2" ,guile3.0-sdl2))) > > + (inputs > > + `(("guile-sdl2" ,guile3.0-sdl2) > > + ("guile-runtime" ,guile-3.0))) > > I think it’s best to not play trick with labels, and to always use > the > package name as the label (to facilitate migration on the day where > we > get rid of labels, who knows…). > > A common pattern for the case above is to provide “guile” both as > native > input and input, and to write: > > (assoc-ref (or native-inputs inputs) "guile") What I'm doing here is the exact opposite. I don't want the omnipresent native-input guile to shadow the guile I use as input, so I assign a "unique" label to the input guile to refer to it. As a neat side effect, this label allows me to construct GUILE_LOAD_PATH more easily. We already have a number of issues related to the "native-input as input" thing, "which" returning the wrong binary, and so on, and I didn't want to add another one on top. The code I wrote certainly looks and feels ugly, but I don't see any other way with what Guix currently provides. Maybe for the next c-u merge we can do proper separation of inputs and native-inputs, hopefully using that to clean up some of our recipes. Regards, Leo