unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#63922] [PATCH] doc: fix typo in screen-locker-service swaylock example
@ 2023-06-06  9:08 Arvid Krein
  2023-06-06 11:59 ` Arvid Krein
  0 siblings, 1 reply; 4+ messages in thread
From: Arvid Krein @ 2023-06-06  9:08 UTC (permalink / raw)
  To: 63922

Hello Guix,

I think there is a small typo one of the examples for the 
screen-locker-service-type. The second example is for a 
screen-locker-service that uses swaylock but still uses the xlockmore 
executable. I think the following patch would fix that.


Greetings,

Arvid

---
  doc/guix.texi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 8df5cc411c..638ab1ed6e 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -22577,7 +22577,7 @@ X Window
  (service screen-locker-service-type
           (screen-locker-configuration
             (name "swaylock")
-           (program (file-append xlockmore "/bin/xlock"))
+           (program (file-append swaylock "/bin/swaylock"))
             (using-pam? #t)
             (using-setuid? #f)))
  @end lisp

base-commit: e3cd3f03202c48cd8d777f4769b4e31fea8dcd60
--
2.40.1






^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#63922] [PATCH] doc: fix typo in screen-locker-service swaylock example
  2023-06-06  9:08 [bug#63922] [PATCH] doc: fix typo in screen-locker-service swaylock example Arvid Krein
@ 2023-06-06 11:59 ` Arvid Krein
  2023-07-07 10:35   ` pelzflorian (Florian Pelz)
  2023-07-07 19:52   ` Josselin Poiret via Guix-patches via
  0 siblings, 2 replies; 4+ messages in thread
From: Arvid Krein @ 2023-06-06 11:59 UTC (permalink / raw)
  To: 63922; +Cc: Arvid Krein

From: Arvid Krein <arvid@krein.moe>

Greetings,
Arvid

---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 8df5cc411c..638ab1ed6e 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -22577,7 +22577,7 @@ X Window
 (service screen-locker-service-type
          (screen-locker-configuration
            (name "swaylock")
-           (program (file-append xlockmore "/bin/xlock"))
+           (program (file-append swaylock "/bin/swaylock"))
            (using-pam? #t)
            (using-setuid? #f)))
 @end lisp

base-commit: e3cd3f03202c48cd8d777f4769b4e31fea8dcd60
-- 
2.40.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#63922] [PATCH] doc: fix typo in screen-locker-service swaylock example
  2023-06-06 11:59 ` Arvid Krein
@ 2023-07-07 10:35   ` pelzflorian (Florian Pelz)
  2023-07-07 19:52   ` Josselin Poiret via Guix-patches via
  1 sibling, 0 replies; 4+ messages in thread
From: pelzflorian (Florian Pelz) @ 2023-07-07 10:35 UTC (permalink / raw)
  To: Arvid Krein; +Cc: 63922, Arvid Krein

Arvid Krein <arvidkrein@zedat.fu-berlin.de> writes:
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 8df5cc411c..638ab1ed6e 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -22577,7 +22577,7 @@ X Window
>  (service screen-locker-service-type
>           (screen-locker-configuration
>             (name "swaylock")
> -           (program (file-append xlockmore "/bin/xlock"))
> +           (program (file-append swaylock "/bin/swaylock"))
>             (using-pam? #t)
>             (using-setuid? #f)))
>  @end lisp

Thank you Arvid for your patch.  Thing is, it seems what is specified in
`program' actually does not matter, only the `name' field matters when
using-pam? is true.  I’m not going to work on this; perhaps someone
using screen lockers will decide what needs repairing.

Regards,
Florian





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#63922] [PATCH] doc: fix typo in screen-locker-service swaylock example
  2023-06-06 11:59 ` Arvid Krein
  2023-07-07 10:35   ` pelzflorian (Florian Pelz)
@ 2023-07-07 19:52   ` Josselin Poiret via Guix-patches via
  1 sibling, 0 replies; 4+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2023-07-07 19:52 UTC (permalink / raw)
  To: Arvid Krein, 63922; +Cc: Arvid Krein

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi Arvid,

Arvid Krein <arvidkrein@zedat.fu-berlin.de> writes:

> From: Arvid Krein <arvid@krein.moe>
>
> Greetings,
> Arvid
>
> ---
>  doc/guix.texi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Pushed as 5b6e9b2463f94ae41121e379515c756a6eed9b7f, thanks!

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-07 19:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06  9:08 [bug#63922] [PATCH] doc: fix typo in screen-locker-service swaylock example Arvid Krein
2023-06-06 11:59 ` Arvid Krein
2023-07-07 10:35   ` pelzflorian (Florian Pelz)
2023-07-07 19:52   ` Josselin Poiret via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).