unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: 28616@debbugs.gnu.org
Subject: [bug#28616] disable failing bluez test
Date: Wed, 11 Oct 2017 18:23:20 +0200	[thread overview]
Message-ID: <7901620A-A50E-4C3F-86C3-1E135522029B@fastmail.com> (raw)
In-Reply-To: <20171011.181058.1825950437807455612.post@thomasdanckaert.be>

On 11 October 2017 18:10:58 CEST, Thomas Danckaert <post@thomasdanckaert.be> wrote:
>From: Marius Bakke <mbakke@fastmail.com>
>Subject: Re: [bug#28616] disable failing bluez test
>Date: Tue, 10 Oct 2017 23:40:39 +0200
>
>> Thomas Danckaert <post@thomasdanckaert.be> writes:
>> 
>>> From: Marius Bakke <mbakke@fastmail.com>
>>> Subject: Re: [bug#28616] disable failing bluez test
>>> Date: Tue, 03 Oct 2017 23:50:56 +0200
>>>
>>>> I think we should apply the patch regardless (on 'core-updates'),
>with a
>>>> link to the upstream discussion.  IMO it's more important to be
>able to
>>>> build from source regardless of hardware, than running this one
>unit
>>>> test.  What do you think?
>>>
>>> I agree.
>>>
>>> I'll push this to core-updates then.
>> 
>> On second thought, "bluez" is currently failing on armhf, seemingly
>due
>> to the original patch:
><https://hydra.gnu.org/build/2304811/nixlog/4/raw>
>
>I believe attached patch does the job for master, just touching armhf
>and leaving other architectures alone.  I tested it by replacing
>armhf-linux with x86_64-linux, and then it skips the test ...
>
>WDYT?

Yay! I am unable to test it right now, but if you've verified that this doesn't change the derivation on other architectures this LGTM.

Thank you!

PS: feel free to merge it to core-updates after pushing and modify it to apply on all arches there. If you're not comfortable I can do this later.


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

  reply	other threads:[~2017-10-11 16:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  7:21 [bug#28616] disable failing bluez test Thomas Danckaert
2017-09-27 19:30 ` Marius Bakke
2017-09-27 20:59   ` Thomas Danckaert
2017-09-28  6:42     ` Thomas Danckaert
2017-10-01 10:02       ` Thomas Danckaert
2017-10-03 21:50         ` Marius Bakke
2017-10-04 18:04           ` Thomas Danckaert
2017-10-10 21:40             ` Marius Bakke
2017-10-11  6:52               ` Thomas Danckaert
2017-10-11 16:10               ` Thomas Danckaert
2017-10-11 16:23                 ` Marius Bakke [this message]
2017-10-11 19:53                   ` Thomas Danckaert
2017-10-07 19:53           ` bug#28616: " Thomas Danckaert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7901620A-A50E-4C3F-86C3-1E135522029B@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=28616@debbugs.gnu.org \
    --cc=post@thomasdanckaert.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).