* [bug#58773] [PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on some systems.
@ 2022-10-25 10:49 Christopher Baines
2022-10-25 19:10 ` Liliana Marie Prikler
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Baines @ 2022-10-25 10:49 UTC (permalink / raw)
To: 58773
It seems to frequently fail on i686-linux and aarch64-linux.
* gnu/packages/gstreamer.scm (gst-plugins-bad)[arguments]: Skip the
elements/camerabin test on i686-linux and aarch64-linux.
---
gnu/packages/gstreamer.scm | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a92588a9e2..c211816bf8 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -791,6 +791,14 @@ (define-public gst-plugins-bad
;; FIXME: Why is this failing.
((".*elements/dash_mpd\\.c.*") "")
+ #$@(if (member (%current-system)
+ '("i686-linux" "aarch64-linux"))
+ ;; This test is flaky:
+ ;; https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1244
+ `((("'elements/camerabin\\.c'\\]\\],")
+ "'elements/camerabin.c'], true, ],"))
+ '())
+
;; These tests are flaky and occasionally time out:
;; https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/932
((".*elements/curlhttpsrc\\.c.*") "")
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [bug#58773] [PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on some systems.
2022-10-25 10:49 [bug#58773] [PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on some systems Christopher Baines
@ 2022-10-25 19:10 ` Liliana Marie Prikler
2022-11-26 12:49 ` bug#58773: " Liliana Marie Prikler
0 siblings, 1 reply; 3+ messages in thread
From: Liliana Marie Prikler @ 2022-10-25 19:10 UTC (permalink / raw)
To: Christopher Baines, 58773
Am Dienstag, dem 25.10.2022 um 11:49 +0100 schrieb Christopher Baines:
> It seems to frequently fail on i686-linux and aarch64-linux.
>
> * gnu/packages/gstreamer.scm (gst-plugins-bad)[arguments]: Skip the
> elements/camerabin test on i686-linux and aarch64-linux.
> ---
> gnu/packages/gstreamer.scm | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index a92588a9e2..c211816bf8 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -791,6 +791,14 @@ (define-public gst-plugins-bad
> ;; FIXME: Why is this failing.
> ((".*elements/dash_mpd\\.c.*") "")
>
> + #$@(if (member (%current-system)
> + '("i686-linux" "aarch64-linux"))
> + ;; This test is flaky:
> + ;;
> https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1244
> + `((("'elements/camerabin\\.c'\\]\\],")
> + "'elements/camerabin.c'], true, ],"))
> + '())
> +
> ;; These tests are flaky and occasionally time
> out:
> ;;
> https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/932
You might want to use ", see" instead of the colon and wrap the link in
angular brackets, i.e. <https://...>. Don't forget to end the sentence
with a period.
> ((".*elements/curlhttpsrc\\.c.*") "")
Otherwise LGTM
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#58773: [PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on some systems.
2022-10-25 19:10 ` Liliana Marie Prikler
@ 2022-11-26 12:49 ` Liliana Marie Prikler
0 siblings, 0 replies; 3+ messages in thread
From: Liliana Marie Prikler @ 2022-11-26 12:49 UTC (permalink / raw)
To: Christopher Baines, 58773-done
Am Dienstag, dem 25.10.2022 um 21:10 +0200 schrieb Liliana Marie
Prikler:
> Am Dienstag, dem 25.10.2022 um 11:49 +0100 schrieb Christopher
> Baines:
> > It seems to frequently fail on i686-linux and aarch64-linux.
> >
> > * gnu/packages/gstreamer.scm (gst-plugins-bad)[arguments]: Skip the
> > elements/camerabin test on i686-linux and aarch64-linux.
> > ---
> > gnu/packages/gstreamer.scm | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/gnu/packages/gstreamer.scm
> > b/gnu/packages/gstreamer.scm
> > index a92588a9e2..c211816bf8 100644
> > --- a/gnu/packages/gstreamer.scm
> > +++ b/gnu/packages/gstreamer.scm
> > @@ -791,6 +791,14 @@ (define-public gst-plugins-bad
> > ;; FIXME: Why is this failing.
> > ((".*elements/dash_mpd\\.c.*") "")
> >
> > + #$@(if (member (%current-system)
> > + '("i686-linux" "aarch64-linux"))
> > + ;; This test is flaky:
> > + ;;
> > https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1244
> > + `((("'elements/camerabin\\.c'\\]\\],")
> > + "'elements/camerabin.c'], true, ],"))
> > + '())
> > +
> > ;; These tests are flaky and occasionally time
> > out:
> > ;;
> > https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/932
> You might want to use ", see" instead of the colon and wrap the link
> in angular brackets, i.e. <https://...>. Don't forget to end the
> sentence with a period.
>
Turns out angular brackets aren't in vogue in this file.
Pushed with a slightly altered comment.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-26 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-25 10:49 [bug#58773] [PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on some systems Christopher Baines
2022-10-25 19:10 ` Liliana Marie Prikler
2022-11-26 12:49 ` bug#58773: " Liliana Marie Prikler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).