From: Daniel Sockwell via Guix-patches via <guix-patches@gnu.org>
To: "Maxime Devos" <maximedevos@telenet.be>, 57491@debbugs.gnu.org
Subject: [bug#57491] [PATCH] patch series: Update Raku ecosystem
Date: Thu, 08 Sep 2022 02:18:00 +0000 [thread overview]
Message-ID: <6a94445eadf207371de0d4639c0a194a@codesections.com> (raw)
In-Reply-To: <e01718cc-4ff3-d82f-c450-1948a529b8aa@telenet.be>
Thanks so much for the feedback. I've answered a few questions inline
below and I'll follow up with revised patches in the next few days.
September 7, 2022 5:56 PM, "Maxime Devos" <maximedevos@telenet.be> wrote:
> IIUC, this means that previously, it didn't include a copy [of the
> Unicode Character Database], and now it does?
No, it did previously as well; the description just didn't mention it
> (If this was already the case in the previous version, that's still bad,
> but then it can be left for later, being independent of this patch.)
Understood. I'll put that on the to-do list for future patches (though
pinning specific versions of MoarVM/Rakudo to specific versions of the UCD
is important, so unbundling might mean including more up-to-date versions
of the UCD, unless Guix already stays very current there).
> I noticed you removed the mention of the garbage collector, is this
> intentional?
I cut the GC from the list of features in an effort to stay within Guix's
length guidelines for descriptions (and because having a GC doesn't do much
to distinguish Raku from Perl/Python/nearly all Lisps/JS, etc.) But the GC
is very much still present :)
> On nqp-configure: Are you sure that 'bin' should be installed in '.../bin'?
> Looking at the Git repository, make.nqp does not have a shebang and can hence
> not be directly run, maybe you should add a shebang?
>
> Also, is there appear to be some tests in 't', why aren't they run? There is a
> 'rakudo-build-system', maybe this rakudo-build-system can properly build this
> package
I'll double check the above.
> On nqp: why the switch from downloading the source code from the apparent official site
> "rakudo.perl6.org" to GitHub?
The Rakudo site no longer hosts NQP, just Rakudo. See https://rakudo.perl6.org/downloads
>> + (substitute* "t/09-moar/01-profilers.t"
>> + (("ok.*\\$htmlpath" html-test-text)
>> + (string-append "todo \"harness5 fails to write html profile\";"
>> + html-test-text)))))
>
> What's the issue here? Is it a limitation of the Guix packaging, or could it perhaps
> be an upstream bug? If the latter, upstream needs to be informed such that they can
> fix the bug.
I'm honestly unsure. I can't understand why it would be a Guix-specific issue, but I've
also never had that test fail when building from source on other distros. More investigation
is called for.
> On the new package description: ... It's getting close to marketing phrases
Thanks. I could tell I was getting a bit close to that line and guess I let my enthusiasm
carry me away a bit; I'll rein it in.
> Can you verify that our various perl6-... libraries still build, and that when doing, say,
> "guix shell rakudo perl6-json-name -- whatever-rakudos-binary-name-is", you can still use
> perl6-json-name in whatever is rakudo's name for a REPL?
Will do. (Everything *should* be backwards compatible, but it's 100% worth checking)
> You add some patches, but they need to be registered in gnu/local.mk as well, please do so.
Will do.
> On the patch file name: it looks a little suspect, perhaps if you run the linter on the
> packages it will have a comment about the file names.
I ran the linter and its only comment was that patches need to start with the package name.
Is there another rule?
> On commit messages: they don't follow our conventions. ... A new copyright line can also be added.
Will fix.
> Greetings,
Thanks! I'm glad to be able to help with a small corner of Guix :)
next prev parent reply other threads:[~2022-09-08 2:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 16:31 [bug#57491] [PATCH] patch series: Update Raku ecosystem Daniel Sockwell via Guix-patches via
2022-08-30 16:45 ` Daniel Sockwell via Guix-patches via
2022-08-30 16:49 ` Daniel Sockwell via Guix-patches via
2022-08-30 16:59 ` Daniel Sockwell via Guix-patches via
2022-09-07 16:26 ` Daniel Sockwell via Guix-patches via
2022-09-07 21:56 ` Maxime Devos
2022-09-08 2:18 ` Daniel Sockwell via Guix-patches via [this message]
2022-09-08 9:15 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a94445eadf207371de0d4639c0a194a@codesections.com \
--to=guix-patches@gnu.org \
--cc=57491@debbugs.gnu.org \
--cc=daniel@codesections.com \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).