From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kBf/KyNRGWO7CAEAbAwnHQ (envelope-from ) for ; Thu, 08 Sep 2022 04:19:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GDYSLCNRGWO+mgAA9RJhRA (envelope-from ) for ; Thu, 08 Sep 2022 04:19:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 602C938450 for ; Thu, 8 Sep 2022 04:19:15 +0200 (CEST) Received: from localhost ([::1]:54316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oW78M-0000V8-JN for larch@yhetil.org; Wed, 07 Sep 2022 22:19:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW78B-0000Ur-5g for guix-patches@gnu.org; Wed, 07 Sep 2022 22:19:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oW78A-0006fq-Tr for guix-patches@gnu.org; Wed, 07 Sep 2022 22:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oW78A-0000pd-Gz for guix-patches@gnu.org; Wed, 07 Sep 2022 22:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57491] [PATCH] patch series: Update Raku ecosystem Resent-From: "Daniel Sockwell" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Sep 2022 02:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57491 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Maxime Devos" , 57491@debbugs.gnu.org Received: via spool by 57491-submit@debbugs.gnu.org id=B57491.16626034863134 (code B ref 57491); Thu, 08 Sep 2022 02:19:02 +0000 Received: (at 57491) by debbugs.gnu.org; 8 Sep 2022 02:18:06 +0000 Received: from localhost ([127.0.0.1]:56787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oW77G-0000oU-8S for submit@debbugs.gnu.org; Wed, 07 Sep 2022 22:18:06 -0400 Received: from out2.migadu.com ([188.165.223.204]:54221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oW77D-0000oK-2j for 57491@debbugs.gnu.org; Wed, 07 Sep 2022 22:18:04 -0400 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codesections.com; s=key1; t=1662603481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FhM/FskMKDvKmJhIr19s+0iMcEGW8uvqH4B84MyrrPI=; b=F5XGRpm3DweZ5TAa2JGAiLg299vznuknXXI2Sc0kVnsEXFYj+Gn9OPIH1XTmiwu+QFNs61 +GHhiZfjt0ltAEFhhA7f4HYL0yH3FbDSXU8RRfeKlQYDFnag5l12jWLNnUoYI+IJz/fhHC gonF3Hf+maTBYtsa7WImsWYR3V/HgUZjMIAOTB0fk4N4ZKQYNdaTur1DjEy0sV5hKSyaVm CV2SeuWoNj1p047zTmnGVJc+TwPBQu4Y6MQf6W7IEHa5WlKL+LDGefKKsv/XpNfqK4H+57 JcfY/ytbC3QbQSmMll0BXgI+R6Q0v9fYx3QCtGGqL3u+/BLnkWXrCPa//viVag== Date: Thu, 08 Sep 2022 02:18:00 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. Message-ID: <6a94445eadf207371de0d4639c0a194a@codesections.com> In-Reply-To: References: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Daniel Sockwell X-ACL-Warn: , Daniel Sockwell via Guix-patches From: Daniel Sockwell via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662603555; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FhM/FskMKDvKmJhIr19s+0iMcEGW8uvqH4B84MyrrPI=; b=m4cOj60Bvfk/3ayOwfe2MzNdao3UH0IyQ5ZyFSGrQ/i4I62FzRqPQZtodfuD6OYYDcuzYB MwdaMpvxY2dtqV7L6MthP7lO5BZZGMGUTKqLlrPbTsDqXQb0oIzKcl4EX6wV5DSTu0cPXF AB0f6cNrmczWLqks1omCy5OVQzPYI95jRKxS9yCJ+kRzp8AmClo3Y2wf3bomz1amhXZIIR e05SEwNgicQEqP+85LuPhbtaPy8yRsD6wdZvOqPnLb8vFqWqEsX7uklvjTNdTO3olQhpeZ ZnhRcOJCzYd5dsHAOP9OXKt138aSpWVaSVOJanweZzeFDmsHinEAerie6UWy9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662603555; a=rsa-sha256; cv=none; b=l5tC0P4s6/1B5BJyKS0HoR0iC5O4skuBa8MRLhYQSRHf0ku+I6FnWy8CsqERGaGA/UTrWs 7Bf+q4ywVU+tBDPxKuyZMOtf2IUJLyESaiiwMZN49YDrAHvgxLH0zN87m5EBXK1VJPNwhy +G/HSh1cSrYLzA1Mr0/YmC5VTUZBChCFSiLBK9buEZzmeQVKHSRPZetMoCiZoTQUN2vXT7 I99ipFPx023n3nSOecRKWtHagmzT6QDmEDJvzs24xmAXItpiJIwUV0VQ5NcnPjO5XGlk4d p60vRZZptSf+bFOd7fZ3rmTTbkxp1kSvZTOqbdrrAoQqxtKYig7sDa63D58zcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=codesections.com header.s=key1 header.b=F5XGRpm3; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.78 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=codesections.com header.s=key1 header.b=F5XGRpm3; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 602C938450 X-Spam-Score: -1.78 X-Migadu-Scanner: scn1.migadu.com X-TUID: hcYfWaA+J0e6 Thanks so much for the feedback. I've answered a few questions inline =0A= below and I'll follow up with revised patches in the next few days.=0A=0A= September 7, 2022 5:56 PM, "Maxime Devos" wrote:= =0A> IIUC, this means that previously, it didn't include a copy [of the = =0A> Unicode Character Database], and now it does?=0A=0ANo, it did previo= usly as well; the description just didn't mention it=0A=0A> (If this was = already the case in the previous version, that's still bad,=0A> but then = it can be left for later, being independent of this patch.)=0A=0AUndersto= od. I'll put that on the to-do list for future patches (though =0Apinnin= g specific versions of MoarVM/Rakudo to specific versions of the UCD=0Ais= important, so unbundling might mean including more up-to-date versions= =0Aof the UCD, unless Guix already stays very current there).=0A=0A> I no= ticed you removed the mention of the garbage collector, is this =0A> inte= ntional? =0A=0AI cut the GC from the list of features in an effort to sta= y within Guix's =0Alength guidelines for descriptions (and because having= a GC doesn't do much=0Ato distinguish Raku from Perl/Python/nearly all L= isps/JS, etc.) But the GC=0Ais very much still present :)=0A=0A> On nqp-= configure: Are you sure that 'bin' should be installed in '.../bin'? =0A>= Looking at the Git repository, make.nqp does not have a shebang and can = hence=0A> not be directly run, maybe you should add a shebang?=0A> =0A> A= lso, is there appear to be some tests in 't', why aren't they run? There = is a=0A> 'rakudo-build-system', maybe this rakudo-build-system can proper= ly build this =0A> package =0A=0AI'll double check the above.=0A=0A> On n= qp: why the switch from downloading the source code from the apparent off= icial site=0A> "rakudo.perl6.org" to GitHub?=0A=0AThe Rakudo site no long= er hosts NQP, just Rakudo. See https://rakudo.perl6.org/downloads=0A=0A= =0A>> + (substitute* "t/09-moar/01-profilers.t"=0A>> + (("ok.*\\$htmlpath= " html-test-text)=0A>> + (string-append "todo \"harness5 fails to write h= tml profile\";"=0A>> + html-test-text)))))=0A> =0A> What's the issue here= ? Is it a limitation of the Guix packaging, or could it perhaps=0A> be an= upstream bug? If the latter, upstream needs to be informed such that the= y can =0A> fix the bug.=0A=0AI'm honestly unsure. I can't understand why= it would be a Guix-specific issue, but I've=0Aalso never had that test f= ail when building from source on other distros. More investigation=0Ais = called for.=0A=0A=0A> On the new package description: ... It's getting cl= ose to marketing phrases=0A=0AThanks. I could tell I was getting a bit c= lose to that line and guess I let my enthusiasm =0Acarry me away a bit; I= 'll rein it in.=0A=0A> Can you verify that our various perl6-... librarie= s still build, and that when doing, say, =0A> "guix shell rakudo perl6-js= on-name -- whatever-rakudos-binary-name-is", you can still use=0A> perl6-= json-name in whatever is rakudo's name for a REPL?=0A=0AWill do. (Everyt= hing *should* be backwards compatible, but it's 100% worth checking)=0A= =0A> You add some patches, but they need to be registered in gnu/local.mk= as well, please do so.=0A=0AWill do.=0A=0A> On the patch file name: it l= ooks a little suspect, perhaps if you run the linter on the =0A> packages= it will have a comment about the file names.=0A=0AI ran the linter and i= ts only comment was that patches need to start with the package name.=0AI= s there another rule?=0A=0A> On commit messages: they don't follow our co= nventions. ... A new copyright line can also be added.=0A=0AWill fix.=0A = =0A> Greetings,=0A=0AThanks! I'm glad to be able to help with a small co= rner of Guix :)