From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 39261@debbugs.gnu.org
Subject: [bug#39261] [PATCH] guix: import/crate: Move build-dependencies to cargo-inputs.
Date: Wed, 05 Feb 2020 07:14:04 +0000 [thread overview]
Message-ID: <6D8DAA60-B757-463F-A7A8-7D3022974A1F@flashner.co.il> (raw)
In-Reply-To: <87imkmt01b.fsf@gnu.org>
I'm actually going to let this one ride until we review the importer patches. Then if it still makes sense we can apply this one.
On February 4, 2020 11:17:36 PM UTC, "Ludovic Courtès" <ludo@gnu.org> wrote:
>Hello!
>
>Nitpick: for the subject line, I’d write:
>
> import: crate: Move build dependencies to cargo-inputs.
>
>Efraim Flashner <efraim@flashner.co.il> skribis:
>
>> * guix/import/crate.scm (crate->guix-package): Add definition for
>> 'dev-dependency?' and 'build-dependency?'. Adjust dep-crates to take
>> normal- and build- dependencies.
>
>[...]
>
>> + (define (dev-dependency? dependency)
>> + (eq? (crate-dependency-kind dependency) 'dev))
>
>Nitpick2: I’d recommend ‘development-dependency?’ as per the style
>guidelines. :-)
>
>Anyhow, LGTM!
>
>Thanks,
>Ludo’.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
prev parent reply other threads:[~2020-02-05 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 10:38 [bug#39261] [PATCH] guix: import/crate: Move build-dependencies to cargo-inputs Efraim Flashner
2020-02-04 23:17 ` Ludovic Courtès
2020-02-05 7:14 ` Efraim Flashner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D8DAA60-B757-463F-A7A8-7D3022974A1F@flashner.co.il \
--to=efraim@flashner.co.il \
--cc=39261@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).