From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:51243)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1izEtr-0006ZW-OJ
 for guix-patches@gnu.org; Wed, 05 Feb 2020 02:15:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1izEtq-000777-Mj
 for guix-patches@gnu.org; Wed, 05 Feb 2020 02:15:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:39090)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1izEtq-000766-Ik
 for guix-patches@gnu.org; Wed, 05 Feb 2020 02:15:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1izEtq-0002P5-Ee
 for guix-patches@gnu.org; Wed, 05 Feb 2020 02:15:02 -0500
Subject: [bug#39261] [PATCH] guix: import/crate: Move build-dependencies to
 cargo-inputs.
Resent-Message-ID: <handler.39261.B39261.15808868809187@debbugs.gnu.org>
Date: Wed, 05 Feb 2020 07:14:04 +0000
From: Efraim Flashner <efraim@flashner.co.il>
In-Reply-To: <87imkmt01b.fsf@gnu.org>
References: <20200124103843.29807-1-efraim@flashner.co.il>
 <87imkmt01b.fsf@gnu.org>
Message-ID: <6D8DAA60-B757-463F-A7A8-7D3022974A1F@flashner.co.il>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 39261@debbugs.gnu.org

I'm actually going to let this one ride until we review the importer patche=
s=2E Then if it still makes sense we can apply this one=2E

On February 4, 2020 11:17:36 PM UTC, "Ludovic Court=C3=A8s" <ludo@gnu=2Eor=
g> wrote:
>Hello!
>
>Nitpick: for the subject line, I=E2=80=99d write:
>
>  import: crate: Move build dependencies to cargo-inputs=2E
>
>Efraim Flashner <efraim@flashner=2Eco=2Eil> skribis:
>
>> * guix/import/crate=2Escm (crate->guix-package): Add definition for
>> 'dev-dependency?' and 'build-dependency?'=2E Adjust dep-crates to take
>> normal- and build- dependencies=2E
>
>[=2E=2E=2E]
>
>> +  (define (dev-dependency? dependency)
>> +    (eq? (crate-dependency-kind dependency) 'dev))
>
>Nitpick2: I=E2=80=99d recommend =E2=80=98development-dependency?=E2=80=99=
 as per the style
>guidelines=2E  :-)
>
>Anyhow, LGTM!
>
>Thanks,
>Ludo=E2=80=99=2E

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E