From: Brice Waegeneire <brice@waegenei.re>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 40104@debbugs.gnu.org,
Guix-patches
<guix-patches-bounces+brice+lists=waegenei.re@gnu.org>
Subject: [bug#40104] [PATCH 1/1] gnu: Add emacs-org-static-blog.
Date: Wed, 18 Mar 2020 08:26:07 +0000 [thread overview]
Message-ID: <64c029ab13977fff2c527f1aec183746@waegenei.re> (raw)
In-Reply-To: <87sgi7t3xt.fsf@nicolasgoaziou.fr>
On 2020-03-17 15:07, Nicolas Goaziou wrote:
> Hello,
>
> Brice Waegeneire <brice@waegenei.re> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.
>
> Thank you.
>
>> +(define-public emacs-org-static-blog
>> + (package
>> + (name "emacs-org-static-blog")
>> + (version "20200117.800")
>
> Could you explain in a comment why using an unstable release is
> required?
>
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://melpa.org/packages/org-static-blog-"
>> + version ".el"))
>
> It seems upstream is at Github, not MELPA. Could you use Github
> instead?
>
>> + (home-page
>> + "https://github.com/bastibe/org-static-blog")
>> + (synopsis
>> + "Simple org-mode based static blog generator")
>
> Nitpick: Simple Org mode based static blog generator
>
>> + (description
>> + "Org-static-blog is one more static blog generator, it focuses on
>> being
>> +simple. All files are simple org-mode files in a directory.
>
> Nitpick: All file are simple Org files in a directory.
>
>> The only
>> +requirement is that every org file must have a #+TITLE and a #+DATE,
>> and
>> +optionally, #+FILETAGS.")
>
> Nitpick: every Org file must have a @samp{title} and a @samp{date}
> keywords, and optionally, a @samp{filetags} keyword.
>
> Could you send an updated patch?
>
> Regards,
V2 send with all your suggestions added. And I have requested a new
release upstream: https://github.com/bastibe/org-static-blog/issues/50
next prev parent reply other threads:[~2020-03-18 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 14:12 [bug#40103] [PATCH 0/1] Add emacs-org-static-blog Brice Waegeneire
2020-03-17 14:12 ` [bug#40104] [PATCH 1/1] gnu: " Brice Waegeneire
2020-03-17 15:07 ` Nicolas Goaziou
2020-03-18 8:26 ` Brice Waegeneire [this message]
2020-03-18 11:28 ` bug#40104: " Nicolas Goaziou
2020-03-18 8:24 ` [bug#40104] [PATCH v2] " Brice Waegeneire
2020-03-18 17:15 ` Jack Hill
2020-03-18 20:51 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c029ab13977fff2c527f1aec183746@waegenei.re \
--to=brice@waegenei.re \
--cc=40104@debbugs.gnu.org \
--cc=guix-patches-bounces+brice+lists=waegenei.re@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).