From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39067)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEU2Z-00077D-7P
 for guix-patches@gnu.org; Wed, 18 Mar 2020 04:27:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEU2Y-0003Dd-2R
 for guix-patches@gnu.org; Wed, 18 Mar 2020 04:27:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:33826)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jEU2X-0003CD-UE
 for guix-patches@gnu.org; Wed, 18 Mar 2020 04:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEU2X-0005Sn-R7
 for guix-patches@gnu.org; Wed, 18 Mar 2020 04:27:01 -0400
Subject: [bug#40104] [PATCH 1/1] gnu: Add emacs-org-static-blog.
Resent-Message-ID: <handler.40104.B40104.158451997820948@debbugs.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 18 Mar 2020 08:26:07 +0000
From: Brice Waegeneire <brice@waegenei.re>
In-Reply-To: <87sgi7t3xt.fsf@nicolasgoaziou.fr>
References: <20200317141253.25851-1-brice@waegenei.re>
 <20200317141253.25851-2-brice@waegenei.re>
 <87sgi7t3xt.fsf@nicolasgoaziou.fr>
Message-ID: <64c029ab13977fff2c527f1aec183746@waegenei.re>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 40104@debbugs.gnu.org, Guix-patches <guix-patches-bounces+brice+lists=waegenei.re@gnu.org>

On 2020-03-17 15:07, Nicolas Goaziou wrote:
> Hello,
> 
> Brice Waegeneire <brice@waegenei.re> writes:
> 
>> * gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.
> 
> Thank you.
> 
>> +(define-public emacs-org-static-blog
>> +  (package
>> +   (name "emacs-org-static-blog")
>> +   (version "20200117.800")
> 
> Could you explain in a comment why using an unstable release is
> required?
> 
>> +   (source
>> +    (origin
>> +     (method url-fetch)
>> +     (uri (string-append
>> +           "https://melpa.org/packages/org-static-blog-"
>> +           version ".el"))
> 
> It seems upstream is at Github, not MELPA. Could you use Github 
> instead?
> 
>> +   (home-page
>> +    "https://github.com/bastibe/org-static-blog")
>> +   (synopsis
>> +    "Simple org-mode based static blog generator")
> 
> Nitpick: Simple Org mode based static blog generator
> 
>> +   (description
>> +    "Org-static-blog is one more static blog generator, it focuses on 
>> being
>> +simple.  All files are simple org-mode files in a directory.
> 
> Nitpick: All file are simple Org files in a directory.
> 
>> The only
>> +requirement is that every org file must have a #+TITLE and a #+DATE, 
>> and
>> +optionally, #+FILETAGS.")
> 
> Nitpick: every Org file must have a @samp{title} and a @samp{date}
> keywords, and optionally, a @samp{filetags} keyword.
> 
> Could you send an updated patch?
> 
> Regards,
V2 send with all your suggestions added. And I have requested a new 
release upstream: https://github.com/bastibe/org-static-blog/issues/50