unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: 67237@debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus@gmail.com>,
	Lars-Dominik Braun <lars@6xq.net>, Marius Bakke <marius@gnu.org>,
	Munyoki Kilyungi <me@bonfacemunyoki.com>,
	jgart <jgart@dismail.de>
Subject: [bug#67237] [PATCH 26/32] gnu: parfive: Improve package style.
Date: Fri, 17 Nov 2023 12:16:15 +0000	[thread overview]
Message-ID: <63f1240d08da23fccd765d07eb775fb38abcaf7e.1700222319.git.sharlatanus@gmail.com> (raw)
In-Reply-To: <cover.1700222319.git.sharlatanus@gmail.com>

* gnu/packages/python-web.scm (parfive): Update package style.
[build-system]: Swap to python-build-system.
[arguments]{phases}: Remove 'disable-test-requiring-network phase.  Use
standard 'check phase.  {test-flags}: Disable tests requiring network
access.

Change-Id: I5d233079f629398232f134c41fad6ea516c44c7f
---
 gnu/packages/python-web.scm | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 4b6f20745c..cc95643f07 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -1204,18 +1204,15 @@ (define-public parfive
               (sha256
                (base32
                 "0pf8rzfwxpkn84xzb4v8m1fy3k7kjlh8f9ln4y5xqlnbqpwi30lh"))))
-    (build-system python-build-system)
+    (build-system pyproject-build-system)
     (arguments
-     (list #:phases #~(modify-phases %standard-phases
-                        (add-before 'check 'disable-test-requiring-network
-                          (lambda _
-                            (substitute* "parfive/tests/test_downloader.py"
-                              (("def test_ftp")
-                               "def __off_test_ftp"))))
-                        (replace 'check
-                          (lambda* (#:key tests? #:allow-other-keys)
-                            (when tests?
-                              (invoke "python" "-m" "pytest" "-vvv" "parfive")))))))
+     (list
+      #:test-flags
+      ;; Disable tests requiring network access.
+      #~(list "-k" (string-append "not test_ftp"
+                                  " and not test_download_unique"
+                                  " and not test_custom_user_agent"
+                                  " and not test_multipart"))))
     (propagated-inputs (list python-aiofiles python-aioftp python-aiohttp
                              python-tqdm))
     (native-inputs (list python-pytest
-- 
2.41.0





  parent reply	other threads:[~2023-11-17 10:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 12:04 [bug#67237] [PATCH 00/32] gnu: Astronomy 2023/11 updates Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 01/32] gnu: celestia: Update to 1.6.4 Sharlatan Hellseher
2023-11-19  2:02   ` bug#67237: " Eric Bavier
2023-11-17 12:15 ` [bug#67237] [PATCH 02/32] gnu: gpredict: Improve package style Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 03/32] gnu: libpasastro: Update to 1.4.1 Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 04/32] gnu: python-asdf-3.0: Update to 3.0.1 Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 05/32] gnu: python-astroalign: Update to 2.5.1 Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 06/32] gnu: python-casa-formats-io: Update to 0.2.2 Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 07/32] gnu: python-crds: Update to 11.17.9 Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 08/32] gnu: python-fitsio: Update to 1.2.1 Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 09/32] gnu: python-jplephem: Update to 2.20 Sharlatan Hellseher
2023-11-17 12:15 ` [bug#67237] [PATCH 10/32] gnu: python-posix-ipc: Update to 1.1.1 Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 11/32] gnu: python-pynbody: Update to 1.4.2 Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 12/32] gnu: python-pynbody: Prepare for cross compilation Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 13/32] gnu: python-rad: Update to 0.18.0 Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 14/32] gnu: python-roman-datamodels: " Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 15/32] gnu: python-sgp4: Update to 2.23 Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 16/32] gnu: python-wiimatch: Update to 0.3.2 Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 17/32] gnu: splash: Update to 3.9.0 Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 18/32] gnu: python-drms: Simplify package Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 19/32] gnu: python-stsci-imagestats: Swap to pyproject-build-system Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 20/32] gnu: python-astroquery: Improve package style Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 21/32] gnu: python-extension-helpers: Enable tests Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 22/32] gnu: python-extension-helpers: Improve style Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 23/32] gnu: python-extension-helpers: Update to 1.1.0 Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 24/32] gnu: python-poliastro: Improve package style Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 25/32] gnu: parfive: Update to 2.0.2 Sharlatan Hellseher
2023-11-17 12:16 ` Sharlatan Hellseher [this message]
2023-11-17 12:16 ` [bug#67237] [PATCH 27/32] gnu: python-pytest-socket: Update to 0.6.0 Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 28/32] gnu: python-pytest-socket: Enable tests Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 29/32] gnu: python-memory-profiler: Enable all tests Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 30/32] gnu: python-synphot: Enable tests Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 31/32] gnu: python-stsci-stimage: " Sharlatan Hellseher
2023-11-17 12:16 ` [bug#67237] [PATCH 32/32] gnu: python-posix-ipc: Limit tests to target-x86 Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63f1240d08da23fccd765d07eb775fb38abcaf7e.1700222319.git.sharlatanus@gmail.com \
    --to=sharlatanus@gmail.com \
    --cc=67237@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=lars@6xq.net \
    --cc=marius@gnu.org \
    --cc=me@bonfacemunyoki.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).