[bug#60537] [PATCH] gnu: ledger: Install example referenced in docs.

[bug#60537] [PATCH] gnu: ledger: Install example referenced in docs.

[Frank Pursel]

* gnu/packages/finance.scm (ledger): Provide additional script from upstream.
---
 gnu/packages/finance.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index f5906ec738..abc2134aee 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2022 Philip McGrath <philip@philipmcgrath.com>
 ;;; Copyright © 2022 Collin J. Doering <collin@rekahsoft.ca>
 ;;; Copyright © 2022 Justin Veilleux <terramorpha@cock.li>
+;;; Copyright © 2023 Frank Pursel <frank.pursel@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -342,7 +343,8 @@ (define-public ledger
              (let ((examples (string-append (assoc-ref outputs "out")
                                             "/share/doc/ledger/examples")))
                (install-file "test/input/sample.dat" examples)
-               (install-file "test/input/demo.ledger" examples))
+               (install-file "test/input/demo.ledger" examples)
+               (install-file "config/report" examples))
              #t))
          (add-after 'build 'build-doc
            (lambda _ (invoke "make" "doc")))
-- 
2.38.1

[bug#60537] [PATCH] gnu: ledger: Install example referenced in docs.

[Frank Pursel]

Better.

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index f5906ec738..e96058e7b2 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2022 Philip McGrath <philip@philipmcgrath.com>
 ;;; Copyright © 2022 Collin J. Doering <collin@rekahsoft.ca>
 ;;; Copyright © 2022 Justin Veilleux <terramorpha@cock.li>
+;;; Copyright © 2023 Frank Pursel <frank.pursel@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -342,7 +343,8 @@ (define-public ledger
              (let ((examples (string-append (assoc-ref outputs "out")
                                             "/share/doc/ledger/examples")))
                (install-file "test/input/sample.dat" examples)
-               (install-file "test/input/demo.ledger" examples))
+               (install-file "test/input/demo.ledger" examples)
+               (install-file "contrib/report" examples))
              #t))
          (add-after 'build 'build-doc
            (lambda _ (invoke "make" "doc")))
-- 
2.38.1

[bug#60537] [PATCH] gnu: ledger: Install example referenced in docs.

[zimoun]

Hi,

On Wed, 04 Jan 2023 at 07:21, Frank Pursel <frank.pursel@gmail.com> wrote:

> Better.

Better compared to what?  It is the same patch as the previous one, no ?


Cheers,
simon

bug#60537: [PATCH] gnu: ledger: Install example referenced in docs.

[Ludovic Courtès]

Frank Pursel <frank.pursel@gmail.com> skribis:

> Better.
>
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index f5906ec738..e96058e7b2 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -32,6 +32,7 @@
>  ;;; Copyright © 2022 Philip McGrath <philip@philipmcgrath.com>
>  ;;; Copyright © 2022 Collin J. Doering <collin@rekahsoft.ca>
>  ;;; Copyright © 2022 Justin Veilleux <terramorpha@cock.li>
> +;;; Copyright © 2023 Frank Pursel <frank.pursel@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -342,7 +343,8 @@ (define-public ledger
>               (let ((examples (string-append (assoc-ref outputs "out")
>                                              "/share/doc/ledger/examples")))
>                 (install-file "test/input/sample.dat" examples)
> -               (install-file "test/input/demo.ledger" examples))
> +               (install-file "test/input/demo.ledger" examples)
> +               (install-file "contrib/report" examples))

Hi!  Applied with a commit log, thanks.

Ludo’.

[bug#60537] [PATCH] gnu: ledger: Install example referenced in docs.

[Frank Pursel]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

No, the second one is different.  I made a typo on the first one and tried
to bring the file in from the config directory but it's actually in the
'contrib' directory.  The second one is what we want.

Regards,
Frank

[-- Attachment #2: Type: text/html, Size: 291 bytes --]

[bug#60537] [PATCH] gnu: ledger: Install example referenced in docs.

[Frank Pursel]

It may be appropriate for me to provide a little more background on
this one line change to the ledger package.

I use the ledger package nearly daily and it works great.  Still when
you use it a lot and read the documentation you come across
info:(ledger3)"Visualizing with Gnuplot" and you see that another simple
utility is described, report, that adds considerable functionality to
ledger but is not provided in the guix version.  It seems to me that
this one line patch is the most trivial way to remedy this shortcoming.

Sincerely,
Frank