unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "دانیال بهزادی" <dani.behzi@ubuntu.com>
To: Maxime Devos <maximedevos@telenet.be>, 49170@debbugs.gnu.org
Cc: Raghav Gururajan <rg@raghavgururajan.name>
Subject: [bug#49170] [PATCH v2]: gnu: Add python-fire
Date: Mon, 28 Jun 2021 21:57:04 +0000	[thread overview]
Message-ID: <63CEA57F-D4D5-40E2-95A0-9F0EB0CEE806@ubuntu.com> (raw)
In-Reply-To: <ee84cadcf87dbf6de558e9c1b443110d900836a3.camel@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

This is awesome. I think Guix really lacks a very detailed document on packaging. Every patch I wrote is vastly based on apriority assumptions and lots of try and fails.

در 28 ژوئن 2021 21:30:46 (UTC)، Maxime Devos <maximedevos@telenet.be> نوشت:
>> +    (arguments
>> +     '(#:phases
>> +       (modify-phases %standard-phases
>> +         (replace 'check
>> +           (lambda _ (invoke "pytest"))))))
>
>I'm a bit late, as this has already been merged,
>but this should have been something like:
>
>> +         (replace 'check
>> +           (lambda* (#:key tests? #:allow-other-keys)
>> +             (when tests?
>> +               (invoke "pytest")))))))
>
>That way, tests can be disabled with "--without-tests".
>Try "./pre-inst-env guix build pytest --without-tests=pytests".
>Respecting #:tests? can also be important for cross-compilation.
>
>Could you send a follow-up patch, or could someone directly
>commit such a change?
>
>Greetings,
>Maxime. 

[-- Attachment #2: Type: text/html, Size: 1526 bytes --]

  parent reply	other threads:[~2021-06-28 21:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 13:33 [bug#49170] [PATCH] New package: python-fire Danial Behzadi
2021-06-26 13:19 ` دانیال بهزادی
2021-06-26 19:43 ` [bug#49170] [PATCH v2]: gnu: Add python-fire دانیال بهزادی
2021-06-26 19:52 ` دانیال بهزادی
2021-06-28 21:30   ` Maxime Devos
2021-06-28 21:50     ` Raghav Gururajan via Guix-patches via
2021-06-28 21:57     ` دانیال بهزادی [this message]
2021-06-29  8:06       ` Maxime Devos
2021-06-26 20:06 ` bug#49170: (no subject) Raghav Gururajan via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63CEA57F-D4D5-40E2-95A0-9F0EB0CEE806@ubuntu.com \
    --to=dani.behzi@ubuntu.com \
    --cc=49170@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).