From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IA3jF/BF2mDmAwEAgWs5BA (envelope-from ) for ; Mon, 28 Jun 2021 23:58:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KDxvE/BF2mAZcgAAbx9fmQ (envelope-from ) for ; Mon, 28 Jun 2021 21:58:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0327B1F204 for ; Mon, 28 Jun 2021 23:58:08 +0200 (CEST) Received: from localhost ([::1]:35674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxzGZ-000475-1u for larch@yhetil.org; Mon, 28 Jun 2021 17:58:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxzGU-00046v-Pz for guix-patches@gnu.org; Mon, 28 Jun 2021 17:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxzGU-0008SD-Il for guix-patches@gnu.org; Mon, 28 Jun 2021 17:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lxzGU-0001lK-Gv for guix-patches@gnu.org; Mon, 28 Jun 2021 17:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49170] [PATCH v2]: gnu: Add python-fire Resent-From: =?UTF-8?Q?=D8=AF=D8=A7=D9=86=DB=8C=D8=A7=D9=84_?= =?UTF-8?Q?=D8=A8=D9=87=D8=B2=D8=A7=D8=AF=DB=8C?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Jun 2021 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49170 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 49170@debbugs.gnu.org Cc: Raghav Gururajan Received: via spool by 49170-submit@debbugs.gnu.org id=B49170.16249174406724 (code B ref 49170); Mon, 28 Jun 2021 21:58:02 +0000 Received: (at 49170) by debbugs.gnu.org; 28 Jun 2021 21:57:20 +0000 Received: from localhost ([127.0.0.1]:53222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxzFn-0001kN-Un for submit@debbugs.gnu.org; Mon, 28 Jun 2021 17:57:20 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:34409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxzFk-0001k7-9P for 49170@debbugs.gnu.org; Mon, 28 Jun 2021 17:57:18 -0400 Received: by mail-wr1-f47.google.com with SMTP id p8so6991274wrr.1 for <49170@debbugs.gnu.org>; Mon, 28 Jun 2021 14:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:disposition-notification-to :return-receipt-to:in-reply-to:references:message-id:mime-version :content-transfer-encoding:autocrypt; bh=Fz/Hlay6aNbkBcByz9bt9SesmYeKtMoHp9TvIeWCTvg=; b=JcDnP2lf5qG9OrYoTUdEssigl1+1JCwuJ9YJEt4xosXQNpQjAEJHpOLOPpkEP7IZl5 PlnJFFIEMrvB9a85Gz8TUxb1AJeNaTKS1IhafF2uULbk5ESdewb6Q1husUnpwfjF7WL/ XMM0fUTe0oNNeLqRIY8QQ+KEakeMBNKbqBQoQ0JJJcqKW1p/0cNtrfi5wYNz4Z8sy8mw OcN1z4MzqI49YYudF3fMVlr4fJvMTRIowigF5+Ulk/w1HFVTatFh+QPyDzDqGHhGMdGB ewcL5XTJSiwcqJrbCA/5CihMJR0E2eQvOK/QnipO/XuEd10Ps78mdOQ2tjiRLm7mZRed eQEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject :disposition-notification-to:return-receipt-to:in-reply-to :references:message-id:mime-version:content-transfer-encoding :autocrypt; bh=Fz/Hlay6aNbkBcByz9bt9SesmYeKtMoHp9TvIeWCTvg=; b=YfjiDKwLR64TSA3YvZi40TWTUXk+DkKZW8MS8v9jRnTn+/I+f5vqvw7Y6m7Qyq7HFB YDgoWz3VL2CQjERlqzYDa8tSP+l0Iv8sxfMEWs0JLdhjW9osP+g1YLIkDNdPkIwl5ArR nl2ADX/M9eK/EJkNe/IvVjMqel2cLYD7WlvFdCm0fFH6d0ZSJJN7oeOMi9+d+g89WDB+ 1tya7Ujr0wPn7US1zvFeK2OVR4GdB/KakWP79QKQMbJVoGpFV7UrpuYIGnWCEKXB2Hx2 U04VP6Zx/IBnRhctTTSLn9rXXJ1VME2i0yqsrSNws3Kdcv3c915TDJNtXG1KDm7eZQZ7 ThHw== X-Gm-Message-State: AOAM533pWLXFb2ziYReX8MT2xb5Qj9h7O0UspHiBf3j+Q4gZ/mSK1Xqo rzbRD8R/8IsOFxdnN6tcCQA= X-Google-Smtp-Source: ABdhPJwUJlTB7C+7XRk9nuTf3TvF0u8L7i0jvYh1mIyeXhu7l5RhB1li6kiZYrRerJP9+cvb5Usnxg== X-Received: by 2002:a5d:684f:: with SMTP id o15mr835111wrw.134.1624917430335; Mon, 28 Jun 2021 14:57:10 -0700 (PDT) Received: from [127.0.0.1] ([5.209.108.196]) by smtp.gmail.com with ESMTPSA id e15sm16860539wrm.60.2021.06.28.14.57.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 14:57:09 -0700 (PDT) Date: Mon, 28 Jun 2021 21:57:04 +0000 From: =?UTF-8?Q?=D8=AF=D8=A7=D9=86=DB=8C=D8=A7=D9=84_?= =?UTF-8?Q?=D8=A8=D9=87=D8=B2=D8=A7=D8=AF=DB=8C?= In-Reply-To: References: <20210622133326.346547-1-dani.behzi@ubuntu.com> <6F62A6C8-CD81-49A0-BCC1-E1F733B31A61@ubuntu.com> Message-ID: <63CEA57F-D4D5-40E2-95A0-9F0EB0CEE806@ubuntu.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----3J3NMBK3X0L1K9M9XC2FQZ7KWIWRRI Content-Transfer-Encoding: 7bit Autocrypt: addr=dani.behzi@ubuntu.com; prefer-encrypt=mutual; keydata= mQENBFKGpdUBCAD1z1PsGJYPWdsRU3euT//QPUh7EGBRGV5TZdLawuZU2+EqFcC7OLn582akk5VA WQSLVoMKfgCiMWzYZsEioTwj0C4CT0RSOwe7WKPOB47AsgbRITInTET59vy6s9XzeNHIOsDCFiS1 RTAVJ7hmgOvbZMkrP/g4vHluko6e+VB2OLyTJXgKFAeJXEFXPyDXuAGoUxP9nEmC/rHqD2b8xr6N KGO48mlDabI/fHMpq/cCp7/LM5ye120S4hWi4wPh/28YeN2PkqJ/v+CH2apnfaFI3ijKzelXGXQX lBdh//vpG87XGp1hlIHpwO0vqiaWy+b3qNIYzwJP30biwOuGwu5LABEBAAG0JkRhbmlhbCBCZWh6 YWRpIDxkYW5pLmJlaHppQHVidW50dS5jb20+iQFYBBMBCgBCAhsDBgsJCAcDAgYVCAIJCgsEFgID AQIeAQIXgAIZARYhBMFKiJJVfERBUOINfraWjvvASS/GBQJeoFFyBQkSzduzAAoJELaWjvvASS/G xGQH/Ren/cepzFyzFoX2ab4gxZu1DmquLoQC5D/F5qgVLPaCNI2C4J0lcBHuOksuXyKX6i/rKr42 zsU+sY8umGBOvAqUtI67wO36FFVbrutK0sAv5IxpsHPhWoxSrJldjG+zhq0zugmaCCoZwLQqd5x3 91jegoRWhBsyKomASLswSWdnqeNKjCcPcUwvnx3ei2nhErZ/OGPoHtUqS8NF69qmvcCanwABHOma TVnmTEnwS0D6z59F8oMP7ap8CNLGZp06kS+WCwr8KzuItqS1GaI9zBjuoTCBmcsHQAGQidoUHcqv QLWZcAxflZFXiXzRjJ4BXyph+uJI6V9bevYDf597B125AQ0EUoal1QEIANce2f/Y2whrrtWHNLq2 Fx2IcWnna4XyY1l0jAaGmYE2x0pwWEv1Pw9ihYJEs8Sce4Sj13kbHlJrnlc81vYKsU1qZgGZnRth GbGp5PebEuoBUEDqe/0Jrv6B1Gdq+Fi1AopUBhNsCiYyHN1h6Sh1YdhsUv1P9rPlLrzM9iTKYI+d SKP9IKAyiYfkM610znxrTzDQgZQQ66fIEIgg0LCbofcuNRZG2lxb4dIncisuYGvW/Ci6PsvVfU8D W5kAC1OdSYUmolXkUOxv0XBZALDJq5vnzAHgPoS5Azou2Q9Wc+aqw2OdGkx/C4vyuXVW2yNo60QM JAVsmvoqdhB/+yNtVy8AEQEAAYkBPAQYAQoAJgIbDBYhBMFKiJJVfERBUOINfraWjvvASS/GBQJe oFHLBQkSzduzAAoJELaWjvvASS/GajYH/1ylL8x+XTu+Oeim1ObBnwceue68qPxk5TGsjZw8n+/8 Pda4+ZP/3fu6FtT2yo3hlrcyc4AmVVgZDt78RG0uFNkjCiBMn4s9JEBc5BCaLW2R8YYM2lhsEmeb Jg4sr0wT4VlKsM2Hb87u/vWIequdwfcqv9OYk+akMwzx3TYiVWIqC1RuL87eMAkDF187/KCE0gAi iMgty9wv4qTXZj6kx9eTio+c+Mk0gAMHkDC1VO/occttsUHD34ciRjV/YwvoYOycX8coC5nP0KpO zi5izzGprkjohfYAbiG+fi3gga6hnqwg3Orrqh20splKeJI8skYDmnuDaehURtQhNyUjq1U= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624917488; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=Fz/Hlay6aNbkBcByz9bt9SesmYeKtMoHp9TvIeWCTvg=; b=R74HKKkjPnjF1uLeHGmdIC07FmXAlS5UFIYKyL3srifFYTxYq/yzsPLEYoxsjWW4XleW70 jA4l0RAjA565Ch+bwiPWxnQwjSVGhQnAmRuKFyJ7uSYaV1Qd3p4aR2rRy+OXnIgvwKUJ7F QejcAt5baZRkNVb8k6L19V5qaX8XiGqLoQroBR+FwX5Bbvq1K0auPgvO29Q2/ue4sDfu9F ob2+NPuk14ctQpZ3esZswmuc5iikmTHg+44XcOv3D9F8kQYnZ4yp4Us4TZgoyQRWMdZV3X GtOwp26bIeEyEdAOQHqgRgJrP3ngzR60TAA029ggUU1nEG9+nD2t3IZZydnXQw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624917488; a=rsa-sha256; cv=none; b=foM1L9w28TwPOTIyEUgslPXRt/E6AOl1dO6nSvkUfTMftVW7Q0XPExtV7b0P0LsF7AhRV/ /Ygkm3GoTafZmXQe3YOTv1fPMhVMTZSocRfKcEvIBRRKIibpqHYMtx7UwRVRpvqNRqxgla +yeCuMd+QIb+h2iSJ3kh7FP4++s+K6qMI7Ndo4eoEkiSxYK4AuM8SSyBDcrFk3bjKkRLuX qt3Et/X8/ddCjDbWgFaA/TVQk/ab9hr79UBb6wBQ6IgEiQT7dF2hgFt6gyprdYUnL6ki/5 6GieVRv4y3JAQ7hdMjXSK9ZHmFyBwJKTVBRfkZKG9HefEF1NZ2++k1xvyZyv0w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=JcDnP2lf; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=JcDnP2lf; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0327B1F204 X-Spam-Score: -1.42 X-Migadu-Scanner: scn1.migadu.com X-TUID: OR8gxQOXX6Db ------3J3NMBK3X0L1K9M9XC2FQZ7KWIWRRI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable This is awesome=2E I think Guix really lacks a very detailed document on pa= ckaging=2E Every patch I wrote is vastly based on apriority assumptions and= lots of try and fails=2E =D8=AF=D8=B1 28 =DA=98=D9=88=D8=A6=D9=86 2021 21:30:46 (UTC)=D8=8C Maxime = Devos =D9=86=D9=88=D8=B4=D8=AA: >> + (arguments >> + '(#:phases >> + (modify-phases %standard-phases >> + (replace 'check >> + (lambda _ (invoke "pytest")))))) > >I'm a bit late, as this has already been merged, >but this should have been something like: > >> + (replace 'check >> + (lambda* (#:key tests? #:allow-other-keys) >> + (when tests? >> + (invoke "pytest"))))))) > >That way, tests can be disabled with "--without-tests"=2E >Try "=2E/pre-inst-env guix build pytest --without-tests=3Dpytests"=2E >Respecting #:tests? can also be important for cross-compilation=2E > >Could you send a follow-up patch, or could someone directly >commit such a change? > >Greetings, >Maxime=2E=20 ------3J3NMBK3X0L1K9M9XC2FQZ7KWIWRRI Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable This is awesome=2E I think Guix really lacks a ver= y detailed document on packaging=2E Every patch I wrote is vastly based on = apriority assumptions and lots of try and fails=2E

=D8=AF=D8=B1 28 =DA=98=D9=88=D8=A6=D9=86 2021 21:30:46 (UTC)=D8= =8C Maxime Devos <maximedevos@telenet=2Ebe> =D9=86=D9=88=D8=B4=D8=AA:= 
+    (arguments
+     '(#:phases
+       (modify-phases %st=
andard-phases
+         (replace 'check
+           (lambda _ (invoke=
 "pytest"))))))

I'm a bit late, as this has already bee=
n merged,
but this should have been something like:

+         (replace 'check
+         =
  (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?<=
br>+               (invoke "pytest")))))))

That way, te=
sts can be disabled with "--without-tests"=2E
Try "=2E/pre-inst-env guix=
 build pytest --without-tests=3Dpytests"=2E
Respecting #:tests? can also=
 be important for cross-compilation=2E

Could you send a follow-up pa=
tch, or could someone directly
commit such a change?

Greetings,Maxime=2E
------3J3NMBK3X0L1K9M9XC2FQZ7KWIWRRI--