unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Miguel <rosen644835@gmail.com>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: "Ludovic Courtès" <ludo@gnu.org>, 37693@debbugs.gnu.org
Subject: [bug#37693] Seahorse build
Date: Mon, 21 Oct 2019 18:59:39 +0200	[thread overview]
Message-ID: <5dade403.1c69fb81.b296.84cc@mx.google.com> (raw)
In-Reply-To: <e0b5ce9115ff5343a37193ff2e89f0b7b50f8fe1.camel@student.tugraz.at>

Hi,

El 21 oct. 2019 18:22, Leo Prikler <leo.prikler@student.tugraz.at> escribió:
>
> Am Montag, den 21.10.2019, 17:25 +0200 schrieb Miguel Arruga Vivas: 
>>> > > > > @@ -2244,8 +2248,10 @@ engineering.") 
> > > > >      (native-inputs 
> > > > >       `(("intltool" ,intltool) 
> > > > >         ("glib:bin" ,glib "bin") 
> > > > > +       ("gtk+:bin" ,gtk+ "bin") 
> > > > >         ("itstool" ,itstool) 
> > > > >         ("pkg-config" ,pkg-config) 
> > > > > +       ("vala" ,vala) 
> > > > 
> > > > Likewise, these changes were necessary, right? 
> > > 
> > > Indeed. After changing the build system, I've repeatedly run "guix 
> > > build seahorse" and added the inputs that the build system 
> > > complained 
> > > about until the build succeeded. ("gtk+:bin" is necessary due to 
> > > the 
> > > icon cache IIRC). 
> > 
> > I've solved this modifying the %standard-phases, as in other packages 
> > from gnome. 
> I'm not sure, whether that is the right approach. Seahorse used glib- 
> or-gtk-build-system before, so I would assume the generation of those 
> caches is expected. 

The icon.cache is generated later by a profile hook, as it must include all icons from the user-installed packages and not only seahorse ones. That's the reason behind its removal during installation phase.

> > I don't have the last one because it is fixed with 3.30.1.1.  Also, I 
> > have an extra python that could be a leftover. 
> Would you mind checking, whether your patch works with gtk+:bin added 
> and without python? If so, I'd find it preferable to mine. 

I cannot test the python removal right now, but I'll answer as soon I can build it.

Best regards,
Miguel

  parent reply	other threads:[~2019-10-21 17:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10  8:56 [bug#37693] Seahorse build Leo Prikler
2019-10-13 12:35 ` Leo Prikler
2019-10-15 12:09 ` Ludovic Courtès
2019-10-15 12:36   ` Leo Prikler
2019-10-21 15:25 ` Miguel Arruga Vivas
2019-10-21 16:22   ` Leo Prikler
2019-10-21 16:59 ` Miguel [this message]
2019-10-21 17:20   ` Miguel Arruga Vivas
2019-10-22 16:27     ` bug#37693: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dade403.1c69fb81.b296.84cc@mx.google.com \
    --to=rosen644835@gmail.com \
    --cc=37693@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).