From: Leo Prikler <leo.prikler@student.tugraz.at>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 37693@debbugs.gnu.org
Subject: [bug#37693] Seahorse build
Date: Tue, 15 Oct 2019 14:36:01 +0200 [thread overview]
Message-ID: <2ab76f3e15613fb2b0944fe84b97feb55afc43e3.camel@student.tugraz.at> (raw)
In-Reply-To: <87a7a2w6qr.fsf@gnu.org>
Am Dienstag, den 15.10.2019, 14:09 +0200 schrieb Ludovic Courtès:
> > - (build-system glib-or-gtk-build-system)
> > + "1sbj1czlx1fakm72dwgbn0bwm12j838yaky4mkf6hf8j8afnxmzp"))
> > + (patches
> > + (search-patches "seahorse-fix-libsecret-breakage.patch"
> > + "seahorse-fix-type-mismatches.patch"))))
> > + (build-system meson-build-system)
>
> Is changing the build system necessary to fix the problems you
> encountered, or is it a side change? From the current build log at
> <
> https://ci.guix.gnu.org/log/3j08dl90hlyq9haf9lh61k43fs60dcih-seahorse-3.30>
> ;,
> it does seem that the answer is “yes”. :-)
Yes, Seahorse 3.30 no longer builds using Autotools.
> > (inputs
> > - `(("gtk+" ,gtk+)
> > + `(("avahi" ,avahi)
> > + ("gtk+" ,gtk+)
> > ("gcr" ,gcr)
> > ("gnupg" ,gnupg)
> > ("gpgme" ,gpgme)
> > @@ -2244,8 +2248,10 @@ engineering.")
> > (native-inputs
> > `(("intltool" ,intltool)
> > ("glib:bin" ,glib "bin")
> > + ("gtk+:bin" ,gtk+ "bin")
> > ("itstool" ,itstool)
> > ("pkg-config" ,pkg-config)
> > + ("vala" ,vala)
>
> Likewise, these changes were necessary, right?
Indeed. After changing the build system, I've repeatedly run "guix
build seahorse" and added the inputs that the build system complained
about until the build succeeded. ("gtk+:bin" is necessary due to the
icon cache IIRC).
> One last thing: are those patches upstream, or is there a bug report
> where they were discussed?
>
> If so could you share the URLs? I can add them on your behalf in the
> .patch file if you want. That’ll allow us to better keep track of
> where
> our patches come from and when we can remove them.
These patches come from Seahorse upstream.
seahorse-fix-libsecret-breakage.patch was taken from [1], with its
offset adjusted.
seahorse-fix-type-mismatches.patch was taken from [2] as-is.
The latter appears to be fixed in 3.32 (and also some versions prior),
the former in 3.34.
All the best,
Leo
[1]
https://gitlab.gnome.org/GNOME/seahorse/commit/d9db29db567012b7c72e85e1be1fbf55fcc9b667
[2] https://gitlab.gnome.org/GNOME/seahorse/merge_requests/31
next prev parent reply other threads:[~2019-10-15 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 8:56 [bug#37693] Seahorse build Leo Prikler
2019-10-13 12:35 ` Leo Prikler
2019-10-15 12:09 ` Ludovic Courtès
2019-10-15 12:36 ` Leo Prikler [this message]
2019-10-21 15:25 ` Miguel Arruga Vivas
2019-10-21 16:22 ` Leo Prikler
2019-10-21 16:59 ` Miguel
2019-10-21 17:20 ` Miguel Arruga Vivas
2019-10-22 16:27 ` bug#37693: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab76f3e15613fb2b0944fe84b97feb55afc43e3.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=37693@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).