unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown.
@ 2020-03-28  9:33 pinoaffe
  2020-03-28  9:36 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: pinoaffe @ 2020-03-28  9:33 UTC (permalink / raw)
  To: 40270


* gnu/packages/python-web.scm (python-flask-markdown, 
python2-flask-markdown): New variables.
---
  gnu/packages/python-web.scm | 30 ++++++++++++++++++++++++++++++
  1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index b02ffd5f58..db66f1ed4d 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -470,6 +470,36 @@ both of which are installed automatically if you 
install this library.")
  (define-public python2-flask-babel
    (package-with-python2 python-flask-babel))

+(define-public python-flask-markdown
+  (package
+    (name "python-flask-markdown")
+    (version "0.3")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "Flask-Markdown" version))
+        (sha256
+          (base32
+            "0l32ikv4f7va926jlq4f7gx0xid247bhlxl6bd9av5dk8ljz1hyq"))))
+    (build-system python-build-system)
+    (arguments
+       `(#:tests? #f))
+    (propagated-inputs
+      `(("python-markdown" ,python-markdown)
+        ("python-flask" ,python-flask)))
+    (native-inputs
+      `(("python-nose" ,python-nose)))
+    (home-page
+      "http://github.com/dcolish/flask-markdown")
+    (synopsis
+      "Small extension to make using markdown in flask easy")
+    (description
+      "Small extension to make using markdown in flask easy")
+    (license license:bsd-3)))
+
+(define-public python2-flask-markdown
+  (package-with-python2 python-flask-markdown))
+
  (define-public python-html5lib
    (package
      (name "python-html5lib")
-- 
2.25.2

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
  2020-03-28  9:33 [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown pinoaffe
@ 2020-03-28  9:36 ` pinoaffe
  2020-03-29 20:11   ` Marius Bakke
  2020-03-29 20:10 ` [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown Marius Bakke
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 12+ messages in thread
From: pinoaffe @ 2020-03-28  9:36 UTC (permalink / raw)
  To: 40270


* gnu/packages/python-web.scm (python-flask-session, 
python2-flask-session): New variables.
---
  gnu/packages/python-web.scm | 27 +++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index db66f1ed4d..acca981eee 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -500,6 +500,33 @@ both of which are installed automatically if you 
install this library.")
  (define-public python2-flask-markdown
    (package-with-python2 python-flask-markdown))

+(define-public python-flask-session
+  (package
+    (name "python-flask-session")
+    (version "0.3.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "Flask-Session" version))
+        (sha256
+          (base32
+            "0cd7h5c236m6smyixnyfrks4spsqp9d65ndk4p400zr8qgh2f753"))))
+    (build-system python-build-system)
+    (arguments
+       `(#:tests? #f))
+    (propagated-inputs
+      `(("python-flask" ,python-flask)))
+    (home-page
+      "https://github.com/fengsp/flask-session")
+    (synopsis
+      "Adds server-side session support to your Flask application")
+    (description
+      "Adds server-side session support to your Flask application")
+    (license license:bsd-3)))
+
+(define-public python2-flask-session
+  (package-with-python2 python-flask-session))
+
  (define-public python-html5lib
    (package
      (name "python-html5lib")
-- 
2.25.2

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown.
  2020-03-28  9:33 [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown pinoaffe
  2020-03-28  9:36 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
@ 2020-03-29 20:10 ` Marius Bakke
  2020-11-22 17:52 ` pinoaffe
  2020-11-22 19:15 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
  3 siblings, 0 replies; 12+ messages in thread
From: Marius Bakke @ 2020-03-29 20:10 UTC (permalink / raw)
  To: pinoaffe, 40270

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

pinoaffe@airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-markdown, 
> python2-flask-markdown): New variables.

Note: I merged your previous bug report that adds this package (#40165)
with this bug (#40270).  The comments still stand however!  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
  2020-03-28  9:36 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
@ 2020-03-29 20:11   ` Marius Bakke
  2020-11-21  9:15     ` Christopher Baines
  0 siblings, 1 reply; 12+ messages in thread
From: Marius Bakke @ 2020-03-29 20:11 UTC (permalink / raw)
  To: pinoaffe, 40270

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

pinoaffe@airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-session, 
> python2-flask-session): New variables.

I have the same comments on this package as the python-flask-markdown
patch.  Can you send an updated patch?

Also the python2 variants can be omitted unless you plan on using them.
Python 2 is deprecated, so we do not add new Python 2 packages unless
required by something else.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
  2020-03-29 20:11   ` Marius Bakke
@ 2020-11-21  9:15     ` Christopher Baines
  2020-11-22 17:49       ` pinoaffe
  0 siblings, 1 reply; 12+ messages in thread
From: Christopher Baines @ 2020-11-21  9:15 UTC (permalink / raw)
  To: pinoaffe; +Cc: 40270

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]


Marius Bakke <mbakke@fastmail.com> writes:

> pinoaffe@airmail.cc writes:
>
>> * gnu/packages/python-web.scm (python-flask-session,
>> python2-flask-session): New variables.
>
> I have the same comments on this package as the python-flask-markdown
> patch.  Can you send an updated patch?
>
> Also the python2 variants can be omitted unless you plan on using them.
> Python 2 is deprecated, so we do not add new Python 2 packages unless
> required by something else.

It's been a few months, are these patches still relevant?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
  2020-11-21  9:15     ` Christopher Baines
@ 2020-11-22 17:49       ` pinoaffe
  2020-11-28 12:33         ` Christopher Baines
  0 siblings, 1 reply; 12+ messages in thread
From: pinoaffe @ 2020-11-22 17:49 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 40270

thanks for the reminder,
I'd completely forgotten about these patches,
will send new ones with the changes you suggested applied in a minute

On 2020-11-21 09:15, Christopher Baines wrote:
> Marius Bakke <mbakke@fastmail.com> writes:
> 
>> pinoaffe@airmail.cc writes:
>> 
>>> * gnu/packages/python-web.scm (python-flask-session,
>>> python2-flask-session): New variables.
>> 
>> I have the same comments on this package as the python-flask-markdown
>> patch.  Can you send an updated patch?
>> 
>> Also the python2 variants can be omitted unless you plan on using 
>> them.
>> Python 2 is deprecated, so we do not add new Python 2 packages unless
>> required by something else.
> 
> It's been a few months, are these patches still relevant?
> 
> Thanks,
> 
> Chris




^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown.
  2020-03-28  9:33 [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown pinoaffe
  2020-03-28  9:36 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
  2020-03-29 20:10 ` [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown Marius Bakke
@ 2020-11-22 17:52 ` pinoaffe
  2020-11-28 13:13   ` Christopher Baines
  2020-11-22 19:15 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
  3 siblings, 1 reply; 12+ messages in thread
From: pinoaffe @ 2020-11-22 17:52 UTC (permalink / raw)
  To: 40270; +Cc: mail

* gnu/packages/python-web.scm (python-flask-markdown): New variable.
---
  gnu/packages/python-web.scm | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index b02ffd5f58..baf24d3849 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -470,6 +470,34 @@ both of which are installed automatically if you 
install this library.")
  (define-public python2-flask-babel
    (package-with-python2 python-flask-babel))

+(define-public python-flask-markdown
+  (package
+    (name "python-flask-markdown")
+    (version "0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Flask-Markdown" version))
+       (sha256
+        (base32
+         "0l32ikv4f7va926jlq4f7gx0xid247bhlxl6bd9av5dk8ljz1hyq"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;tests seem to be incompatible with latest python
+    (propagated-inputs
+     `(("python-markdown" ,python-markdown)
+       ("python-flask" ,python-flask)))
+    (native-inputs
+     `(("python-nose" ,python-nose)))
+    (home-page
+     "http://github.com/dcolish/flask-markdown")
+    (synopsis
+     "Small extension to make using Markdown in Flask easy")
+    (description
+     "Small extension to make using Markdown in Flask easy.  Supports
+several extensions for Markdown and integrates into Jinja2 by 
default.")
+    (license license:bsd-3)))
+
  (define-public python-html5lib
    (package
      (name "python-html5lib")
-- 
2.29.2





^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
  2020-03-28  9:33 [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown pinoaffe
                   ` (2 preceding siblings ...)
  2020-11-22 17:52 ` pinoaffe
@ 2020-11-22 19:15 ` pinoaffe
  2020-11-28 13:16   ` Christopher Baines
  2020-11-28 13:17   ` bug#40270: " Christopher Baines
  3 siblings, 2 replies; 12+ messages in thread
From: pinoaffe @ 2020-11-22 19:15 UTC (permalink / raw)
  To: 40270; +Cc: mail

* gnu/packages/python-web.scm (python-flask-session, 
python2-flask-session): New variables.
---
  gnu/packages/python-web.scm | 25 +++++++++++++++++++++++++
  1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index baf24d3849..4ad81ef6e5 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -498,6 +498,31 @@ both of which are installed automatically if you 
install this library.")
  several extensions for Markdown and integrates into Jinja2 by 
default.")
      (license license:bsd-3)))

+(define-public python-flask-session
+  (package
+    (name "python-flask-session")
+    (version "0.3.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Flask-Session" version))
+       (sha256
+        (base32
+         "0cd7h5c236m6smyixnyfrks4spsqp9d65ndk4p400zr8qgh2f753"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;tests require the various storage backends to be 
present
+    (propagated-inputs
+     `(("python-flask" ,python-flask)))
+    (home-page
+     "https://github.com/fengsp/flask-session")
+    (synopsis
+     "Adds server-side session support to your Flask application")
+    (description
+     "Adds server-side support for secure sessions to your Flask 
application,
+and supports a variety of different backends for session storage.")
+    (license license:bsd-3)))
+
  (define-public python-html5lib
    (package
      (name "python-html5lib")
-- 
2.29.2




^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
  2020-11-22 17:49       ` pinoaffe
@ 2020-11-28 12:33         ` Christopher Baines
  0 siblings, 0 replies; 12+ messages in thread
From: Christopher Baines @ 2020-11-28 12:33 UTC (permalink / raw)
  To: pinoaffe; +Cc: 40270

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]


pinoaffe@airmail.cc writes:

> thanks for the reminder,
> I'd completely forgotten about these patches,
> will send new ones with the changes you suggested applied in a minute

Awesome, thanks, I'll have a look at the new patches momentarily.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown.
  2020-11-22 17:52 ` pinoaffe
@ 2020-11-28 13:13   ` Christopher Baines
  0 siblings, 0 replies; 12+ messages in thread
From: Christopher Baines @ 2020-11-28 13:13 UTC (permalink / raw)
  To: pinoaffe; +Cc: 40270

[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]


pinoaffe@airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-markdown): New variable.
> ---
>  gnu/packages/python-web.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index b02ffd5f58..baf24d3849 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -470,6 +470,34 @@ both of which are installed automatically if you
> install this library.")
>  (define-public python2-flask-babel
>    (package-with-python2 python-flask-babel))
>
> +(define-public python-flask-markdown
> +  (package
> +    (name "python-flask-markdown")
> +    (version "0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Flask-Markdown" version))
> +       (sha256
> +        (base32
> +         "0l32ikv4f7va926jlq4f7gx0xid247bhlxl6bd9av5dk8ljz1hyq"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;tests seem to be incompatible with latest python
> +    (propagated-inputs
> +     `(("python-markdown" ,python-markdown)
> +       ("python-flask" ,python-flask)))
> +    (native-inputs
> +     `(("python-nose" ,python-nose)))
> +    (home-page
> +     "http://github.com/dcolish/flask-markdown")

I'm guessing the linter might have spotted this, but I've changed it to
https:// as that's a better default.

> +    (synopsis
> +     "Small extension to make using Markdown in Flask easy")
> +    (description
> +     "Small extension to make using Markdown in Flask easy.  Supports
> +several extensions for Markdown and integrates into Jinja2 by
> default.")

The description is just repeating the synopsis at the start, I rewrote
this to:

Flask-Markdown supports several extensions for Markdown and integrates
into Jinja2 by default.

> +    (license license:bsd-3)))
> +
>  (define-public python-html5lib
>    (package
>      (name "python-html5lib")


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [bug#40270] [PATCH 2/2] gnu: Add python-flask-session.
  2020-11-22 19:15 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
@ 2020-11-28 13:16   ` Christopher Baines
  2020-11-28 13:17   ` bug#40270: " Christopher Baines
  1 sibling, 0 replies; 12+ messages in thread
From: Christopher Baines @ 2020-11-28 13:16 UTC (permalink / raw)
  To: pinoaffe; +Cc: 40270

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]


pinoaffe@airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-session,
>   python2-flask-session): New variables.
> ---
>  gnu/packages/python-web.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index baf24d3849..4ad81ef6e5 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -498,6 +498,31 @@ both of which are installed automatically if you
> install this library.")
>  several extensions for Markdown and integrates into Jinja2 by
>  default.")
>      (license license:bsd-3)))
>
> +(define-public python-flask-session
> +  (package
> +    (name "python-flask-session")
> +    (version "0.3.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Flask-Session" version))
> +       (sha256
> +        (base32
> +         "0cd7h5c236m6smyixnyfrks4spsqp9d65ndk4p400zr8qgh2f753"))))

0.3.2 has been released, so I updated to that.

> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;tests require the various storage backends to
> be present
> +    (propagated-inputs
> +     `(("python-flask" ,python-flask)))
> +    (home-page
> +     "https://github.com/fengsp/flask-session")
> +    (synopsis
> +     "Adds server-side session support to your Flask application")
> +    (description
> +     "Adds server-side support for secure sessions to your Flask
> application,
> +and supports a variety of different backends for session storage.")

Similar to python-flask-markdown, I tweaked the description here so it's
less repetitive.

Flask-Session is an extension for Flask that adds support for
Server-side sessions, with a variety of different backends for session
storage.

> +    (license license:bsd-3)))
> +
>  (define-public python-html5lib
>    (package
>      (name "python-html5lib")


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#40270: [PATCH 2/2] gnu: Add python-flask-session.
  2020-11-22 19:15 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
  2020-11-28 13:16   ` Christopher Baines
@ 2020-11-28 13:17   ` Christopher Baines
  1 sibling, 0 replies; 12+ messages in thread
From: Christopher Baines @ 2020-11-28 13:17 UTC (permalink / raw)
  To: pinoaffe; +Cc: 40270-done

[-- Attachment #1: Type: text/plain, Size: 89 bytes --]


I've pushed these as 9e2669690c80dc00973859edf732964f0a514d7b now, so
closing.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-11-28 13:18 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-28  9:33 [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown pinoaffe
2020-03-28  9:36 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
2020-03-29 20:11   ` Marius Bakke
2020-11-21  9:15     ` Christopher Baines
2020-11-22 17:49       ` pinoaffe
2020-11-28 12:33         ` Christopher Baines
2020-03-29 20:10 ` [bug#40270] [PATCH 1/2] gnu: Add python-flask-markdown Marius Bakke
2020-11-22 17:52 ` pinoaffe
2020-11-28 13:13   ` Christopher Baines
2020-11-22 19:15 ` [bug#40270] [PATCH 2/2] gnu: Add python-flask-session pinoaffe
2020-11-28 13:16   ` Christopher Baines
2020-11-28 13:17   ` bug#40270: " Christopher Baines

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git