[bug#38118] [PATCH] gnu: Add avldrums-lv2.

[bug#38118] [PATCH] gnu: Add avldrums-lv2.

[Alexandros Theodotou]

 From aae805260db2b830a35459ae219c780e6619cc14 Mon Sep 17 00:00:00 2001
 From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 09:35:38 +0000
Subject: [PATCH] gnu: Add avldrums-lv2.

* gnu/packages/music.scm: (avldrums-lv2): New variable.
---
  gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 43 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..38d30c5438 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
  ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org>
  ;;; Copyright © 2019 raingloom <raingloom@protonmail.com>
  ;;; Copyright © 2019 David Wilson <david@daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
  ;;;
  ;;; This file is part of GNU Guix.
  ;;;
@@ -4699,3 +4700,45 @@ You can also get metadata about the playing track 
such as the artist and title
  for integration into status line generators or other command-line 
tools.")
      (home-page "https://github.com/altdesktop/playerctl")
      (license license:lgpl3+)))
+
+(define-public avldrums-lv2
+  (package
+    (name "avldrums-lv2")
+    (version "0.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/x42/avldrums.lv2.git")
+            (commit (string-append "v" version))
+            (recursive? #t)))   ; for the 'robtk' submodule
+        (file-name (string-append name "-v" version))
+        (sha256
+          (base32
+            "1z70rcq6z3gkb4fm8dm9hs31bslwr97zdh2n012fzki9b9rdj5qv"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable
+           (lambda _ (setenv "CC" "gcc") #t))
+         (delete 'configure))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("dssi" ,dssi)
+       ("glu" ,glu)
+       ("mesa" ,mesa)
+       ("pango" ,pango)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("lv2" ,lv2)))
+    (home-page "http://x42-plugins.com/x42/x42-avldrums")
+    (synopsis "Drum sample player LV2 plugin dedicated to the AVLinux 
Drumkits")
+    (description "avldrums.lv2 is a drum sample player LV2 plugin 
dedicated to Glen MacArthur's
+AVLdrums. This plugin provides a convenient way to sequence and mix 
MIDI drums and
+comes as two separate drumkits: Black Pearl and Red Zeppelin.")
+    (license license:gpl2+)))
-- 
2.24.0

[bug#38118] [PATCH] gnu: Add avldrums-lv2.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

>  From aae805260db2b830a35459ae219c780e6619cc14 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 09:35:38 +0000
> Subject: [PATCH] gnu: Add avldrums-lv2.
>
> * gnu/packages/music.scm: (avldrums-lv2): New variable.

[...]

> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri
> +          (git-reference
> +            (url "https://github.com/x42/avldrums.lv2.git")
> +            (commit (string-append "v" version))
> +            (recursive? #t)))   ; for the 'robtk' submodule

Can we package robtk separately?

> +    (home-page "http://x42-plugins.com/x42/x42-avldrums")

HTTPS                 ^

> +    (synopsis "Drum sample player LV2 plugin dedicated to the AVLinux 
> Drumkits")
> +    (description "avldrums.lv2 is a drum sample player LV2 plugin 
> dedicated to Glen MacArthur's
> +AVLdrums. This plugin provides a convenient way to sequence and mix 
> MIDI drums and
> +comes as two separate drumkits: Black Pearl and Red Zeppelin.")

Make sure to run 'guix lint' before resending these patches, to catch
infraction issues :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38118] [PATCH] gnu: Add avldrums-lv2.

[Alexandros Theodotou]

[-- Attachment #1.1: Type: text/plain, Size: 1039 bytes --]

Hi Marius,

> > +    (source
> > +      (origin
> > +        (method git-fetch)
> > +        (uri
> > +          (git-reference
> > +            (url "https://github.com/x42/avldrums.lv2.git")
> > +            (commit (string-append "v" version))
> > +            (recursive? #t)))   ; for the 'robtk' submodule
> 
> Can we package robtk separately?

The author expects it to be included in the plugin's sources, much like
DPF (DISTRHO plugin framework) based plugins. I don't know if it is
possible to package it, or at least if any of the plugins using it can
build with a packaged version without modifications. The Redkite
toolkit is a bit better because it outputs a .a library that you can
statically link with instead of having to include its sources, so that
was easy to package.

By the way, Arch does the same thing for this package. I believe Debian
too, but not 100% sure about Debian.

> Make sure to run 'guix lint' before resending these patches, to catch
> infraction issues :-)
Done, thank you!

[-- Attachment #1.2: 0001-gnu-Add-avldrums-lv2.patch --]
[-- Type: text/x-patch, Size: 2367 bytes --]

From e6d30dd87ae46bfba50de7a0e549a13a0368dfcc Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 09:35:38 +0000
Subject: [PATCH] gnu: Add avldrums-lv2.

* gnu/packages/music.scm: (avldrums-lv2): New variable.
---
 gnu/packages/music.scm | 45 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2f023685df..9d858ec6ff 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4737,3 +4737,48 @@ for integration into status line generators or other command-line tools.")
 effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,
 and reverb.")
     (license license:gpl2+)))
+
+(define-public avldrums-lv2
+  (package
+    (name "avldrums-lv2")
+    (version "0.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/x42/avldrums.lv2.git")
+            (commit (string-append "v" version))
+            ;; This plugin expects the robtk submodule's source files to be
+            ;; there in order to build
+            (recursive? #t)))
+        (file-name (string-append name "-v" version))
+        (sha256
+          (base32
+            "1z70rcq6z3gkb4fm8dm9hs31bslwr97zdh2n012fzki9b9rdj5qv"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable
+           (lambda _
+             (setenv "CC" "gcc") #t))
+         (delete 'configure))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("dssi" ,dssi)
+       ("glu" ,glu)
+       ("mesa" ,mesa)
+       ("pango" ,pango)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("lv2" ,lv2)))
+    (home-page "https://x42-plugins.com/x42/x42-avldrums")
+    (synopsis "Drum sample player LV2 plugin dedicated to the AVLinux Drumkits")
+    (description "AVLdrums is a drum sample player LV2 plugin dedicated to Glen
+MacArthur's AVLdrums. This plugin provides a convenient way to sequence and mix
+MIDI drums and comes as two separate drumkits: Black Pearl and Red Zeppelin.")
+    (license license:gpl2+)))
-- 
2.24.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38118] [PATCH] gnu: Add avldrums-lv2.

[Alexandros Theodotou]

[-- Attachment #1.1: Type: text/plain, Size: 58 bytes --]

Oops, copy-paste fail. Added 2 spaces between sentences.

[-- Attachment #1.2: 0001-gnu-Add-avldrums-lv2.patch --]
[-- Type: text/x-patch, Size: 2368 bytes --]

From e6d30dd87ae46bfba50de7a0e549a13a0368dfcc Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 09:35:38 +0000
Subject: [PATCH] gnu: Add avldrums-lv2.

* gnu/packages/music.scm: (avldrums-lv2): New variable.
---
 gnu/packages/music.scm | 45 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2f023685df..9d858ec6ff 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4737,3 +4737,48 @@ for integration into status line generators or other command-line tools.")
 effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,
 and reverb.")
     (license license:gpl2+)))
+
+(define-public avldrums-lv2
+  (package
+    (name "avldrums-lv2")
+    (version "0.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/x42/avldrums.lv2.git")
+            (commit (string-append "v" version))
+            ;; This plugin expects the robtk submodule's source files to be
+            ;; there in order to build
+            (recursive? #t)))
+        (file-name (string-append name "-v" version))
+        (sha256
+          (base32
+            "1z70rcq6z3gkb4fm8dm9hs31bslwr97zdh2n012fzki9b9rdj5qv"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable
+           (lambda _
+             (setenv "CC" "gcc") #t))
+         (delete 'configure))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("dssi" ,dssi)
+       ("glu" ,glu)
+       ("mesa" ,mesa)
+       ("pango" ,pango)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("lv2" ,lv2)))
+    (home-page "https://x42-plugins.com/x42/x42-avldrums")
+    (synopsis "Drum sample player LV2 plugin dedicated to the AVLinux Drumkits")
+    (description "AVLdrums is a drum sample player LV2 plugin dedicated to Glen
+MacArthur's AVLdrums.  This plugin provides a convenient way to sequence and mix
+MIDI drums and comes as two separate drumkits: Black Pearl and Red Zeppelin.")
+    (license license:gpl2+)))
-- 
2.24.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#38118: [PATCH] gnu: Add avldrums-lv2.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> From e6d30dd87ae46bfba50de7a0e549a13a0368dfcc Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 09:35:38 +0000
> Subject: [PATCH] gnu: Add avldrums-lv2.
>
> * gnu/packages/music.scm: (avldrums-lv2): New variable.

Thanks!  Applied with indentation fixes like the other patches.  This is
the last review I had time for today.

In the future, when sending many related patches at once, please send as
a "patch series" (commits on top of each other) instead of individual
patches all branching out from the same commit.

The reason is that applying the first patch to music.scm broke the other
patches for music.scm, because the context became different.  I managed
to work around it with a workflow involving
`git am --show-current-patch | git apply`, but it would be better if all
applied cleanly when committed in order.  :-)

Anyway, impressive first series of patches!  I look forward to the next
one.  ;-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]