* [bug#70309] [PATCH] gnu: simavr: Remove modules from arguments.
@ 2024-04-09 12:37 Jean-Pierre De Jesus DIAZ
2024-04-12 8:25 ` [bug#70309] [PATCH v2] " Dale Mellor
0 siblings, 1 reply; 3+ messages in thread
From: Jean-Pierre De Jesus DIAZ @ 2024-04-09 12:37 UTC (permalink / raw)
To: 70309; +Cc: Jean-Pierre De Jesus DIAZ
* gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
keyword argument as it contains the default modules only.
Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
---
gnu/packages/avr-xyz.scm | 2 --
1 file changed, 2 deletions(-)
diff --git a/gnu/packages/avr-xyz.scm b/gnu/packages/avr-xyz.scm
index e6092df082..86ac941770 100644
--- a/gnu/packages/avr-xyz.scm
+++ b/gnu/packages/avr-xyz.scm
@@ -62,8 +62,6 @@ (define-public simavr
(arguments
(list
#:tests? #f
- #:modules '((guix build gnu-build-system)
- (guix build utils))
#:phases #~(modify-phases %standard-phases
(delete 'configure)
(replace 'check
base-commit: 6d0502f9c3608ffd6b3b3c9b603cb5d4ad14d8c9
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#70309] [PATCH v2] gnu: simavr: Remove modules from arguments.
2024-04-09 12:37 [bug#70309] [PATCH] gnu: simavr: Remove modules from arguments Jean-Pierre De Jesus DIAZ
@ 2024-04-12 8:25 ` Dale Mellor
2024-04-15 9:33 ` bug#70309: " Christopher Baines
0 siblings, 1 reply; 3+ messages in thread
From: Dale Mellor @ 2024-04-12 8:25 UTC (permalink / raw)
To: 70309; +Cc: guix-devel-0brg6a, jean
From: Jean-Pierre De Jesus DIAZ <jean@foundation.xyz>
* gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
keyword argument as it contains the default modules only.
Review:
* Trivial change, totally benign
* lint/build-check/install all clean
Reviewed-by: Dale Mellor <guix-devel-0brg6a@rdmp.org>
Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
---
gnu/packages/avr-xyz.scm | 2 --
1 file changed, 2 deletions(-)
diff --git a/gnu/packages/avr-xyz.scm b/gnu/packages/avr-xyz.scm
index e6092df082..86ac941770 100644
--- a/gnu/packages/avr-xyz.scm
+++ b/gnu/packages/avr-xyz.scm
@@ -62,8 +62,6 @@ (define-public simavr
(arguments
(list
#:tests? #f
- #:modules '((guix build gnu-build-system)
- (guix build utils))
#:phases #~(modify-phases %standard-phases
(delete 'configure)
(replace 'check
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#70309: [PATCH v2] gnu: simavr: Remove modules from arguments.
2024-04-12 8:25 ` [bug#70309] [PATCH v2] " Dale Mellor
@ 2024-04-15 9:33 ` Christopher Baines
0 siblings, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2024-04-15 9:33 UTC (permalink / raw)
To: Dale Mellor; +Cc: 70309-done, jean
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
Dale Mellor <guix-devel-0brg6a@rdmp.org> writes:
> From: Jean-Pierre De Jesus DIAZ <jean@foundation.xyz>
>
> * gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
> keyword argument as it contains the default modules only.
>
> Review:
> * Trivial change, totally benign
> * lint/build-check/install all clean
>
> Reviewed-by: Dale Mellor <guix-devel-0brg6a@rdmp.org>
> Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
> ---
> gnu/packages/avr-xyz.scm | 2 --
> 1 file changed, 2 deletions(-)
Thanks both, I've pushed this to master as
188168ee08f1913b1d11cdef153020c96d3f18fe.
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-15 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-09 12:37 [bug#70309] [PATCH] gnu: simavr: Remove modules from arguments Jean-Pierre De Jesus DIAZ
2024-04-12 8:25 ` [bug#70309] [PATCH v2] " Dale Mellor
2024-04-15 9:33 ` bug#70309: " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).