From: Bruno Victal <mirai@makinata.eu>
To: Arvid Krein <arvidkrein@zedat.fu-berlin.de>
Cc: 62293@debbugs.gnu.org
Subject: [bug#62293] [PATCH] gnu: add pcsc-cyberjack
Date: Mon, 20 Mar 2023 18:44:48 +0000 [thread overview]
Message-ID: <581f51f5-aecc-13db-a499-af8a9e485d39@makinata.eu> (raw)
In-Reply-To: <fab4c4c9-2bb9-0fa2-9050-75ba632b3d8e@zedat.fu-berlin.de>
Hi Arvid,
On 2023-03-20 10:28, Arvid Krein wrote:
> +(define-public pcsc-cyberjack
> + (package
> + (name "pcsc-cyberjack")
> + (version "3.99.5final.sp15")
> + (synopsis "PC/SC driver for cyberJack chipcard readers")
> + (home-page "http://www.reiner-sct.com/")
> + (description
> + "REINER SCT cyberJack USB chipcard reader user space driver
> + This package includes the IFD driver for the cyberJack contactless
> + (RFID) and contact USB chipcard reader.")
How about “This package includes the IFD driver for the cyberJack contactless (RFID) and contact USB chipcard readers.”
> + (source (origin
> + (method url-fetch)
> + (uri
> + "https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5final.SP15.tar.bz2")> + (sha256
> + (base32
> + "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc"))))
How about indenting this as:
(source
(origin
(method url-fetch)
(uri ...)
(sha256
(base32 ...))))
> + (arguments
> + (list #:configure-flags #~(list (string-append "--with-usbdropdir="
> + (ungexp output "out")
> + "/pcsc/drivers")
> + (string-append "--bindir="
> + (ungexp output "tools")
> + "/bin"))
> + #:phases '(modify-phases %standard-phases
> + (add-after 'install 'install-tools
> + (lambda _
> + (invoke "make" "-C" "tools/cjflash" "install"))))))))
Do this:
(arguments
(list
#:configure-flags
#~(list (string-append "--with-usbdropdir=" #$output "/pcsc/drivers")
(string-append "--bindir=" #$output:tools "/bin"))
#:phases
#~(modify-phases %standard-phases
... )))
Also, please reorder the package fields into something like:
(define-public ...
(package
(name ...)
(version ...)
(source ...)
(build-system ...)
(arguments ...)
(native-inputs ...)
(inputs ...)
(outputs ...)
(synopsis ...)
(description ...)
(home-page ...)
(license ...)))
Cheers,
Bruno
next prev parent reply other threads:[~2023-03-20 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 10:28 [bug#62293] [PATCH] gnu: add pcsc-cyberjack Arvid Krein
2023-03-20 18:44 ` Bruno Victal [this message]
2023-03-21 11:26 ` [bug#62293] [PATCH v1] " Arvid Krein
2023-03-22 14:26 ` [bug#62293] [PATCH v2] gnu: add cyberjack-pcsc Arvid Krein
2023-06-02 11:28 ` [bug#62293] [PATCH] gnu: add pcsc-cyberjack 宋文武 via Guix-patches via
2023-06-02 14:45 ` bug#62293: Done: Patch was pushed as commit a7d9cd742c3149bb014db95f88d1158d590bc124 Arvid Krein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581f51f5-aecc-13db-a499-af8a9e485d39@makinata.eu \
--to=mirai@makinata.eu \
--cc=62293@debbugs.gnu.org \
--cc=arvidkrein@zedat.fu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).