From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4EsgJ8ipGGTV0AAASxT56A (envelope-from ) for ; Mon, 20 Mar 2023 19:45:28 +0100 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qCo0JsipGGRrRAEAG6o9tA (envelope-from ) for ; Mon, 20 Mar 2023 19:45:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 482D837545 for ; Mon, 20 Mar 2023 19:45:28 +0100 (CET) Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679337928; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=V3ovVGm53gxHwFJnPWnIK0FCiaf3n2gES4qYHNFg6XA=; b=QcoZakSCKdraVTtBeF83YKhY59SK0uQ6jBJZS6KOx/amUQ4C7SUZJntx7aav3bKCo/47XZ WXJsNmDiWcmKv9mSb5+DwIQVIORJVxFIdWc2S3tmn5Q4sGF5PwDYKHpbudk6B4BRxpcdi9 cplBmHX3j1oBFrpkxK2BBvnWTxh3RQE+zXiZ/BtGgCtx5C0Kkl4jCM8GPSRod8srheVA7H drl0O2Ya9ClfeCfpEj0pbA5WhLvIFT4LCCbjwsz0jyOVtVWwlnR6QLCHG2uFSK3gsZ2HCx MsrTmHsfs1wgtMyhlUhief4A64AY9RnMFfr7XWd2DBrEOQhCM6xuJgr1GjNnfw== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679337928; a=rsa-sha256; cv=none; b=RtONsYRaX2m488vnX3wZrUR62/62O3WgWvvutATkD8OGBlNcQ/9aMygVgHZRQEr/IQ6PIN zhwoaJCrvi0erT8oVAoBLlbl2VRi8147sGNxt1jxmXuLpsbX0B9ORINrO+BENjdgAUpIiM tKbDcrhyX65E/4BSe6TPM6Fr6bSWfY46I04pC9V2+yOMZ0KDvOei3qsmCmkQ+aCtQGJX5U X5xSndEVOnxZqPXLEgrhXHmr3kiQxadUgYjEC1RiBh7gXHgOaHHYrZJdEZZCnxenhoA/rA OtgkWTX1Qg5kTwMEOnYhPCLlosFBTDavNG3ZW6dwsXduTabmkyN6vP+Ld0F5qw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peKVE-0003JO-Oc; Mon, 20 Mar 2023 14:45:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKVD-0003Iu-Fv for guix-patches@gnu.org; Mon, 20 Mar 2023 14:45:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peKVC-00053P-Uc for guix-patches@gnu.org; Mon, 20 Mar 2023 14:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peKVC-00023d-N6 for guix-patches@gnu.org; Mon, 20 Mar 2023 14:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62293] [PATCH] gnu: add pcsc-cyberjack Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Mar 2023 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62293 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arvid Krein Cc: 62293@debbugs.gnu.org Received: via spool by 62293-submit@debbugs.gnu.org id=B62293.16793378997875 (code B ref 62293); Mon, 20 Mar 2023 18:45:02 +0000 Received: (at 62293) by debbugs.gnu.org; 20 Mar 2023 18:44:59 +0000 Received: from localhost ([127.0.0.1]:56805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKV8-00022w-SJ for submit@debbugs.gnu.org; Mon, 20 Mar 2023 14:44:59 -0400 Received: from smtpm3.myservices.hosting ([185.26.105.234]:58694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKV6-00022o-T6 for 62293@debbugs.gnu.org; Mon, 20 Mar 2023 14:44:58 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm3.myservices.hosting (Postfix) with ESMTP id 69FB220EB8; Mon, 20 Mar 2023 19:44:54 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 2109D80098; Mon, 20 Mar 2023 19:44:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SNiFKyzkZYjL; Mon, 20 Mar 2023 19:44:53 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id CB1C18009B; Mon, 20 Mar 2023 19:44:52 +0100 (CET) Message-ID: <581f51f5-aecc-13db-a499-af8a9e485d39@makinata.eu> Date: Mon, 20 Mar 2023 18:44:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US References: From: Bruno Victal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 482D837545 X-Spam-Score: -4.05 X-Migadu-Spam-Score: -4.05 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: lrCRLcWMSCfm Hi Arvid, On 2023-03-20 10:28, Arvid Krein wrote: > +(define-public pcsc-cyberjack > +  (package > +    (name "pcsc-cyberjack") > +    (version "3.99.5final.sp15") > +    (synopsis "PC/SC driver for cyberJack chipcard readers") > +    (home-page "http://www.reiner-sct.com/") > +    (description > +     "REINER SCT cyberJack USB chipcard reader user space driver > + This package includes the IFD driver for the cyberJack contactless > + (RFID) and contact USB chipcard reader.") How about “This package includes the IFD driver for the cyberJack contactless (RFID) and contact USB chipcard readers.” > +    (source (origin > +              (method url-fetch) > +              (uri > + "https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5final.SP15.tar.bz2")> +              (sha256 > +               (base32 > + "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc")))) How about indenting this as: (source (origin (method url-fetch) (uri ...) (sha256 (base32 ...)))) > +    (arguments > +     (list #:configure-flags #~(list (string-append "--with-usbdropdir=" > +                                                    (ungexp output "out") > + "/pcsc/drivers") > +                                     (string-append "--bindir=" > +                                                    (ungexp output "tools") > +                                                    "/bin")) > +           #:phases '(modify-phases %standard-phases > +                       (add-after 'install 'install-tools > +                         (lambda _ > +                           (invoke "make" "-C" "tools/cjflash" "install")))))))) Do this: (arguments (list #:configure-flags #~(list (string-append "--with-usbdropdir=" #$output "/pcsc/drivers") (string-append "--bindir=" #$output:tools "/bin")) #:phases #~(modify-phases %standard-phases ... ))) Also, please reorder the package fields into something like: (define-public ... (package (name ...) (version ...) (source ...) (build-system ...) (arguments ...) (native-inputs ...) (inputs ...) (outputs ...) (synopsis ...) (description ...) (home-page ...) (license ...))) Cheers, Bruno