unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28421@debbugs.gnu.org
Subject: [bug#28421] [PATCH] gnu: Add uim.
Date: Thu, 14 Sep 2017 05:19:04 +0530	[thread overview]
Message-ID: <554652da.AEQAQDMYN5IAAAAAAAAAAAPqZPMAAAACwQwAAAAAAAW9WABZucP6@mailjet.com> (raw)
In-Reply-To: <87ingoyt3a.fsf@gnu.org>


>> * gnu/packages/xorg.scm (uim): New variable.
>
> [...]
>
>> +    (native-inputs
>> +     `(("anthy" ,anthy)
>> +       ("emacs" ,emacs-minimal)
>> +       ("gtk+" ,gtk+)
>> +       ("gtk+" ,gtk+-2)
>> +       ("intltool" ,intltool)
>> +       ("pkg-config" ,pkg-config)
>> +       ("qt" ,qt-4)))
>
> GTK+ and Qt are native inputs?

The package has gtk and qt programs to set uim preferences. At least,
those must need gtk and qt as inputs. So, you're right -- gtk and qt
should be inputs, not native inputs.

Also, I think anthy should be an input, not a native input.

> Also, is Qt 5 supported?  That would be best.

It looks there is no release yet that supports Qt 5, though there is
support in the master branch.

https://github.com/uim/uim/issues/61

> Besides, would it make sense to split the thing into several outputs to
> avoid the huge dependencies?

I don't know if it's a good idea to split the package into a gtk output
and a qt output. What if the user needs multilingual input in both gtk
and qt programs?

Also, this package can be built in many different ways -- with and
without the gtk and qt helper programs (for uim preferences), with and
without anthy support, with and without m17nlib support, etc. I don't
know where to draw the line, and choose only a few outputs. The
configure flags and dependencies, as they stand now, I copied from Arch
Linux.

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/uim

> I’m not clear if it’s a later above Qt/GTK+ or something entirely
> separate?

I am not entirely sure either but I think at least the core library
(libuim) is entirely separate.

> Apart from that, LGTM with phases that return #t as you noted.

Will send an updated patch with all changes discussed.

  reply	other threads:[~2017-09-13 23:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 20:22 [bug#28421] [PATCH] gnu: Add uim Arun Isaac
2017-09-12 12:55 ` Ludovic Courtès
2017-09-13 23:49   ` Arun Isaac [this message]
     [not found]   ` <82a195b0.AEQAQDMYN5MAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZucP6@mailjet.com>
2017-09-14  7:00     ` Ludovic Courtès
2017-09-23  6:50   ` Arun Isaac
2017-09-23 16:35     ` Ludovic Courtès
2017-09-23 19:05       ` Arun Isaac
     [not found]       ` <15afe43a.AEQAQk2GuKIAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZxrCd@mailjet.com>
2017-09-24 19:48         ` Ludovic Courtès
2017-09-26  3:23 ` [bug#28421] [PATCH] gnu: Add uim, uim-gtk and uim-qt Arun Isaac
     [not found] <20170911202204.23647-1-arunisaac@systemreboot.net>
2017-09-12  7:34 ` [bug#28421] [PATCH] gnu: Add uim Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554652da.AEQAQDMYN5IAAAAAAAAAAAPqZPMAAAACwQwAAAAAAAW9WABZucP6@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=28421@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).