From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsHPx-0007Ci-TB for guix-patches@gnu.org; Wed, 13 Sep 2017 19:50:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsHPu-0006Mh-Qy for guix-patches@gnu.org; Wed, 13 Sep 2017 19:50:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58645) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsHPu-0006MN-NN for guix-patches@gnu.org; Wed, 13 Sep 2017 19:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dsHPt-0000NW-V0 for guix-patches@gnu.org; Wed, 13 Sep 2017 19:50:01 -0400 Subject: [bug#28421] [PATCH] gnu: Add uim. Resent-Message-ID: Message-Id: <554652da.AEQAQDMYN5IAAAAAAAAAAAPqZPMAAAACwQwAAAAAAAW9WABZucP6@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Thu, 14 Sep 2017 05:19:04 +0530 In-reply-to: <87ingoyt3a.fsf@gnu.org> References: <87ingoyt3a.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28421@debbugs.gnu.org >> * gnu/packages/xorg.scm (uim): New variable. > > [...] > >> + (native-inputs >> + `(("anthy" ,anthy) >> + ("emacs" ,emacs-minimal) >> + ("gtk+" ,gtk+) >> + ("gtk+" ,gtk+-2) >> + ("intltool" ,intltool) >> + ("pkg-config" ,pkg-config) >> + ("qt" ,qt-4))) > > GTK+ and Qt are native inputs? The package has gtk and qt programs to set uim preferences. At least, those must need gtk and qt as inputs. So, you're right -- gtk and qt should be inputs, not native inputs. Also, I think anthy should be an input, not a native input. > Also, is Qt 5 supported? That would be best. It looks there is no release yet that supports Qt 5, though there is support in the master branch. https://github.com/uim/uim/issues/61 > Besides, would it make sense to split the thing into several outputs to > avoid the huge dependencies? I don't know if it's a good idea to split the package into a gtk output and a qt output. What if the user needs multilingual input in both gtk and qt programs? Also, this package can be built in many different ways -- with and without the gtk and qt helper programs (for uim preferences), with and without anthy support, with and without m17nlib support, etc. I don't know where to draw the line, and choose only a few outputs. The configure flags and dependencies, as they stand now, I copied from Arch Linux. https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/uim > I’m not clear if it’s a later above Qt/GTK+ or something entirely > separate? I am not entirely sure either but I think at least the core library (libuim) is entirely separate. > Apart from that, LGTM with phases that return #t as you noted. Will send an updated patch with all changes discussed.