* [bug#33514] shepherd: fix bootstrap/build from git
@ 2018-11-26 14:43 Florian Dold
2018-11-26 16:31 ` bug#33514: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Florian Dold @ 2018-11-26 14:43 UTC (permalink / raw)
To: 33514
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
Hi all,
the Shepherd currently does not build from a clean git repository (on
GuixSD in a shepherd environment), as "autoreconf -ifv" does not create
missing files related to gettext unless the version is specified.
This tiny patch fixes the gettext version and allows bootstrapping to
work from a clean git checkout.
By the way, shouldn't there also be a "./bootstrap" shell script, as is
customary in a lot of projects including Guix?
Cheers,
Florian
[-- Attachment #2: 0001-build-set-gettext-version-to-make-bootstrap-work.patch --]
[-- Type: text/x-patch, Size: 610 bytes --]
From a835aa7295d20ddd207ec44401a044be631fe3a4 Mon Sep 17 00:00:00 2001
From: Florian Dold <flo@dold.me>
Date: Mon, 26 Nov 2018 12:59:37 +0100
Subject: [PATCH] build: set gettext version to make bootstrap work
* configure.ac: add AM_GNU_GETTEXT_VERSION
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 79483b4..3877913 100644
--- a/configure.ac
+++ b/configure.ac
@@ -15,6 +15,7 @@ dnl Enable silent rules by default.
AM_SILENT_RULES([yes])
AM_GNU_GETTEXT([external])
+AM_GNU_GETTEXT_VERSION([0.19])
AC_CANONICAL_HOST
AC_PROG_MKDIR_P
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#33514: shepherd: fix bootstrap/build from git
2018-11-26 14:43 [bug#33514] shepherd: fix bootstrap/build from git Florian Dold
@ 2018-11-26 16:31 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2018-11-26 16:31 UTC (permalink / raw)
To: Florian Dold; +Cc: 33514-done
Hi Florian,
Florian Dold <florian.dold@gmail.com> skribis:
> the Shepherd currently does not build from a clean git repository (on
> GuixSD in a shepherd environment), as "autoreconf -ifv" does not create
> missing files related to gettext unless the version is specified.
>
> This tiny patch fixes the gettext version and allows bootstrapping to
> work from a clean git checkout.
Good catch, applied!
> By the way, shouldn't there also be a "./bootstrap" shell script, as is
> customary in a lot of projects including Guix?
FWIW I prefer to just run “autoreconf -vfi”, which is what ‘./bootstrap’
does in Guix. ‘./bootstrap’ scripts tend to have different semantics
between projects (some run ‘./configure’, some don’t, etc.) so I like to
keep it simple.
Thoughts?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-26 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-26 14:43 [bug#33514] shepherd: fix bootstrap/build from git Florian Dold
2018-11-26 16:31 ` bug#33514: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).