From: Maxime Devos <maximedevos@telenet.be>
To: Vivien Kraus <vivien@planete-kraus.eu>, 50425@debbugs.gnu.org
Subject: [bug#50425] [PATCH] gnu: Add minetest-advtrains.
Date: Fri, 10 Sep 2021 12:25:30 +0200 [thread overview]
Message-ID: <4e2998599854e1f51347800600c97bf840bf97ba.camel@telenet.be> (raw)
In-Reply-To: <e7485e6dbbafc68831f37ebd09062f85fd734896.camel@planete-kraus.eu>
[-- Attachment #1: Type: text/plain, Size: 2463 bytes --]
Hi,
Presuming minetest-advtrains and minetest-basic-trains build and actually
work, this largely LGTM. I looked at the source code of advtrains and basic_trains
and didn't find anything ‘suspicious’ (e.g. malware, though mods are sandboxed
so they would have a hard time doing anything bad).
minetest-advtrains and minetest-basic-trains are separate packages that
can be added separately, so theoretically, they should be added in separate
patches:
From (guix)Submitting Patches:
11. Verify that your patch contains only one set of related changes.
Bundling unrelated changes together makes reviewing harder and
slower.
(minetest-advtrains seems rather useless without minetest-basic-trains though,
so maybe it's ok?)
Vivien Kraus schreef op di 07-09-2021 om 12:45 [+0200]:
> +(define-public minetest-advtrains
> + (package
> + (name "minetest-advtrains")
> + (version "2.3.1")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.bananach.space/advtrains.git")
> + (commit "release-2.3.1")))
> + (sha256
> + (base32 "1ijqlchh269jpvmgmdmdvy3nsnk0bszkvvcqk6vaysvxam695ggw"))
> + (file-name (git-file-name name version))))
> + (build-system minetest-mod-build-system)
> + (home-page "http://advtrains.de/")
> + (synopsis
> + "Adds good-looking, realistic trains with realistic rails.")
> + (description
> + "This mod features realistic trains and various equipment for railways, with a focus on automated train operation.
Aren't the actual trains added with minetest-basic-trains?
Maybe replace ‘realistic trains’ -> ‘realistic train system’,
and note that minetest-basic-trains contains the actual train models.
I think a linter will have something to say about long lines here
(try "./pre-inst-env guix lint minetest-advtrains minetest-basic-trains").
> +
> +Main features:
> +
> +@itemize
> +@item
> +almost-realistic tracks with actual curves and switches;
> +@item
> +railway signals, controllable by various means;
> +@item
> +ATC: simple, command-like automatic train control;
> +@item
> +LuaATC: Powerful Lua-scripted automatic train operation (requires some programming knowledge);
> +@item
> +an interlocking system, featuring track sections, routes and automatic stopping before signals.
> +@end itemize")
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-09-10 10:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 8:53 [bug#50425] [PATCH] gnu: Add minetest-advtrains Vivien Kraus via Guix-patches via
2021-09-06 11:02 ` Maxime Devos
2021-09-06 11:03 ` Maxime Devos
2021-09-06 11:17 ` Maxime Devos
2021-09-06 11:56 ` Vivien Kraus via Guix-patches via
2021-09-07 10:20 ` Maxime Devos
2021-09-07 10:45 ` Vivien Kraus via Guix-patches via
2021-09-10 10:25 ` Maxime Devos [this message]
2021-09-10 12:46 ` Vivien Kraus via Guix-patches via
2021-09-10 16:26 ` Maxime Devos
2021-09-16 8:03 ` Xinglu Chen
2021-09-16 8:36 ` Vivien Kraus via Guix-patches via
2021-09-16 8:39 ` Vivien Kraus via Guix-patches via
2021-09-16 10:55 ` Maxime Devos
2021-09-16 20:44 ` bug#50425: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e2998599854e1f51347800600c97bf840bf97ba.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=50425@debbugs.gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).