From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mZkHO9wyO2EGFgEAgWs5BA (envelope-from ) for ; Fri, 10 Sep 2021 12:26:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +DccNtwyO2EABwAA1q6Kng (envelope-from ) for ; Fri, 10 Sep 2021 10:26:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 75C66911F for ; Fri, 10 Sep 2021 12:26:36 +0200 (CEST) Received: from localhost ([::1]:48104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOdjv-0003Ro-ID for larch@yhetil.org; Fri, 10 Sep 2021 06:26:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOdjO-0003Qb-Qf for guix-patches@gnu.org; Fri, 10 Sep 2021 06:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOdjO-0008HA-Gp for guix-patches@gnu.org; Fri, 10 Sep 2021 06:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOdjO-0007zl-D5 for guix-patches@gnu.org; Fri, 10 Sep 2021 06:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50425] [PATCH] gnu: Add minetest-advtrains. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Sep 2021 10:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50425 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vivien Kraus , 50425@debbugs.gnu.org Received: via spool by 50425-submit@debbugs.gnu.org id=B50425.163126954630704 (code B ref 50425); Fri, 10 Sep 2021 10:26:02 +0000 Received: (at 50425) by debbugs.gnu.org; 10 Sep 2021 10:25:46 +0000 Received: from localhost ([127.0.0.1]:36922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOdj8-0007z9-0k for submit@debbugs.gnu.org; Fri, 10 Sep 2021 06:25:46 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:34806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOdj5-0007yx-1y for 50425@debbugs.gnu.org; Fri, 10 Sep 2021 06:25:44 -0400 Received: from butterfly.local ([213.251.110.34]) by andre.telenet-ops.be with bizsmtp id sARc2500U0kaXst01ARfdm; Fri, 10 Sep 2021 12:25:41 +0200 Message-ID: <4e2998599854e1f51347800600c97bf840bf97ba.camel@telenet.be> From: Maxime Devos Date: Fri, 10 Sep 2021 12:25:30 +0200 In-Reply-To: References: <87a6kqm6f3.fsf@planete-kraus.eu> <031b52f03cac2218f9250882e5b8d3fe56cc7f49.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-O3Mr+bjD+sINfHtWWdML" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1631269541; bh=aZVLV084YL1xFCB0CiTtLJISaPVO2x6tko5KgvSS+Rg=; h=Subject:From:To:Date:In-Reply-To:References; b=aKcvRsS5GApGxoA3rIkiQzdBn97+3RlWv2F1xjZ+h6bUzsc0SK7h19n9PwYj2uYwC TfaD7GQv/sl2l0noilN/z2aWvqX7bFYPRORIlI6CS5vJ8sGYlWMmBtthg9Nfi44451 9dqqV/4rym3ts5+EnP6zknfKox22ZV86T17GLxx/0iPPSMp5LwXmjS1g6IAfyBYP+F xmf5C68mSc/lURP4IDln/t4SXMEjpJlqxwmfdFgV0bO63xF8Y3jA/QF21OmQZXMct4 97Sbiy4SS+8A9zSPya0uBiB1IzOfesKgCg9kuVa8jev330bTavSzFOn/BSNTXqUrfR Yq+7d/8op0JSQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631269596; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=aZVLV084YL1xFCB0CiTtLJISaPVO2x6tko5KgvSS+Rg=; b=qqFDwnfteI4i9cdT7n8ykziL7LvlUoCdZUyU94ekt1A5h8wEVKJMhI9x6RgI+h3MehJ5Ix Y+LxLBxL5YQwTB/EyI6iCzNf21LAoUPe7jBqp9JFSwf7URDlxn2zxHoe3hbHtmxSgWWRrU rVXI4ZGDjIN1Nj3sfSLIAzaAUtfQ99HyrNMoWNsGhUywA2EK7eX9omVu3myGAuA1NFOQVB iHzq4t7YK8/mN1TjJiRzaYZejwEkXA1XQaoMKc4Vh7sMfaTwl3O7Q3Q15e9qPnSVt0ScJr GN5u92Y0DjKq62xeDR7eCoF26UWGZHonxALXjtynn/aEI3goyt1u0yfUAwSvCA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631269596; a=rsa-sha256; cv=none; b=HD30WvG94qAwFRj2Ixhj/Y9qlzRMq2fEDQaYrYs5wu+EknNm/w+db5DorjltRBqxzYvUJL EqqwNmDZ95ePZkaKm6lc6Wx0my6DhDqlCrtyhPmPQ3fjk7Z8sC5KmWMUhxw7swoFoBId4g TWKby0j2MUjxF/eacDwVDApflz2V8xfD9wZqvk1HjpZW91IytGpwedyPYCtnFADkfLySQv f+Zmv8ViLfR3EvR14Ly47oyPAnwJOMAZt3AP+T+T7k4YgBbeAQv8y3zec7YfOuIsR86Mr4 +hq8avbRXx9V1ijvw0i4+q98lPf5NaVfdG8l04SaZt/HAay1qe4wdz0g6lzvqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=aKcvRsS5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=aKcvRsS5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 75C66911F X-Spam-Score: -3.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: oiakOIpobPsR --=-O3Mr+bjD+sINfHtWWdML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Presuming minetest-advtrains and minetest-basic-trains build and actually work, this largely LGTM. I looked at the source code of advtrains and basi= c_trains and didn't find anything =E2=80=98suspicious=E2=80=99 (e.g. malware, though= mods are sandboxed so they would have a hard time doing anything bad).=20 minetest-advtrains and minetest-basic-trains are separate packages that can be added separately, so theoretically, they should be added in separate patches: =46rom (guix)Submitting Patches: 11. Verify that your patch contains only one set of related changes. Bundling unrelated changes together makes reviewing harder and slower. (minetest-advtrains seems rather useless without minetest-basic-trains thou= gh, so maybe it's ok?) Vivien Kraus schreef op di 07-09-2021 om 12:45 [+0200]: > +(define-public minetest-advtrains > + (package > + (name "minetest-advtrains") > + (version "2.3.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.bananach.space/advtrains.git") > + (commit "release-2.3.1"))) > + (sha256 > + (base32 "1ijqlchh269jpvmgmdmdvy3nsnk0bszkvvcqk6vaysvxam695ggw")) > + (file-name (git-file-name name version)))) > + (build-system minetest-mod-build-system) > + (home-page "http://advtrains.de/") > + (synopsis > + "Adds good-looking, realistic trains with realistic rails.") > + (description > + "This mod features realistic trains and various equipment for railw= ays, with a focus on automated train operation. Aren't the actual trains added with minetest-basic-trains? Maybe replace =E2=80=98realistic trains=E2=80=99 -> =E2=80=98realistic trai= n system=E2=80=99, and note that minetest-basic-trains contains the actual train models. I think a linter will have something to say about long lines here (try "./pre-inst-env guix lint minetest-advtrains minetest-basic-trains"). > + > +Main features: > + > +@itemize > +@item > +almost-realistic tracks with actual curves and switches; > +@item > +railway signals, controllable by various means; > +@item > +ATC: simple, command-like automatic train control; > +@item > +LuaATC: Powerful Lua-scripted automatic train operation (requires some p= rogramming knowledge); > +@item > +an interlocking system, featuring track sections, routes and automatic s= topping before signals. > +@end itemize") Greetings, Maxime. --=-O3Mr+bjD+sINfHtWWdML Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYTsymhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mXaAP9qQDgfB7SAjrbIaTK/91EUT0wc S5ORvp0NR66n0CAmNwD8CkCWqnNHV5oe33T0VOqBreKc/hNLxpgXuieFainPUQI= =U2os -----END PGP SIGNATURE----- --=-O3Mr+bjD+sINfHtWWdML--