From: Eric Bavier <bavier@posteo.net>
To: 39858@debbugs.gnu.org
Subject: [bug#39858] [PATCH] gnu: ccache: Update to 3.7.7.
Date: Mon, 02 Mar 2020 00:49:18 -0600 [thread overview]
Message-ID: <4651422f198af7325b5621b4402eb875@posteo.net> (raw)
In-Reply-To: <CAEwRq=peNMiFf5rzKPUDhNFnz27Uko-0t2f=Wmc33qxaPree2w@mail.gmail.com>
Hi Vincent, thanks for the patch, some comments below:
On 01.03.2020 11:48, Vincent Legoll wrote:
> lightly tested: cache hits on trivial .c file compilation
And the tests still pass ;)
> Trivial ./etc/indent-code.el housekeeping
Could you move this to a separate patch, please?
> From 9718baa06727eb515030cf7b617a10e9fab8052a Mon Sep 17 00:00:00 2001
> From: Vincent Legoll <vincent.legoll@gmail.com>
> Date: Sun, 1 Mar 2020 17:59:10 +0100
> Subject: [PATCH] gnu: ccache: Update to 3.7.7.
>
> * gnu/packages/ccache.scm (ccache): Update to 3.7.7.
> * gnu/packages/ccache.scm (ccache): Update source to github
> * gnu/packages/ccache.scm (ccache): Update home-page to ccache.dev
> * gnu/packages/ccache.scm (ccache): Add native inputs: asciidoc
> autoconf gperf
> * gnu/packages/ccache.scm (ccache): Reindent arguments
Check the manual and other commit messages for formatting. In
particular, the file name only needs to be mentioned once, and the
affected sections are mentioned in square brackets before the comment.
> ---
> gnu/packages/ccache.scm | 33 +++++++++++++++++++++------------
> 1 file changed, 21 insertions(+), 12 deletions(-)
> ...
> - (method url-fetch)
> - (uri (string-append "https://www.samba.org/ftp/ccache/ccache-"
> - version ".tar.xz"))
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/ccache/ccache.git")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> (sha256
> - (base32 "07wv75xdcxpdkfsz9h5ffrm8pjbvr1dh6wnb02nyzz18cdbjkcd6"))))
> + (base32 "1s8mq832chk95wa5qwaalralwv3ln1m931nrgd9a4gi19lg55zln"))))
> (build-system gnu-build-system)
I think we can actually stick with the tarball available on the github
release page:
https://github.com/ccache/ccache/releases/download/v3.7.7/ccache-3.7.7.tar.xz
which is already bootstrapped.
> (native-inputs `(("perl" ,perl) ; for test/run
> + ("asciidoc" ,asciidoc)
> + ("autoconf" ,autoconf)
> + ("gperf" ,gperf)
Using the distribution tarball should prevent needing to add these
inputs.
> (description
> "Ccache is a compiler cache. It speeds up recompilation by caching
It seems based on the release notes that we also need to remove the
mention of Fortran 77 support in the description.
Could you send updated patches?
Cheers,
`~Eric
next prev parent reply other threads:[~2020-03-02 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 17:48 [bug#39858] [PATCH] gnu: ccache: Update to 3.7.7 Vincent Legoll
2020-03-02 6:49 ` Eric Bavier [this message]
[not found] ` <6be6367ceeabbcbd3dc812883eced66c@posteo.net>
2020-03-02 7:44 ` Vincent Legoll
2020-03-04 17:53 ` [bug#39858] [PATCH, v2, 1/2] " Vincent Legoll
2020-03-07 21:19 ` bug#39858: " Ludovic Courtès
2020-03-04 17:54 ` [bug#39858] [PATCH, v2, 2/2] gnu: ccache: Fix indentation Vincent Legoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4651422f198af7325b5621b4402eb875@posteo.net \
--to=bavier@posteo.net \
--cc=39858@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).