From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54390) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8etv-00031l-2y for guix-patches@gnu.org; Mon, 02 Mar 2020 01:50:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8ett-0001mO-UX for guix-patches@gnu.org; Mon, 02 Mar 2020 01:50:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j8ett-0001mD-Kg for guix-patches@gnu.org; Mon, 02 Mar 2020 01:50:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j8ett-00020I-Hf for guix-patches@gnu.org; Mon, 02 Mar 2020 01:50:01 -0500 Subject: [bug#39858] [PATCH] gnu: ccache: Update to 3.7.7. Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 02 Mar 2020 00:49:18 -0600 From: Eric Bavier In-Reply-To: References: Message-ID: <4651422f198af7325b5621b4402eb875@posteo.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 39858@debbugs.gnu.org Hi Vincent, thanks for the patch, some comments below: On 01.03.2020 11:48, Vincent Legoll wrote: > lightly tested: cache hits on trivial .c file compilation And the tests still pass ;) > Trivial ./etc/indent-code.el housekeeping Could you move this to a separate patch, please? > From 9718baa06727eb515030cf7b617a10e9fab8052a Mon Sep 17 00:00:00 2001 > From: Vincent Legoll > Date: Sun, 1 Mar 2020 17:59:10 +0100 > Subject: [PATCH] gnu: ccache: Update to 3.7.7. > > * gnu/packages/ccache.scm (ccache): Update to 3.7.7. > * gnu/packages/ccache.scm (ccache): Update source to github > * gnu/packages/ccache.scm (ccache): Update home-page to ccache.dev > * gnu/packages/ccache.scm (ccache): Add native inputs: asciidoc > autoconf gperf > * gnu/packages/ccache.scm (ccache): Reindent arguments Check the manual and other commit messages for formatting. In particular, the file name only needs to be mentioned once, and the affected sections are mentioned in square brackets before the comment. > --- > gnu/packages/ccache.scm | 33 +++++++++++++++++++++------------ > 1 file changed, 21 insertions(+), 12 deletions(-) > ... > - (method url-fetch) > - (uri (string-append "https://www.samba.org/ftp/ccache/ccache-" > - version ".tar.xz")) > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ccache/ccache.git") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > (sha256 > - (base32 "07wv75xdcxpdkfsz9h5ffrm8pjbvr1dh6wnb02nyzz18cdbjkcd6")))) > + (base32 "1s8mq832chk95wa5qwaalralwv3ln1m931nrgd9a4gi19lg55zln")))) > (build-system gnu-build-system) I think we can actually stick with the tarball available on the github release page: https://github.com/ccache/ccache/releases/download/v3.7.7/ccache-3.7.7.tar.xz which is already bootstrapped. > (native-inputs `(("perl" ,perl) ; for test/run > + ("asciidoc" ,asciidoc) > + ("autoconf" ,autoconf) > + ("gperf" ,gperf) Using the distribution tarball should prevent needing to add these inputs. > (description > "Ccache is a compiler cache. It speeds up recompilation by caching It seems based on the release notes that we also need to remove the mention of Fortran 77 support in the description. Could you send updated patches? Cheers, `~Eric