unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#29058] [PATCH] tests: install: Estimate the installation system disk size.
@ 2017-10-29 18:52 Hartmut Goebel
  2017-10-29 21:33 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Hartmut Goebel @ 2017-10-29 18:52 UTC (permalink / raw)
  To: 29058

1500 MiB are too small for a current system, thus use let
system-disk-image estimate the required size.

* gnu/tests/install.scm: (run-install): Pass "#:disk-image-size
  'guess" to system-disk-image.
---
 gnu/tests/install.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
index d0cc08f43..a80c520ec 100644
--- a/gnu/tests/install.scm
+++ b/gnu/tests/install.scm
@@ -219,7 +219,7 @@ packages defined in installation-os."
                        (image  (system-disk-image
                                 (operating-system-with-gc-roots
                                  os (list target))
-                                #:disk-image-size (* 1500 MiB)
+                                #:disk-image-size 'guess
                                 #:file-system-type
                                 installation-disk-image-file-system-type)))
     (define install
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#29058] [PATCH] tests: install: Estimate the installation system disk size.
  2017-10-29 18:52 [bug#29058] [PATCH] tests: install: Estimate the installation system disk size Hartmut Goebel
@ 2017-10-29 21:33 ` Ludovic Courtès
  2017-10-30  8:14   ` bug#29058: " Hartmut Goebel
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2017-10-29 21:33 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 29058

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> 1500 MiB are too small for a current system, thus use let
> system-disk-image estimate the required size.
>
> * gnu/tests/install.scm: (run-install): Pass "#:disk-image-size
>   'guess" to system-disk-image.

Good idea, LGTM!

Thanks,
Ludo'.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#29058: [PATCH] tests: install: Estimate the installation system disk size.
  2017-10-29 21:33 ` Ludovic Courtès
@ 2017-10-30  8:14   ` Hartmut Goebel
  0 siblings, 0 replies; 3+ messages in thread
From: Hartmut Goebel @ 2017-10-30  8:14 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 29058-close

Pushed as 91496dfc9a4c3a708b5c2604fad3e42e101fea04
after fixing a typo in the commit message,

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-30  8:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-29 18:52 [bug#29058] [PATCH] tests: install: Estimate the installation system disk size Hartmut Goebel
2017-10-29 21:33 ` Ludovic Courtès
2017-10-30  8:14   ` bug#29058: " Hartmut Goebel

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).