From: Maxime Devos <maximedevos@telenet.be>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 47364@debbugs.gnu.org
Subject: [bug#47364] [PATCH 2/2] services: slim: Add pam-gnupg support.
Date: Wed, 24 Mar 2021 21:14:47 +0100 [thread overview]
Message-ID: <45158737893d2ef4b3a8d8e5dd04523aecb8e552.camel@telenet.be> (raw)
In-Reply-To: <87ft0ks58u.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On Wed, 2021-03-24 at 22:48 +0300, Oleg Pykhalov wrote:
> +/proc/self/loginuid, which the libc 'getlogin' function relies on. When
> +GNUPG? is true, require the 'pam_gnupg.so' module; that module hands over
> +login password to 'gpg-agent'."
Linguistic nitpick:
There seems to be an article missing before "login password".
Maybe add "the".
Also, ideally speaking, there would be a system test in "gnu/tests/" for
this new functionality.
Otherwise no comments, seems good to me to go into the repo
though maybe someone else wants to comment as well.
Greetings,
Maxime
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-03-24 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 16:49 [bug#47364] [PATCH 0/2] Add pam-gnupg and PAM rules for SLiM Oleg Pykhalov
2021-03-24 16:52 ` [bug#47364] [PATCH 1/2] gnu: Add pam-gnupg Oleg Pykhalov
2021-03-24 16:52 ` [bug#47364] [PATCH 2/2] services: slim: Add pam-gnupg support Oleg Pykhalov
2021-03-24 19:22 ` Maxime Devos
2021-03-24 19:48 ` Oleg Pykhalov
2021-03-24 20:14 ` Maxime Devos [this message]
2021-08-16 22:13 ` bug#47364: [PATCH 0/2] Add pam-gnupg and PAM rules for SLiM Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45158737893d2ef4b3a8d8e5dd04523aecb8e552.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=47364@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).