From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aCdTJ6miW2CR2gAAgWs5BA (envelope-from ) for ; Wed, 24 Mar 2021 21:35:53 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KOTzIqmiW2CUVgAAbx9fmQ (envelope-from ) for ; Wed, 24 Mar 2021 20:35:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1BD79125F2 for ; Wed, 24 Mar 2021 21:35:53 +0100 (CET) Received: from localhost ([::1]:34302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPAEK-0001sQ-19 for larch@yhetil.org; Wed, 24 Mar 2021 16:35:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP9uA-0003B2-BJ for guix-patches@gnu.org; Wed, 24 Mar 2021 16:15:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lP9uA-0003QX-3G for guix-patches@gnu.org; Wed, 24 Mar 2021 16:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lP9u9-0003is-UJ for guix-patches@gnu.org; Wed, 24 Mar 2021 16:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47364] [PATCH 2/2] services: slim: Add pam-gnupg support. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Mar 2021 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47364 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 47364@debbugs.gnu.org Received: via spool by 47364-submit@debbugs.gnu.org id=B47364.161661689914285 (code B ref 47364); Wed, 24 Mar 2021 20:15:01 +0000 Received: (at 47364) by debbugs.gnu.org; 24 Mar 2021 20:14:59 +0000 Received: from localhost ([127.0.0.1]:36152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lP9u6-0003iL-Mp for submit@debbugs.gnu.org; Wed, 24 Mar 2021 16:14:58 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:48898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lP9u3-0003i8-Ap for 47364@debbugs.gnu.org; Wed, 24 Mar 2021 16:14:56 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by xavier.telenet-ops.be with bizsmtp id kLEt240060mfAB401LEtAN; Wed, 24 Mar 2021 21:14:53 +0100 Message-ID: <45158737893d2ef4b3a8d8e5dd04523aecb8e552.camel@telenet.be> From: Maxime Devos Date: Wed, 24 Mar 2021 21:14:47 +0100 In-Reply-To: <87ft0ks58u.fsf@gmail.com> References: <20210324165233.28428-1-go.wigust@gmail.com> <20210324165233.28428-2-go.wigust@gmail.com> <6ca83b55b46c4677a45fd0e026ac14880093ea7f.camel@telenet.be> <87ft0ks58u.fsf@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-tMH3ZPrUwOGecO07Ewyp" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616616893; bh=IiJmAoTbgzkBZgDkD6vb7PAVebvPM2D0hB/bUS/ddvI=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=BUR5xRzBCA2UMmjw2yjrWB2/+NsrY0psc9u3Fjqf/JeB9f3wQg/KT/7F0RKEzsV9O lzXNZ4GBJgIaQ5cnf4MQAJLQ7b9JhELrNeYQ1CHHAxqih8clRXwzvAbkV8sKhpU9CQ iWwmCFWkbZeN8wrmPSdXqiyl9144Tzc1guzFlY2Dj6Czm/PE715av3YdbniNToqW7f +o9DyDDPmRBdeP7a0kJ159Yu++5nZapFDAvdAF86XCSuJuY1+Nu/ZII12QRVXHPKrc VTHIpX9BiWfJbY/WNMtcmDnYZj9jpxo9miqg3iBphOBCWYGjPsrfBU26363zg5zjU0 dZ6fCtmXBHKPg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616618153; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IiJmAoTbgzkBZgDkD6vb7PAVebvPM2D0hB/bUS/ddvI=; b=U2CF/hldQ9XwOgzA3hYvMBo2X4omxf1zedRmOHti+Ucz7nte6MZykS7x9ZckTopMK8ah+M elEHTNB6t/CmRlpwgtdNIapln9ev8aiC1jiHlJ2y/pthQh3xnoiopeKclMIBZvDNRq1gdT wqQtYK+7ykp0ra4ZS9qR2p45riICrJY7YANr2YehWbJExBcqTsHrDuMdOeWt0GsxGQ/S+9 hVwBMHBSgdy2AD5apKfXentvUgGCzkoFOpOY9CqbolgDpL9R6I/Nkf4ErVDWPnqQTfOCER VhV4diZjScZpJKGtfH/dQgvPBVpcf5bKFTBkpByxS9OKeBA4XOro18FNNsJOsQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616618153; a=rsa-sha256; cv=none; b=BsLkhP+I0w7uiH+exzKTB7d47K74zi1iSwX66XyLLkXJxAjM3aiXvwrvmDphKfojpKt38c 6Z96LFqpGKM77iZtnwoqmaZOYgWF0wQyD0vO49nr7AgmMAcK8dfXNMzIypidxF5AfBYQJx 2nf0dHO+OksUUim7yPj6T1q39is3dDmEnUcJ0Ufy2Qi1cv3zl4Gps5FE8z/krLnZIBBFjo 5egYnyVX+mSd1ToX/ijJCkYpLl/BBdITNYjSYMGtKRCrUdI+LRO5PQ3ttoG9aOB2qci8ld zdJ0g9/ZQ7NuqOiHr6lYWHrM2pJp7B7ayuiT3tATmFA9eiLLOsaQcLWG9Q+LMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=BUR5xRzB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=BUR5xRzB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1BD79125F2 X-Spam-Score: -3.97 X-Migadu-Scanner: scn0.migadu.com X-TUID: CmR5EYJVVQnt --=-tMH3ZPrUwOGecO07Ewyp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2021-03-24 at 22:48 +0300, Oleg Pykhalov wrote: > +/proc/self/loginuid, which the libc 'getlogin' function relies on. When > +GNUPG? is true, require the 'pam_gnupg.so' module; that module hands ove= r > +login password to 'gpg-agent'." Linguistic nitpick: There seems to be an article missing before "login password". Maybe add "the". Also, ideally speaking, there would be a system test in "gnu/tests/" for this new functionality. Otherwise no comments, seems good to me to go into the repo though maybe someone else wants to comment as well.=20 Greetings, Maxime --=-tMH3ZPrUwOGecO07Ewyp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYFudtxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vAAAQDv/tWBol6/FmZwL9jpcO9i3nNH MiOKg7limFFCwX4pkAEA7CrmIXRxjsogoN/flro+D5Fou+Gcnxl2ow9FPGo/IAo= =WUWC -----END PGP SIGNATURE----- --=-tMH3ZPrUwOGecO07Ewyp--